Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-30 Thread Marc Zyngier
On 30/11/17 12:28, Arnd Bergmann wrote: > On Thu, Nov 30, 2017 at 4:39 AM, Andrew Morton > wrote: >> On Wed, 29 Nov 2017 19:27:45 -0800 Linus Torvalds >> wrote: >> >>> On Wed, Nov 29, 2017 at 6:58 PM, Steven Rostedt wrote: Seems it can't handle the initialization of an anonymous struc

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-30 Thread Anna Schumaker
On 11/30/2017 06:46 AM, Trond Myklebust wrote: > On Wed, 2017-11-29 at 23:05 -0500, Steven Rostedt wrote: >> On Wed, 29 Nov 2017 19:44:33 -0800 >> Linus Torvalds wrote: >> >> I keep older compilers around to test ftrace before -mfentry was >> introduced. >> >> I wonder if I should just add a con

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-30 Thread Arnd Bergmann
On Thu, Nov 30, 2017 at 4:39 AM, Andrew Morton wrote: > On Wed, 29 Nov 2017 19:27:45 -0800 Linus Torvalds > wrote: > >> On Wed, Nov 29, 2017 at 6:58 PM, Steven Rostedt wrote: >> > >> > Seems it can't handle the initialization of an anonymous struct within >> > an anonymous union. >> >> I think

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-30 Thread Trond Myklebust
On Wed, 2017-11-29 at 23:05 -0500, Steven Rostedt wrote: > On Wed, 29 Nov 2017 19:44:33 -0800 > Linus Torvalds wrote: > > I keep older compilers around to test ftrace before -mfentry was > introduced. > > I wonder if I should just add a config to force the use without > -mfentry even if the comp

RE: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-30 Thread David Laight
From: Steven Rostedt > Sent: 30 November 2017 02:59 > Subject: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4 FWIW I can't build the current kernel with gcc 4.7.3-1ubuntu1 under ubuntu 13.04. The compiler generates some object files that binutils (objdump/ld) 2.23.2 says

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-29 Thread Steven Rostedt
On Wed, 29 Nov 2017 19:44:33 -0800 Linus Torvalds wrote: I keep older compilers around to test ftrace before -mfentry was introduced. I wonder if I should just add a config to force the use without -mfentry even if the compiler supports it. > fs/nfs/nfs4state.c | 3 +-- > include/linux/nfs4.

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-29 Thread Andrew Morton
On Wed, 29 Nov 2017 19:44:33 -0800 Linus Torvalds wrote: > On Wed, Nov 29, 2017 at 7:39 PM, Andrew Morton > wrote: > > > > Yeah, I'm the world expert at working around this gcc bug but the nfs4 > > one had me stumped when I looked at it, so I shelved it for revisiting > > later. > > Does the a

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-29 Thread Linus Torvalds
On Wed, Nov 29, 2017 at 7:39 PM, Andrew Morton wrote: > > Yeah, I'm the world expert at working around this gcc bug but the nfs4 > one had me stumped when I looked at it, so I shelved it for revisiting > later. Does the attached patch fix it? I don't have old compilers. Linus fs/nfs/

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-29 Thread Andrew Morton
On Wed, 29 Nov 2017 19:27:45 -0800 Linus Torvalds wrote: > On Wed, Nov 29, 2017 at 6:58 PM, Steven Rostedt wrote: > > > > Seems it can't handle the initialization of an anonymous struct within > > an anonymous union. > > I think we've seen this before, and I think there was some trick to > mak

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-29 Thread Linus Torvalds
On Wed, Nov 29, 2017 at 6:58 PM, Steven Rostedt wrote: > > Seems it can't handle the initialization of an anonymous struct within > an anonymous union. I think we've seen this before, and I think there was some trick to make it work with older gcc versions. Maybe the unnamed entry that gets init

[BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-29 Thread Steven Rostedt
Just letting you know that this commit: fcd8843c406 ('NFSv4: Replace closed stateids with the "invalid special stateid"') causes gcc 4.5.4 to fail the build with this error: CC [M] fs/nfs/nfs4state.o /work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: error: field name not in record or union i