Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

2007-05-26 Thread Patrick McHardy
Ingo Oeser wrote: > On Saturday 26 May 2007, Patrick McHardy wrote: > >>net/8021q ignores the VLAN header overhead, so we should probably do the >>same here for consistency. Using IS_VLAN_IP (and IS_PPPOE_IP for current >>-rc) looks fine, additionally we should probably also check for >>skb->nfct

Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

2007-05-26 Thread Ingo Oeser
On Saturday 26 May 2007, Patrick McHardy wrote: > Adam Osuchowski wrote: > > if (((skb->protocol == htons(ETH_P_IP) && skb->len > skb->dev->mtu) || > > (IS_VLAN_IP(skb) && skb->len > skb->dev->mtu - VLAN_HLEN)) && > > !skb_is_gso(skb)) > > return ip_fragment ... > > > net/

Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

2007-05-26 Thread Patrick McHardy
Adam Osuchowski wrote: > Stephen Hemminger wrote: > >>It would be better to account for the tag in the length check. >>Something like >> if (skb->protocol == htons(ETH_P_IP) && >> skb->len > skb->dev->mtu - (IS_VLAN_IP(skb) ? VLAN_HLEN : 0) && >> !skb_is_gso(skb)) >>

Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

2007-05-25 Thread Adam Osuchowski
Stephen Hemminger wrote: > It would be better to account for the tag in the length check. > Something like > if (skb->protocol == htons(ETH_P_IP) && > skb->len > skb->dev->mtu - (IS_VLAN_IP(skb) ? VLAN_HLEN : 0) && > !skb_is_gso(skb)) > return ip_fragment ...

Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

2007-05-25 Thread Stephen Hemminger
On Fri, 25 May 2007 10:17:50 +0200 Adam Osuchowski <[EMAIL PROTECTED]> wrote: > There is a problem with fragmented IP packet sent within 802.1Q tagged > ethernet frame through bridge. Problem exists when conntrack is enabled > (i.e. nf_conntrack_ipv4 module is loaded). Then, such packets are not >