Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-17 Thread Bjorn Helgaas
On Tue, Mar 11, 2014 at 6:52 AM, Andreas Noever wrote: > On Tue, Mar 11, 2014 at 1:10 AM, Bjorn Helgaas wrote: >> On Tue, Mar 11, 2014 at 12:10:02AM +0100, Andreas Noever wrote: >>> On Mon, Mar 10, 2014 at 9:43 PM, Bjorn Helgaas wrote: >>> > On Sat, Mar 8, 2014 at 2:55 AM, Andreas Noever >>> >

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-11 Thread Andreas Noever
On Tue, Mar 11, 2014 at 1:10 AM, Bjorn Helgaas wrote: > On Tue, Mar 11, 2014 at 12:10:02AM +0100, Andreas Noever wrote: >> On Mon, Mar 10, 2014 at 9:43 PM, Bjorn Helgaas wrote: >> > On Sat, Mar 8, 2014 at 2:55 AM, Andreas Noever >> > wrote: >> >> On Sat, Mar 8, 2014 at 2:04 AM, Bjorn Helgaas w

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-10 Thread Bjorn Helgaas
On Tue, Mar 11, 2014 at 12:10:02AM +0100, Andreas Noever wrote: > On Mon, Mar 10, 2014 at 9:43 PM, Bjorn Helgaas wrote: > > On Sat, Mar 8, 2014 at 2:55 AM, Andreas Noever > > wrote: > >> On Sat, Mar 8, 2014 at 2:04 AM, Bjorn Helgaas wrote: > > > >>> If we did that, INTX_DISABLE would be cleared

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-10 Thread Bjorn Helgaas
On Sat, Mar 8, 2014 at 2:55 AM, Andreas Noever wrote: > On Sat, Mar 8, 2014 at 2:04 AM, Bjorn Helgaas wrote: >> If we did that, INTX_DISABLE would be cleared by the first >> pci_enable_device() and pci_reenable_device() wouldn't do anything, >> leaving it cleared. The resulting state (cleared)

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-08 Thread Andreas Noever
On Sat, Mar 8, 2014 at 2:04 AM, Bjorn Helgaas wrote: > [+cc Rafael] > > On Fri, Mar 07, 2014 at 11:39:48AM -0800, Yinghai Lu wrote: >> On Fri, Mar 7, 2014 at 8:45 AM, Bjorn Helgaas wrote: >> > >> > I opened a bugzilla report at >> > https://bugzilla.kernel.org/show_bug.cgi?id=71691 >> > >> > It

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-07 Thread Bjorn Helgaas
[+cc Rafael] On Fri, Mar 07, 2014 at 11:39:48AM -0800, Yinghai Lu wrote: > On Fri, Mar 7, 2014 at 8:45 AM, Bjorn Helgaas wrote: > > > > I opened a bugzilla report at > > https://bugzilla.kernel.org/show_bug.cgi?id=71691 > > > > It seems like clearing DisINTx has some effect on MSI. I don't see

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-07 Thread Yinghai Lu
On Fri, Mar 7, 2014 at 8:45 AM, Bjorn Helgaas wrote: > > I opened a bugzilla report at > https://bugzilla.kernel.org/show_bug.cgi?id=71691 > > It seems like clearing DisINTx has some effect on MSI. I don't see > anything in the spec that would suggest this (I'm looking at the PCIe > r3.0 spec, s

Re: [Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-07 Thread Bjorn Helgaas
[+cc Yinghai, Rajat] On Fri, Mar 7, 2014 at 7:33 AM, Andreas Noever wrote: > Hi, > > After upgrading to the latest RC I noticed that suprise removal > stopped working. Linux did not notice that the devices where gone. > Bisection points to > > 1f42db786b14a31bf807fc41ee5583a00c08fcb1 PCI: Enable

[Bug] PCI: Enable INTx if BIOS left them disabled - triggers during rescan

2014-03-07 Thread Andreas Noever
Hi, After upgrading to the latest RC I noticed that suprise removal stopped working. Linux did not notice that the devices where gone. Bisection points to 1f42db786b14a31bf807fc41ee5583a00c08fcb1 PCI: Enable INTx if BIOS left them disabled http://git.kernel.org/cgit/linux/kernel/git/torvalds/linu