Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-28 Thread Jeremiah Mahler
Gerry, On Mon, Dec 28, 2015 at 04:24:32PM +0800, Jiang Liu wrote: [...] > Hi Jeremiah, > Could you please help to confirm which commit caused the > regression? > 1) x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary > buffer > 2) x86/irq: Fix a race condition between vector

Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-28 Thread Jiang Liu
On 2015/12/24 13:15, Jeremiah Mahler wrote: > Jiang, > > On Wed, Dec 23, 2015 at 10:13:26PM +0800, Jiang Liu wrote: >> Function __assign_irq_vector() makes use of apic_chip_data.old_domain >> as a temporary buffer, which causes trouble to rollback logic in case of >> failure. So use a dedicated te

Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-24 Thread Joe Lawrence
On 12/23/2015 09:13 AM, Jiang Liu wrote: Function __assign_irq_vector() makes use of apic_chip_data.old_domain as a temporary buffer, which causes trouble to rollback logic in case of failure. So use a dedicated temporary buffer for __assign_irq_vector(). Signed-off-by: Jiang Liu Hi Jiang, F

Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-23 Thread Jeremiah Mahler
Jiang, On Wed, Dec 23, 2015 at 10:13:26PM +0800, Jiang Liu wrote: > Function __assign_irq_vector() makes use of apic_chip_data.old_domain > as a temporary buffer, which causes trouble to rollback logic in case of > failure. So use a dedicated temporary buffer for __assign_irq_vector(). > > Signed

Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-23 Thread Borislav Petkov
On Wed, Dec 23, 2015 at 10:13:26PM +0800, Jiang Liu wrote: > Function __assign_irq_vector() makes use of apic_chip_data.old_domain > as a temporary buffer, which causes trouble to rollback logic in case of > failure. So use a dedicated temporary buffer for __assign_irq_vector(). > > Signed-off-by:

[Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-23 Thread Jiang Liu
Function __assign_irq_vector() makes use of apic_chip_data.old_domain as a temporary buffer, which causes trouble to rollback logic in case of failure. So use a dedicated temporary buffer for __assign_irq_vector(). Signed-off-by: Jiang Liu --- arch/x86/kernel/apic/vector.c |9 + 1 fi