Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-24 Thread Nadav Amit
> On Nov 24, 2014, at 19:53, Paolo Bonzini wrote: > > > > On 24/11/2014 16:28, Nadav Amit wrote: >> >> Since kvm_load_guest_fpu is called before the guest_fpu is ever stored, >> there are 2 more problems that currently cause #GP: >> 1. XCOMP_BV[63] = 0 >> 2. XSTATE_BV sets a bit (including b

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-24 Thread Paolo Bonzini
On 24/11/2014 16:28, Nadav Amit wrote: > > Since kvm_load_guest_fpu is called before the guest_fpu is ever stored, there > are 2 more problems that currently cause #GP: > 1. XCOMP_BV[63] = 0 > 2. XSTATE_BV sets a bit (including bit 63) that is not set in XCOMP_BV > (XCOMP_BV is initialised to

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-24 Thread Paolo Bonzini
On 24/11/2014 16:28, Nadav Amit wrote: > Since kvm_load_guest_fpu is called before the guest_fpu is ever stored, there > are 2 more problems that currently cause #GP: > 1. XCOMP_BV[63] = 0 > 2. XSTATE_BV sets a bit (including bit 63) that is not set in XCOMP_BV > (XCOMP_BV is initialised to zer

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-24 Thread Nadav Amit
> On Nov 24, 2014, at 13:39, Paolo Bonzini wrote: > > > > On 23/11/2014 09:16, Nadav Amit wrote: >> I’ll try to check it tomorrow (I don’t have access to the failing machine at >> the moment). > > Thanks, you'll need to squash this in: > > diff --git a/arch/x86/kernel/xsave.c b/arch/x86/ker

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-24 Thread Paolo Bonzini
On 23/11/2014 09:16, Nadav Amit wrote: > I’ll try to check it tomorrow (I don’t have access to the failing machine at > the moment). Thanks, you'll need to squash this in: diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c index 4c540c4719d8..0de1fae2bdf0 100644 --- a/arch/x86/kern

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Wanpeng Li
On 11/23/14, 4:31 PM, Nadav Amit wrote: On Nov 23, 2014, at 10:24, Wanpeng Li wrote: Hi Nadav, On 11/23/14, 4:16 PM, Nadav Amit wrote: I’ll try to check it tomorrow (I don’t have access to the failing machine at the moment). If the machine you mentioned support xsaves and what's machine you

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Nadav Amit
> On Nov 23, 2014, at 10:24, Wanpeng Li wrote: > > Hi Nadav, > On 11/23/14, 4:16 PM, Nadav Amit wrote: >> I’ll try to check it tomorrow (I don’t have access to the failing machine at >> the moment). > > If the machine you mentioned support xsaves and what's machine you are using? It supports

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Wanpeng Li
Hi Nadav, On 11/23/14, 4:16 PM, Nadav Amit wrote: I’ll try to check it tomorrow (I don’t have access to the failing machine at the moment). If the machine you mentioned support xsaves and what's machine you are using? Regards, Wanpeng Li Thanks for the quick response. Nadav On Nov 21,

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Nadav Amit
I’ll try to check it tomorrow (I don’t have access to the failing machine at the moment). Thanks for the quick response. Nadav > On Nov 21, 2014, at 20:31, Paolo Bonzini wrote: > > The first patch ensures that XSAVES is not exposed in the guest until > we emulate MSR_IA32_XSS. The second exp

[CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-21 Thread Paolo Bonzini
The first patch ensures that XSAVES is not exposed in the guest until we emulate MSR_IA32_XSS. The second exports XSAVE data in the correct format. I tested these on a non-XSAVES system so they should not be completely broken, but I need some help. I am not even sure which XSAVE states are _not_