[patch] [checker] 120 potential dereference to invalid pointers errors for linux 2.4.1

2001-03-24 Thread Andrew Morton
This gets us about 1/3 of the way through this one. Affected files: fs/proc/generic.c arch/i386/kernel/irq.c arch/i386/kernel/mtrr.c drivers/acpi/dispatcher/dswload.c drivers/atm/zatm.c drivers/block/DAC960.c drivers/block/ll_rw_blk.c drivers/char/pc_keyb.c drivers/char/rio/rio_linux.c drivers/m

Re: [CHECKER] 120 potential dereference to invalid pointers errors

2001-03-21 Thread Benjamin Chelf
Hi, I'm interested in one specific "bug" reported out of these 120 and no one seems to have responded about it yet. It reports the error on line 889 (drivers/scsi/sd.c), but line 825 also seems bad (memsetting the pointer that was allocated before checking for NULL). This piece of code seems to

RE: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1

2001-03-19 Thread Grover, Andrew
Well the ACPI bugs look legitimate. We'll work on getting those fixed. Thanks for your efforts! Regards -- Andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [CHECKER] 120 potential dereference to invalid pointers errors forlinux 2.4.1

2001-03-19 Thread Andreas Dilger
Jeff Garzic writes: > > [BUG] init_etherdev could return NULL > > /u2/acc/oses/linux/2.4.1/drivers/net/3c515.c:604:corkscrew_found_device: >ERROR:NULL:603:604: Using unknown ptr "dev" illegally! set by 'init_etherdev':603 > > > > Start ---> > > dev = init_etherdev(dev, sizeof(struct cork

Re: [CHECKER] 120 potential dereference to invalid pointers errors forlinux 2.4.1

2001-03-18 Thread Keith Owens
On Sun, 18 Mar 2001 06:29:50 -0500, Jeff Garzik <[EMAIL PROTECTED]> wrote: >Junfeng Yang wrote: >> Start ---> >> busy = kmalloc(sizeof(erase_busy_t), GFP_KERNEL); >> Error ---> > >This sizeof() construct may be a special case for your checker, but it's >a common one for the kernel...

Re: [CHECKER] 120 potential dereference to invalid pointers errors forlinux 2.4.1

2001-03-18 Thread Jeff Garzik
Junfeng Yang wrote: > [BUG] dev_alloc_skb can return NULL > /u2/acc/oses/linux/2.4.1/drivers/net/3c505.c:619:receive_packet: ERROR:NULL:598:619: >Using NULL ptr "skb" illegally! set by 'dev_alloc_skb':598 Fixed. > [BUG] init_etherdev could return NULL > /u2/acc/oses/linux/2.4.1/drivers/net/3c5

Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1

2001-03-17 Thread Greg KH
On Sat, Mar 17, 2001 at 01:30:54AM -0800, Junfeng Yang wrote: > - > [BUG] dereference to invalid pointer "bluetooth" in error message > /u2/acc/oses/linux/2.4.1/drivers/usb/bluetooth.c:924:bluetooth_read_bulk_callback: >ERROR:NULL:828:924: U

Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1

2001-03-17 Thread Andy Chou
> > [BUG] fore200e_kmalloc can return NULL > > /u2/acc/oses/linux/2.4.1/drivers/atm/fore200e.c:2032:fore200e_get_esi: >ERROR:NULL:2020:2032: Using unknown ptr "prom" illegally! set by >'fore200e_kmalloc':2020 > > I don't see the bug - there is an explicit "if(!prom) return -ENOMEM;" after > the

Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1

2001-03-17 Thread Mitchell Blank Jr
Junfeng Yang wrote: > [BUG] fore200e_kmalloc can return NULL > /u2/acc/oses/linux/2.4.1/drivers/atm/fore200e.c:2032:fore200e_get_esi: >ERROR:NULL:2020:2032: Using unknown ptr "prom" illegally! set by >'fore200e_kmalloc':2020 I don't see the bug - there is an explicit "if(!prom) return -ENOMEM;"

[CHECKER] 120 potential dereference to invalid pointers errors forlinux 2.4.1

2001-03-17 Thread Junfeng Yang
Hi, This checker warns when the pointer returned by a "plausibly" failing routine is not checked before being used. It automatically builds up the list of failing routines by examining all callsites. If a function's returned pointer is checked at more than one callsite, the checker ensures it i