Al Viro writes:
> On Tue, 29 May 2001, Andreas Dilger wrote:
> > For ext2 it is pretty much the same, except ext2_delete_entry() called
> > ext2_check_dir_entry() with a NULL input (for some reason), but it could
> > easily supply a valid input value. All callers to ext2_delete_entry()
> >
Al Viro writes:
On Tue, 29 May 2001, Andreas Dilger wrote:
For ext2 it is pretty much the same, except ext2_delete_entry() called
ext2_check_dir_entry() with a NULL input (for some reason), but it could
easily supply a valid input value. All callers to ext2_delete_entry()
dereference
> And if you look a couple lines previous it is blindly dereferenced,
> this should have been a clue :-)
There's a lot of places where code checks and then blindly
dereferences, so I don't think that's much of a clue ;-)
> > Start --->
> >struct rtable *rt = skb ? (struct rtable*)skb->dst
[ Steve: Just skim down to the decnet bug, you should have a look
at it.
Philip: Similarly, skim down to the econet bug. ]
Dawson Engler writes:
> [BUG] sends sk raw to a bunch of other routines. doesn't seem good.
>
Hi All,
enclosed are 84 potential errors where code
(1) checks if a pointer is null
(2) dereferences it anyway.
For example the code:
Start --> if (!(result = iget(dir->i_sb, ino))) {
hpfs_unlock_iget(dir->i_sb);
Error --->
Hi All,
enclosed are 84 potential errors where code
(1) checks if a pointer is null
(2) dereferences it anyway.
For example the code:
Start -- if (!(result = iget(dir-i_sb, ino))) {
hpfs_unlock_iget(dir-i_sb);
Error ---
[ Steve: Just skim down to the decnet bug, you should have a look
at it.
Philip: Similarly, skim down to the econet bug. ]
Dawson Engler writes:
[BUG] sends sk raw to a bunch of other routines. doesn't seem good.
And if you look a couple lines previous it is blindly dereferenced,
this should have been a clue :-)
There's a lot of places where code checks and then blindly
dereferences, so I don't think that's much of a clue ;-)
Start ---
struct rtable *rt = skb ? (struct rtable*)skb-dst : NULL;
8 matches
Mail list logo
