Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-02-04 Thread Paolo Bonzini
On 04/02/2016 00:32, Nadav Amit wrote: > Sorry for spamming. The correct fix appears to reload the DRs (set > KVM_DEBUGREG_RELOAD) in kvm_arch_vcpu_load . Yup, that was my intended thing to test, but unfortunately I'm travelling and doing all the testing on the laptop is a bit hard. Thanks

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-02-04 Thread Paolo Bonzini
On 04/02/2016 00:32, Nadav Amit wrote: > Sorry for spamming. The correct fix appears to reload the DRs (set > KVM_DEBUGREG_RELOAD) in kvm_arch_vcpu_load . Yup, that was my intended thing to test, but unfortunately I'm travelling and doing all the testing on the laptop is a bit hard. Thanks

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-02-03 Thread Nadav Amit
Sorry for spamming. The correct fix appears to reload the DRs (set KVM_DEBUGREG_RELOAD) in kvm_arch_vcpu_load . (for me it works) Regards, Nadav Nadav Amit wrote: > I think the problem lies here: > >/* > * If the guest has used debug registers, at least dr7 > *

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-02-03 Thread Nadav Amit
I think the problem lies here: /* * If the guest has used debug registers, at least dr7 * will be disabled while returning to the host. * If we don't have active breakpoints in the host, we don't * care about the messed up debug address registers. But

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-02-03 Thread Nadav Amit
Sorry for spamming. The correct fix appears to reload the DRs (set KVM_DEBUGREG_RELOAD) in kvm_arch_vcpu_load . (for me it works) Regards, Nadav Nadav Amit wrote: > I think the problem lies here: > >/* > * If the guest has used debug registers, at

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-02-03 Thread Nadav Amit
I think the problem lies here: /* * If the guest has used debug registers, at least dr7 * will be disabled while returning to the host. * If we don't have active breakpoints in the host, we don't * care about the messed up debug address registers. But

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-01-31 Thread Paolo Bonzini
On 29/01/2016 23:21, Andrew Vagin wrote: > On Thu, Jan 28, 2016 at 02:42:25PM -0800, Andrey Wagin wrote: >> On Thu, Jan 28, 2016 at 10:33:28PM +0100, Paolo Bonzini wrote: >>> >>> >>> On 28/01/2016 09:31, Andrey Wagin wrote: I tried to print drX registers after a break-point. Looks like they

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-01-31 Thread Paolo Bonzini
On 29/01/2016 23:21, Andrew Vagin wrote: > On Thu, Jan 28, 2016 at 02:42:25PM -0800, Andrey Wagin wrote: >> On Thu, Jan 28, 2016 at 10:33:28PM +0100, Paolo Bonzini wrote: >>> >>> >>> On 28/01/2016 09:31, Andrey Wagin wrote: I tried to print drX registers after a break-point. Looks like they

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-01-29 Thread Andrew Vagin
On Thu, Jan 28, 2016 at 02:42:25PM -0800, Andrey Wagin wrote: > On Thu, Jan 28, 2016 at 10:33:28PM +0100, Paolo Bonzini wrote: > > > > > > On 28/01/2016 09:31, Andrey Wagin wrote: > > > I tried to print drX registers after a break-point. Looks like they > > > are set correctly. > > > > Can you

Re: [CRIU] x86: Hardware breakpoints are not always triggered

2016-01-29 Thread Andrew Vagin
On Thu, Jan 28, 2016 at 02:42:25PM -0800, Andrey Wagin wrote: > On Thu, Jan 28, 2016 at 10:33:28PM +0100, Paolo Bonzini wrote: > > > > > > On 28/01/2016 09:31, Andrey Wagin wrote: > > > I tried to print drX registers after a break-point. Looks like they > > > are set correctly. > > > > Can you