Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Greg Kroah-Hartman
On Wed, Apr 16, 2014 at 05:12:30PM -0700, Frank Rowand wrote: > pr_debug() parameters are reverse order of format string > > Signed-off-by: Frank Rowand > --- > > drivers/base/dd.c |4 2 + 2 - 0 ! > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: b/drivers/base/dd.c

Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Joe Perches
On Wed, 2014-04-16 at 18:12 -0700, Frank Rowand wrote: > On 4/16/2014 5:48 PM, Joe Perches wrote: > > On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote: > >> pr_debug() parameters are reverse order of format string > > > > Another way to do this might be to change all the > > printks/pr_debugs

Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Frank Rowand
On 4/16/2014 5:48 PM, Joe Perches wrote: > On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote: >> pr_debug() parameters are reverse order of format string > > Another way to do this might be to change all the > printks/pr_debugs to dev_ Yes, but if that is done, one may as well do all of drive

Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Joe Perches
On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote: > pr_debug() parameters are reverse order of format string Another way to do this might be to change all the printks/pr_debugs to dev_ Something like: --- drivers/base/dd.c | 35 +-- 1 file changed, 17 inserti

[DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Frank Rowand
pr_debug() parameters are reverse order of format string Signed-off-by: Frank Rowand --- drivers/base/dd.c |4 2 + 2 - 0 ! 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/base/dd.c === --- a/driv