Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:36:22 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > with the patch all headers are checked. the code should become > > more resistant to on-disk corruptions. needless BUG_ON() have > > been removed. please,

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao [EMAIL PROTECTED] wrote: with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 08:57:51 -0500 Dave Kleikamp <[EMAIL PROTECTED]> wrote: > On Thu, 2007-07-12 at 12:38 +0100, Andy Whitcroft wrote: > > Andrew Morton wrote: > > >> +if (ext4_ext_check_header(inode, > > >> ext_block_hdr(bh), > > >> +

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Dave Kleikamp
On Thu, 2007-07-12 at 12:38 +0100, Andy Whitcroft wrote: > Andrew Morton wrote: > >> + if (ext4_ext_check_header(inode, ext_block_hdr(bh), > >> + depth - i - 1)) { > >> + err = -EIO; > >> +

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Andy Whitcroft
Andrew Morton wrote: > On Sun, 01 Jul 2007 03:36:22 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > >> with the patch all headers are checked. the code should become >> more resistant to on-disk corruptions. needless BUG_ON() have >> been removed. please, review for inclusion. >> >> ... > >>

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Andy Whitcroft
Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao [EMAIL PROTECTED] wrote: with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for inclusion. ... @@ -269,6 +239,70

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Dave Kleikamp
On Thu, 2007-07-12 at 12:38 +0100, Andy Whitcroft wrote: Andrew Morton wrote: + if (ext4_ext_check_header(inode, ext_block_hdr(bh), + depth - i - 1)) { + err = -EIO; +

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 08:57:51 -0500 Dave Kleikamp [EMAIL PROTECTED] wrote: On Thu, 2007-07-12 at 12:38 +0100, Andy Whitcroft wrote: Andrew Morton wrote: +if (ext4_ext_check_header(inode, ext_block_hdr(bh), +

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > with the patch all headers are checked. the code should become > more resistant to on-disk corruptions. needless BUG_ON() have > been removed. please, review for inclusion. > > ... > @@ -269,6 +239,70 @@ > return

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao [EMAIL PROTECTED] wrote: with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for inclusion. ... @@ -269,6 +239,70 @@ return size;

[EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-01 Thread Mingming Cao
with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for inclusion. Signed-off-by: Alex Tomas <[EMAIL PROTECTED]> Signed-off-by: Mingming Cao <[EMAIL PROTECTED]> Index:

[EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-01 Thread Mingming Cao
with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for inclusion. Signed-off-by: Alex Tomas [EMAIL PROTECTED] Signed-off-by: Mingming Cao [EMAIL PROTECTED] Index: