Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-08-06 Thread Mingming Cao
On Wed, 2007-08-01 at 12:34 +0530, Girish Shilamkar wrote: > On Wed, 2007-07-11 at 17:16 +0530, Girish Shilamkar wrote: > > > I will make the changes and send an incremental patch. > > > Hi, > I have made the changes and attached the incremental patch as per the > review. Thanks, I merged

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-08-01 Thread Girish Shilamkar
On Wed, 2007-07-11 at 17:16 +0530, Girish Shilamkar wrote: > I will make the changes and send an incremental patch. > Hi, I have made the changes and attached the incremental patch as per the review. This is the actual changelog which was missing in the original patch. -- The journa

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 07:01:08 -0600 Andreas Dilger <[EMAIL PROTECTED]> wrote: > > > > - /* AKPM: buglet - add `i' to tmp! */ > > > > > > Damn. After, what, seven years, someone actually fixed it? > > > > > > > for (i = 0; i < bh->b_size; i += 512) { > > > > - journal_

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-11 Thread Andreas Dilger
On Jul 11, 2007 17:16 +0530, Girish Shilamkar wrote: > > > + if (test_opt(sb, JOURNAL_ASYNC_COMMIT)) { > > > + jbd2_journal_set_features(sbi->s_journal, > > > + JBD2_FEATURE_COMPAT_CHECKSUM, 0, > > > + JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT); > >

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-11 Thread Girish Shilamkar
On Tue, 2007-07-10 at 23:16 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:38:25 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > Journal checksum feature has been added to detect corruption of journal. > > That was brief. No description of what it does, how it does it, why it > does it

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:25 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Journal checksum feature has been added to detect corruption of journal. That was brief. No description of what it does, how it does it, why it does it, how one operates it, why (or why not) one would choose to enable i

[EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-01 Thread Mingming Cao
Journal checksum feature has been added to detect corruption of journal. Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> Signed-off-by: Girish Shilamkar <[EMAIL PROTECTED]> Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> diff -Nurp linux024/fs/ext4/super.c linux/fs/ext4/super.c --- linux024/fs