Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-06-02 Thread Daniel Phillips
On Thursday 31 May 2001 21:44, Andreas Dilger wrote: > I noticed something interesting when running "mongo" with debugging > on. It is adding filenames which are only sequential numbers, and the > hash code is basically adding to only two blocks until those blocks > are full, at which point (I

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-06-02 Thread Daniel Phillips
On Thursday 31 May 2001 21:44, Andreas Dilger wrote: I noticed something interesting when running mongo with debugging on. It is adding filenames which are only sequential numbers, and the hash code is basically adding to only two blocks until those blocks are full, at which point (I guess)

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-05-31 Thread Andreas Dilger
Daniel writes: > On Thursday 31 May 2001 21:44, Andreas Dilger wrote: > > I think Al's idea of doing the validation once on the initial > > read is a good one. > > I'm doing that in the current patch, for leaf blocks, look at > ext2_bread. For index blocks, ext2_bread needs help to know that a

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-05-31 Thread Daniel Phillips
On Thursday 31 May 2001 21:44, Andreas Dilger wrote: > Daniel, you write: > > - Fall back to linear search in case of corrupted index > > OK, I have _some_ of the code needed to do this, but in one case I'm > not sure of what your intention was - in dx_probe() you check for > "unused_flags & 1"

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-05-31 Thread Andreas Dilger
Daniel, you write: > - Fall back to linear search in case of corrupted index OK, I have _some_ of the code needed to do this, but in one case I'm not sure of what your intention was - in dx_probe() you check for "unused_flags & 1" to signal a bad/unsupported index. Why only check the low bit

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-05-31 Thread Andreas Dilger
Daniel, you write: - Fall back to linear search in case of corrupted index OK, I have _some_ of the code needed to do this, but in one case I'm not sure of what your intention was - in dx_probe() you check for unused_flags 1 to signal a bad/unsupported index. Why only check the low bit

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-05-31 Thread Daniel Phillips
On Thursday 31 May 2001 21:44, Andreas Dilger wrote: Daniel, you write: - Fall back to linear search in case of corrupted index OK, I have _some_ of the code needed to do this, but in one case I'm not sure of what your intention was - in dx_probe() you check for unused_flags 1 to signal

Re: [Ext2-devel] [UPDATE] Directory index for ext2

2001-05-31 Thread Andreas Dilger
Daniel writes: On Thursday 31 May 2001 21:44, Andreas Dilger wrote: I think Al's idea of doing the validation once on the initial read is a good one. I'm doing that in the current patch, for leaf blocks, look at ext2_bread. For index blocks, ext2_bread needs help to know that a block