Re: [Ext2-devel] Re: [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-08 Thread Suparna Bhattacharya
On Mon, Mar 07, 2005 at 11:37:42PM -0800, Andrew Morton wrote: > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > (let me know if the interface in the patch > > I just posted seems like the right direction to use when we go for the > > cleanup) > > Well what are the semantics? Pass in an

Re: [Ext2-devel] Re: [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-07 Thread Andrew Morton
Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > (let me know if the interface in the patch > I just posted seems like the right direction to use when we go for the > cleanup) Well what are the semantics? Pass in an inclusive max_index and the gang lookup functions terminate when they hit an

Re: [Ext2-devel] Re: [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-07 Thread Suparna Bhattacharya
On Mon, Mar 07, 2005 at 10:46:18PM -0800, Andrew Morton wrote: > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > > > yup, looks like the same issue we hit in wait_on_page_writeback_range > > during AIO work - probably want to break out of the outer loop as well > > when this happens. >

Re: [Ext2-devel] Re: [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-07 Thread Andrew Morton
Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > yup, looks like the same issue we hit in wait_on_page_writeback_range > during AIO work - probably want to break out of the outer loop as well > when this happens. The `next = page_index' before breaking will do that for us. > > How hard w

Re: [Ext2-devel] Re: [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-07 Thread Suparna Bhattacharya
Just as an idea of what I meant (dug up an old WIP patch): --- radix-tree.c2004-04-01 10:32:15.384556136 +0530 +++ radix-tree.c.end2004-04-01 11:11:07.176069944 +0530 @@ -562,7 +562,8 @@ EXPORT_SYMBOL(radix_tree_gang_lookup); */ static unsigned int __lookup_tag(struct radix_tree_

Re: [Ext2-devel] Re: [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-07 Thread Suparna Bhattacharya
yup, looks like the same issue we hit in wait_on_page_writeback_range during AIO work - probably want to break out of the outer loop as well when this happens. >From the old changelog: >> >> wait_on_page_writeback_range shouldn't wait for pages beyond the >> specified range. Ideally, the radix-