Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-02-01 Thread Mike Kravetz
On 2/1/21 8:10 AM, David Hildenbrand wrote: >>> What's your opinion about this? Should we take this approach? >> >> I think trying to solve all the issues that could happen as the result of >> not being able to dissolve a hugetlb page has made this extremely complex. >> I know this is something we

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-02-01 Thread David Hildenbrand
What's your opinion about this? Should we take this approach? I think trying to solve all the issues that could happen as the result of not being able to dissolve a hugetlb page has made this extremely complex. I know this is something we need to address/solve. We do not want to add more

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-28 Thread Muchun Song
On Fri, Jan 29, 2021 at 9:04 AM Mike Kravetz wrote: > > On 1/28/21 4:37 AM, Muchun Song wrote: > > On Wed, Jan 27, 2021 at 6:36 PM David Hildenbrand wrote: > >> > >> On 26.01.21 16:56, David Hildenbrand wrote: > >>> On 26.01.21 16:34, Oscar Salvador wrote: > On Tue, Jan 26, 2021 at

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-28 Thread Muchun Song
On Fri, Jan 29, 2021 at 6:29 AM Oscar Salvador wrote: > > On Wed, Jan 27, 2021 at 11:36:15AM +0100, David Hildenbrand wrote: > > Extending on that, I just discovered that only x86-64, ppc64, and arm64 > > really support hugepage migration. > > > > Maybe one approach with the "magic switch" really

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-28 Thread Mike Kravetz
On 1/28/21 4:37 AM, Muchun Song wrote: > On Wed, Jan 27, 2021 at 6:36 PM David Hildenbrand wrote: >> >> On 26.01.21 16:56, David Hildenbrand wrote: >>> On 26.01.21 16:34, Oscar Salvador wrote: On Tue, Jan 26, 2021 at 04:10:53PM +0100, David Hildenbrand wrote: > The real issue seems to be

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-28 Thread Muchun Song
On Thu, Jan 28, 2021 at 8:37 PM Muchun Song wrote: > > On Wed, Jan 27, 2021 at 6:36 PM David Hildenbrand wrote: > > > > On 26.01.21 16:56, David Hildenbrand wrote: > > > On 26.01.21 16:34, Oscar Salvador wrote: > > >> On Tue, Jan 26, 2021 at 04:10:53PM +0100, David Hildenbrand wrote: > > >>> The

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-28 Thread Muchun Song
On Wed, Jan 27, 2021 at 6:36 PM David Hildenbrand wrote: > > On 26.01.21 16:56, David Hildenbrand wrote: > > On 26.01.21 16:34, Oscar Salvador wrote: > >> On Tue, Jan 26, 2021 at 04:10:53PM +0100, David Hildenbrand wrote: > >>> The real issue seems to be discarding the vmemmap on any memory that

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-26 Thread Oscar Salvador
On Mon, Jan 25, 2021 at 03:25:35PM -0800, Mike Kravetz wrote: > IIUC, even non-gigantic hugetlb pages can exist in CMA. They can be migrated > out of CMA if needed (except free pages in the pool, but that is a separate > issue David H already noted in another thread). Yeah, as discussed I am

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-25 Thread Muchun Song
On Mon, Jan 25, 2021 at 5:15 PM David Hildenbrand wrote: > > On 25.01.21 08:41, Muchun Song wrote: > > On Mon, Jan 25, 2021 at 2:40 PM Muchun Song > > wrote: > >> > >> On Mon, Jan 25, 2021 at 8:05 AM David Rientjes wrote: > >>> > >>> > >>> On Sun, 17 Jan 2021, Muchun Song wrote: > >>> >

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-25 Thread David Hildenbrand
On 25.01.21 08:41, Muchun Song wrote: > On Mon, Jan 25, 2021 at 2:40 PM Muchun Song wrote: >> >> On Mon, Jan 25, 2021 at 8:05 AM David Rientjes wrote: >>> >>> >>> On Sun, 17 Jan 2021, Muchun Song wrote: >>> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-25 Thread Mike Kravetz
On 1/25/21 1:34 AM, Muchun Song wrote: > On Mon, Jan 25, 2021 at 5:15 PM David Hildenbrand wrote: >> >> On 25.01.21 08:41, Muchun Song wrote: >>> On Mon, Jan 25, 2021 at 2:40 PM Muchun Song >>> wrote: On Mon, Jan 25, 2021 at 8:05 AM David Rientjes wrote: > > > On Sun, 17

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-24 Thread Muchun Song
On Mon, Jan 25, 2021 at 2:40 PM Muchun Song wrote: > > On Mon, Jan 25, 2021 at 8:05 AM David Rientjes wrote: > > > > > > On Sun, 17 Jan 2021, Muchun Song wrote: > > > > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > > > index ce4be1fa93c2..3b146d5949f3 100644 > > > ---

Re: [External] Re: [PATCH v13 05/12] mm: hugetlb: allocate the vmemmap pages associated with each HugeTLB page

2021-01-24 Thread Muchun Song
On Mon, Jan 25, 2021 at 8:05 AM David Rientjes wrote: > > > On Sun, 17 Jan 2021, Muchun Song wrote: > > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > > index ce4be1fa93c2..3b146d5949f3 100644 > > --- a/mm/sparse-vmemmap.c > > +++ b/mm/sparse-vmemmap.c > > @@ -29,6 +29,7 @@ > >