Re: [Fix PATCH] cpu/hotplug: Fix bug report when add "nosmt" parameter with CONFIG_HOTPLUG_CPU=N

2019-03-26 Thread Tianyu Lan
Hi Thomas: Thanks for your review. On Tue, Mar 26, 2019 at 6:39 AM Thomas Gleixner wrote: > > On Mon, 25 Mar 2019, Thomas Gleixner wrote: > > That has nothing to do with 'nosmt'. It's a general bug in the rollback > > code when HOTPLUG_CPU=n. 'nosmt' is using the rollback mechanism

Re: [Fix PATCH] cpu/hotplug: Fix bug report when add "nosmt" parameter with CONFIG_HOTPLUG_CPU=N

2019-03-25 Thread Thomas Gleixner
On Mon, 25 Mar 2019, Thomas Gleixner wrote: > That has nothing to do with 'nosmt'. It's a general bug in the rollback > code when HOTPLUG_CPU=n. 'nosmt' is using the rollback mechanism and is > just a reliable way to trigger the problem. This happens in the same way > when the bringup of a CPU

Re: [Fix PATCH] cpu/hotplug: Fix bug report when add "nosmt" parameter with CONFIG_HOTPLUG_CPU=N

2019-03-25 Thread Greg KH
On Mon, Mar 25, 2019 at 09:51:23PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > When add "nosmt" parameter, kernel still boots up all logical cpus once > and set CR4.MCE on each CPU. This is to avoid shutting down machine > when a broadacasted MCE is observed CR4.MCE=0b. (Detail

Re: [Fix PATCH] cpu/hotplug: Fix bug report when add "nosmt" parameter with CONFIG_HOTPLUG_CPU=N

2019-03-25 Thread Thomas Gleixner
Tianyu, On Mon, 25 Mar 2019, lantianyu1...@gmail.com wrote: thanks for tracking this down. A few nit picks vs. the subject first: > Subject: [Fix PATCH] cpu/hotplug: Fix bug report when add "nosmt" parameter > with CONFIG_HOTPLUG_CPU=N [PATCH] is sufficient. The extra 'Fix' h

[Fix PATCH] cpu/hotplug: Fix bug report when add "nosmt" parameter with CONFIG_HOTPLUG_CPU=N

2019-03-25 Thread lantianyu1986
From: Lan Tianyu When add "nosmt" parameter, kernel still boots up all logical cpus once and set CR4.MCE on each CPU. This is to avoid shutting down machine when a broadacasted MCE is observed CR4.MCE=0b. (Detail please see comment in the cpu_smt_allowed()). Smt cpus will bring up and bring down