[GIT] Networking

2015-06-30 Thread David Miller
1) mlx4 driver bug fixes (TX queue wakeups, csum complete indications) from Ido Shamay, Eran Ben Elisha, and Or Gerlitz. 2) Missing unlock in error path of PTP support in renesas driver, from Dan Carpenter. 3) Add Vitesse 8641 phy IDs to vitesse PHY driver, from Shaohui Xie. 4) Bnx2x driv

Re: [GIT] Networking

2015-06-25 Thread Joe Perches
On Thu, 2015-06-25 at 12:24 -0400, Paul Gortmaker wrote: > On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds > wrote: > > I'm getting *real* tired of that BUG_ON() shit. [] > > Killing the machine for idiotic things like that is truly offensive, > > and truly horrible horrible code. Why do I keep o

Re: [GIT] Networking

2015-06-25 Thread Paul Gortmaker
On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds wrote: [...] > > I'm getting *real* tired of that BUG_ON() shit. I realize that > infiniband is a niche market, and those "commercial grade" niche > markets are more-than-used-to crap code and horrible hacks, but this > is still the kernel. We don'

Re: [GIT] Networking

2015-06-25 Thread Or Gerlitz
On Thu, Jun 25, 2015 at 2:38 AM, Linus Torvalds wrote: > > On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master > > Just going through the conflicts, I see commit 7193a141eb74 ("IB/mlx4: > Set VF to read from QP cou

RE: [GIT] Networking

2015-06-24 Thread Weiny, Ira
Linus, > > On the *other* side of the same conflict, I find an even more offensive > commit, > namely commit 4cd7c9479aff ("IB/mad: Add support for additional MAD info > to/from drivers") which adds a BUG_ON() for a sanity check, rather than just > returning -EINVAL or something sane like that.

Re: [GIT] Networking

2015-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master Just going through the conflicts, I see commit 7193a141eb74 ("IB/mlx4: Set VF to read from QP counters"), and wonder... Is that code really supposed to fall through

[GIT] Networking

2015-06-12 Thread David Miller
1) Fix uninitialized struct station_info in cfg80211_wireless_stats(), from Johannes Berg. 2) Revert commit attempt to fix ipv6 protocol resubmission, it adds regressions. 3) Endless loops can be created in bridge port lists, fix from Nikolay Aleksandrov. 4) Don't WARN_ON() if sk->sk_f

[GIT] Networking

2015-06-08 Thread David Miller
1) Fix stack allocation in s390 BPF JIT, from Michael Holzheu. 2) Disable LRO on openvswitch paths, from Jiri Benc. 3) UDP early demux doesn't handle multicast group membership properly, fix from Shawn Bohrer. 4) Fix TX queue hang due to incorrect handling of mixed sized fragments and lin

[GIT] Networking

2015-06-01 Thread David Miller
1) Various VTI tunnel (mark handling, PMTU) bug fixes from Alexander Duyck and Steffen Klassert. 2) Revert ethtool PHY query change, it wasn't correct. The PHY address selected by the driver running the PHY to MAC connection decides what PHY address GET ethtool operations return informa

[GIT] Networking

2015-05-27 Thread David Miller
1) Don't use MMIO on certain iwlwifi devices otherwise we get a firmware crash. 2) Don't corrupt the GRO lists of mac80211 contexts by doing sends via timer interrupt, from Johannes Berg. 3) SKB tailroom is miscalculated in AP_VLAN crypto code, from Michal Kazior. 4) Fix fw_status memo

[GIT] Networking

2015-05-22 Thread David Miller
1) Don't leak ipvs->sysctl_tbl, from Tommi Rentala. 2) Fix neighbour table entry leak in rocker driver, from Ying Xue. 3) Do not emit bonding notifications for unregistered interfaces, from Nicolas Dichtel. 4) Set ipv6 flow label properly when in TIME_WAIT state, from Florent Fourcot. 5)

[GIT] Networking

2015-05-12 Thread David Miller
1) Handle max TX power properly wrt. VIFs and the MAC in iwlwifi, from Avri Altman. 2) Use the correct FW API for scan completions in iwlwifi, from Avraham Stern. 3) FW monitor in iwlwifi accidently uses unmapped memory, fix from Liad Kaufman. 4) rhashtable conversion of mac80211 stati

[GIT] Networking

2015-05-01 Thread David Miller
1) Receive packet length needs to be adjust by 2 on RX to accomodate the two padding bytes in altera_tse driver. From Vlastimil Setka. 2) If rx frame is dropped due to out of memory in macb driver, we leave the receive ring descriptors in an undefined state. From Punnaiah Choudary Kall

Re: [GIT] Networking

2015-04-29 Thread Dan Williams
On Wed, 2015-04-29 at 18:55 +0200, D.S. Ljungmark wrote: > > On 29/04/15 18:50, Dan Williams wrote: > > On Wed, 2015-04-29 at 17:17 +0200, D.S. Ljungmark wrote: > >> On 29/04/15 16:51, Denys Vlasenko wrote: > >>> On Wed, Apr 1, 2015 at 9:48 PM, David Miller wrote: > D.S. Ljungmark (1): > >>>

Re: [GIT] Networking

2015-04-29 Thread Denys Vlasenko
On Wed, Apr 29, 2015 at 5:17 PM, D.S. Ljungmark wrote: > > On 29/04/15 16:51, Denys Vlasenko wrote: >> # for f in /proc/sys/net/ipv6/conf/*/hop_limit; do echo -n $f:; cat $f; done >> /proc/sys/net/ipv6/conf/all/hop_limit:64 >> /proc/sys/net/ipv6/conf/default/hop_limit:64 >> /proc/sys/net/ipv6/conf

Re: [GIT] Networking

2015-04-29 Thread D.S. Ljungmark
On 29/04/15 18:50, Dan Williams wrote: > On Wed, 2015-04-29 at 17:17 +0200, D.S. Ljungmark wrote: >> On 29/04/15 16:51, Denys Vlasenko wrote: >>> On Wed, Apr 1, 2015 at 9:48 PM, David Miller wrote: D.S. Ljungmark (1): ipv6: Don't reduce hop limit for an interface >>> >>> https://

Re: [GIT] Networking

2015-04-29 Thread Dan Williams
On Wed, 2015-04-29 at 17:17 +0200, D.S. Ljungmark wrote: > On 29/04/15 16:51, Denys Vlasenko wrote: > > On Wed, Apr 1, 2015 at 9:48 PM, David Miller wrote: > >> D.S. Ljungmark (1): > >> ipv6: Don't reduce hop limit for an interface > > > > https://git.kernel.org/cgit/linux/kernel/git/torval

Re: [GIT] Networking

2015-04-29 Thread D.S. Ljungmark
On 29/04/15 16:51, Denys Vlasenko wrote: > On Wed, Apr 1, 2015 at 9:48 PM, David Miller wrote: >> D.S. Ljungmark (1): >> ipv6: Don't reduce hop limit for an interface > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6fd99094de2b83d1d4c8457f2c83483b2828e75a >

Re: [GIT] Networking

2015-04-29 Thread Denys Vlasenko
On Wed, Apr 1, 2015 at 9:48 PM, David Miller wrote: > D.S. Ljungmark (1): > ipv6: Don't reduce hop limit for an interface https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6fd99094de2b83d1d4c8457f2c83483b2828e75a I was testing this change and apparently it doesn't

[GIT] Networking

2015-04-27 Thread David Miller
1) mlx4 doesn't check fully for supported valid RSS hash function, fix from Amir Vadai. 2) Off by one in ibmveth_change_mtu(), from David Gibson. 3) Prevent altera chip from reporting false error interrupts in some circumstances, from Chee Nouk Phoon. 4) Get rid of that stupid endless loo

[GIT] Networking

2015-04-21 Thread David Miller
Just a few fixes trickling in at this point. 1) If we see an attached socket on an skb in the ipv4 forwarding path, bail. This can happen due to races with FIB rule addition, and deletion, and we should just drop such frames. From Sebastian Pöhn. 2) pppoe receive should only accept pa

[GIT] Networking

2015-04-17 Thread David Miller
1) Fix verifier memory corruption and other bugs in BPF layer, from Alexei Starovoitov. 2) Add a conservative fix for doing BPF properly in the BPF classifier of the packet scheduler on ingress. Also from Alexei. 3) The SKB scrubber should not clear out the packet MARK and security lab

Re: [GIT] Networking

2015-04-14 Thread Stephen Rothwell
Hi Dave, On Wed, 15 Apr 2015 00:16:50 -0400 (EDT) David Miller wrote: > > The first has to do with Stephen Rothwells movement of trace entries > into individual files while meanwhile the wireless folks were adding > new ones or changing the signature of existing ones. Umm, it wasn't me moving s

[GIT] Networking

2015-04-06 Thread David Miller
1) In TCP, don't register an FRTO for cumulatively ACK'd data that was previously SACK'd, from Neal Cardwell. 2) Need to hold RNL mutex in ipv4 multicast code namespace cleanup, from Cong WANG. 3) Similarly we have to hold RNL mutex for fib_rules_unregister(), also from Cong WANG. 4) R

[GIT] Networking

2015-04-01 Thread David Miller
1) Fix use-after-free with mac80211 RX A-MPDU reorder timer, from Johannes Berg. 2) iwlwifi leaks memory every module load/unload cycles, fix from Larry Finger. 3) Need to use for_each_netdev_safe() in rtnl_group_changelink() otherwise we can crash, from WANG Cong. 4) mlx4 driver does

[GIT] Networking

2015-03-23 Thread David Miller
1) Validate iov ranges before feeding them into iov_iter_init(), from Al Viro. 2) We changed copy_from_msghdr_from_user() to zero out the msg_namelen is a NULL pointer is given for the msg_name. Do the same in the compat code too. From Catalin Marinas. 3) Fix partially initialized tup

[GIT] Networking

2015-03-18 Thread David Miller
1) Fix packet header offset calculation in _decode_session6(), from Hajime Tazaki. 2) Fix route leak in error paths of xfrm_lookup(), from Huaibin Wang. 3) Be sure to clear state properly when scans fail in iwlwifi mvm code, from Luciano Coelho. 4) iwlwifi tries to stop scans that aren't

[GIT] Networking

2015-03-09 Thread David Miller
1) nft_compat accidently truncates ethernet protocol to 8-bits, from Arturo Borrero. 2) Memory leak in ip_vs_proc_conn(), from Julian Anastasov. 3) Don't allow the space required for nftables rules to exceed the maximum value representable in the dlen field. From Patrick McHardy. 4) b

[GIT] Networking

2015-03-03 Thread David Miller
1) If an IPVS tunnel is created with a mixed-family destination address, it cannot be removed. Fix from Alexey Andriyanov. 2) Fix module refcount underflow in netfilter's nft_compat, from Pablo Neira Ayuso. 3) Generic statistics infrastructure can reference variables sitting on a relea

[GIT] Networking

2015-02-17 Thread David Miller
1) Missing netlink attribute validation in nft_lookup, from Patrick McHardy. 2) Restrict ipv6 partial checksum handling to UDP, since that's the only case it works for. From Vlad Yasevich. 3) Clear out silly device table sentinal macros used by SSB and BCMA drivers. From Joe Perches.

Re: [GIT] Networking

2015-02-11 Thread Al Viro
On Tue, Feb 10, 2015 at 08:09:29PM -0800, Linus Torvalds wrote: > On Tue, Feb 10, 2015 at 8:02 PM, Al Viro wrote: > > > > Anyway, what userland do you have? > > I have regular Fedora 21, nothing special. > > I'm *assuming* that the thing that triggers this is that I use disk > encryption on this

Re: [GIT] Networking

2015-02-11 Thread David Miller
From: Linus Torvalds Date: Tue, 10 Feb 2015 21:54:35 -0800 > Btw, I like your summaries for the networking pulls, but they don't > tend to mention a lot of the stuff that I assume you pull from others. > For example, there seems to have been a lot of bluetooth stuff this > round and obviously th

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 9:28 PM, David Miller wrote: > > I've put Al's version of the fix into my tree and here is > a new respun pull request: Heh. I already faked that myself - fetched your branch, then locally added my fix on top of it, and merged that instead. So I have "pulled" the networki

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 8:02 PM, Al Viro wrote: > > Anyway, what userland do you have? I have regular Fedora 21, nothing special. I'm *assuming* that the thing that triggers this is that I use disk encryption on this machine, as that's the only even remotely unusual thing that isn't just a bog-s

Re: [GIT] Networking

2015-02-10 Thread Al Viro
On Wed, Feb 11, 2015 at 04:01:13AM +, Al Viro wrote: > I hoped LTP would have them, but it doesn't ;-/ The best I'd been able to > find had been in libkcapi, modulo bunch of > let result=($result + 1) > (in a bash script; ... which I'd been running with sh test.sh ;-/ I really need mor

Re: [GIT] Networking

2015-02-10 Thread Al Viro
On Tue, Feb 10, 2015 at 07:58:22PM -0800, Linus Torvalds wrote: > On Tue, Feb 10, 2015 at 6:01 PM, Linus Torvalds > wrote: > > > > Are there no tests for that crypto interface? > > Oh well. > > With the attached, it at least does boot and work for me. Heh... Looks like your variant is identica

Re: [GIT] Networking

2015-02-10 Thread Al Viro
On Tue, Feb 10, 2015 at 06:01:32PM -0800, Linus Torvalds wrote: > On Tue, Feb 10, 2015 at 5:45 PM, Al Viro wrote: > > > > Could you check if > > > > diff --git a/crypto/af_alg.c b/crypto/af_alg.c > > index eb78fe8..5b11d64 100644 > > --- a/crypto/af_alg.c > > +++ b/crypto/af_alg.c > > @@ -348,7 +3

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 6:01 PM, Linus Torvalds wrote: > > Are there no tests for that crypto interface? Oh well. With the attached, it at least does boot and work for me. Linus crypto/af_alg.c | 2 +- crypto/algif_skcipher.c | 5 ++--- 2 files changed, 3 insert

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 5:45 PM, Al Viro wrote: > > Could you check if > > diff --git a/crypto/af_alg.c b/crypto/af_alg.c > index eb78fe8..5b11d64 100644 > --- a/crypto/af_alg.c > +++ b/crypto/af_alg.c > @@ -348,7 +348,7 @@ int af_alg_make_sg(struct af_alg_sgl *sgl, struct > iov_iter *iter, int l

Re: [GIT] Networking

2015-02-10 Thread Al Viro
On Tue, Feb 10, 2015 at 01:50:16PM -0800, Linus Torvalds wrote: > On Tue, Feb 10, 2015 at 1:26 PM, Linus Torvalds > wrote: > > > > Just to confirm that yes, it's that particular commit 1d10eb2f156f. > > > > I reverted it and things work again. So it's not the miscalculation of > > "used" , but it'

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 1:26 PM, Linus Torvalds wrote: > > Just to confirm that yes, it's that particular commit 1d10eb2f156f. > > I reverted it and things work again. So it's not the miscalculation of > "used" , but it's certainly *something* in that commit. How about this? - npages = (of

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 8:58 AM, Linus Torvalds wrote: > On Tue, Feb 10, 2015 at 8:33 AM, Linus Torvalds > wrote: >> >> Will try your suggestion, > > Nope, that wasn't it. It still hangs in the same place (I forgot to > get rid of the red hat graphical boot screen so I didn't see the oops, > but

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Tue, Feb 10, 2015 at 8:33 AM, Linus Torvalds wrote: > > Will try your suggestion, Nope, that wasn't it. It still hangs in the same place (I forgot to get rid of the red hat graphical boot screen so I didn't see the oops, but ..) Looking more closely at the generated code, and the fact that th

Re: [GIT] Networking

2015-02-10 Thread Linus Torvalds
On Mon, Feb 9, 2015 at 8:52 PM, David Miller wrote: > > I think the handling of the 'used' local variable for function > skcipher_recvmsg() in that commit is suspect. Yeah, skcipher_wait_for_data() waits for it to be non-zero, but it's not reloaded. Will try your suggestion,

Re: [GIT] Networking

2015-02-09 Thread David Miller
From: Linus Torvalds Date: Mon, 9 Feb 2015 20:37:13 -0800 > It's a NULL pointer derefernce (at offset 0x18) where the callchain > looks like this: > > RIP: skcipher_recvmsg+0x360/0x410 > Call Trace: > sock_read_iter+0xd0/0x120 > new_sync_read+0x79/0xb0 > __vfs_read+0x13/0x50 >

Re: [GIT] Networking

2015-02-09 Thread Linus Torvalds
On Mon, Feb 9, 2015 at 7:16 PM, David Miller wrote: > > 1) More iov_iter conversion work from Al Viro. > ... > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next I pulled, but had to unpull. This doesn't work for me AT ALL. I get an oops

[GIT] Networking

2015-02-05 Thread David Miller
1) Stretch ACKs can kill performance with Reno and CUBIC congestion control, largely due to LRO and GRO. Fix from Neal Cardwell. 2) Fix userland breakage because we accidently emit zero length netlink messages from the bridging code. From Roopa Prabhu. 3) Carry handling in generic csum_t

[GIT] Networking

2015-01-27 Thread David Miller
1) Don't OOPS on socket AIO, from Christoph Hellwig. 2) Scheduled scans should be aborted upon RFKILL, from Emmanuel Grumbach. 3) Fix sleep in atomic context in kvaser_usb, from Ahmed S. Darwish. 4) Fix RCU locking across copy_to_user() in bpf code, from Alexei Starovoitov. 5) Lots of crash

[GIT] Networking

2015-01-19 Thread David Miller
1) Socket addresses returned in the error queue need to be fully initialized before being passed on to userspace, fix from Willem de Bruijn. 2) Interrupt handling fixes to davinci_emac driver from Tony Lindgren. 3) Fix races between receive packet steering and cpu hotplug, from Eric

[GIT] Networking

2015-01-14 Thread David Miller
1) Don't use uninitialized data in IPVS, from Dan Carpenter. 2) conntrack race fixes from Pablo Neira Ayuso. 3) Fix TX hangs with i40e, from Jesse Brandeburg. 4) Fix budget return from poll calls in dnet and alx, from Eric Dumazet. 5) Fix bugus "if (unlikely(x) < 0)" test in AF_PACKET, from Ch

[GIT] Networking

2015-01-06 Thread David Miller
Just a pile of random fixes, including: 1) Do not apply TSO limits to non-TSO packets, fix from Herbert Xu. 2) MDI{,X} eeprom check in e100 driver is reversed, from John W. Linville. 3) Missing error return assignments in several ethernet drivers, from Julia Lawall. 4) Altera TSE devi

[GIT] Networking

2014-12-29 Thread David Miller
1) Fix double SKB free in bluetooth 6lowpan layer, from Jukka Rissanen. 2) Fix receive checksum handling in enic driver, from Govindarajulu Varadarajan. 3) Fix NAPI poll list corruption in virtio_net and caif_virtio, from Herbert Xu. Also, add code to detect drivers that have this m

[GIT] Networking

2014-12-18 Thread David Miller
1) Fix NBMA tunnel mac header handling in GRE, from Timo Teräs. 2) Fix a NAPI race in the fec driver, from Nimrod Andy. 3) The new IFF_VNET_LE bit is outside the size of the flags member it is stored in (which is 16-bits), store the state locally in the drivers. From Michael S. Tsirkin.

[GIT] Networking

2014-12-12 Thread David Miller
Small follow-up to the main merge pull from the other day: 1) Alexander Duyck's DMA memory barrier patch set. 2) cxgb4 driver fixes from Karen Xie. 3) Add missing export of fixed_phy_register() to modules, from Mark Salter. 4) DSA bug fixes from Florian Fainelli. Please pull, thanks a lot!

[GIT] Networking

2014-12-02 Thread David Miller
1) Fill in ethtool link parameters for all link types in cxgb4, from Hariprasad Shenai. 2) Fix probe regressions in stmmac driver, from Huacai Chen. 3) Network namespace leaks on errirs in rtnetlink, from Nicolas Dichtel. 4) Remove erroneous BUG check which can actually trigger legitim

[GIT] Networking

2014-11-26 Thread David Miller
Several small fixes here: 1) Don't crash in tg3 driver when the number of tx queues has been configured to be different from the number of rx queues. From Thadeu Lima de Souza Cascardo. 2) VLAN filter not disabled properly in promisc mode in ixgbe driver, from Vlad Yasevich. 3) Fix OOP

[GIT] Networking

2014-11-21 Thread David Miller
1) Fix BUG when decrypting empty packets in mac80211, from Ronald Wahl. 2) nf_nat_range is not fully initialized and this is copied back to userspace, from Daniel Borkmann. 3) Fix read past end of b uffer in netfilter ipset, also from Dan Carpenter. 4) Signed integer overflow in ipv4 addr

[GIT] Networking

2014-11-13 Thread David Miller
1) sunhme driver lacks DMA mapping error checks, based upon a report by Meelis Roos. 2) Fix memory leak in mvpp2 driver, from Sudip Mukherjee. 3) DMA memory allocation sizes are wrong in systemport ethernet driver, fix from Florian Fainelli. 4) Fix use after free in mac80211 defragmentati

[GIT] Networking

2014-10-31 Thread David Miller
A bit has accumulated, but it's been a week or so since my last batch of post-merge-window fixes, so... 1) Missing module license in netfilter reject module, from Pablo. Lots of people ran into this. 2) Off by one in mac80211 baserate calculation, from Karl Beldan. 3) Fix incorrect return v

Re: [GIT] Networking

2014-10-20 Thread Pablo Neira Ayuso
On Sun, Oct 19, 2014 at 09:03:14PM -0400, David Miller wrote: > From: Linus Torvalds > Date: Sun, 19 Oct 2014 17:32:15 -0700 > > > Looks like the module license issue was just overlooked when moving > > the code out in commit c8d7b98bec43 ("netfilter: move nf_send_resetX() > > code to nf_reject_i

Re: [GIT] Networking

2014-10-19 Thread David Miller
From: Linus Torvalds Date: Sun, 19 Oct 2014 17:32:15 -0700 > Looks like the module license issue was just overlooked when moving > the code out in commit c8d7b98bec43 ("netfilter: move nf_send_resetX() > code to nf_reject_ipvX modules"). I think Pablo has a patch pending to address this, and ind

Re: [GIT] Networking

2014-10-19 Thread Linus Torvalds
On Sun, Oct 19, 2014 at 10:23 AM, David Miller wrote: > > A quick batch of bug fixes: Ho humm.. Here's another networking issue with the current kernel: nf_reject_ipv6: module license 'unspecified' taints kernel. Disabling lock debugging due to kernel taint nf_reject_ipv6: Unknown symbol i

[GIT] Networking

2014-10-19 Thread David Miller
A quick batch of bug fixes: 1) Fix build with IPV6 disabled, from Eric Dumazet. 2) Several more cases of caching SKB data pointers across calls to pskb_may_pull(), thus referencing potentially free'd memory. From Li RongQing. 3) DSA phy code tests operation presence improperly, instead

Re: [GIT] Networking

2014-10-18 Thread David Miller
From: Markus Trippelsdorf Date: Sun, 19 Oct 2014 04:15:54 +0200 > On 2014.10.18 at 00:18 -0400, David Miller wrote: >> >> Please pull, thanks a lot. > > In file included from net/core/sock.c:140:0: > include/net/tcp.h: In function ‘tcp_v6_iif’: > include/net/tcp.h:738:32: error: ‘union ’ has no

Re: [GIT] Networking

2014-10-18 Thread Markus Trippelsdorf
On 2014.10.18 at 00:18 -0400, David Miller wrote: > > Please pull, thanks a lot. In file included from net/core/sock.c:140:0: include/net/tcp.h: In function ‘tcp_v6_iif’: include/net/tcp.h:738:32: error: ‘union ’ has no member named ‘h6’ return TCP_SKB_CB(skb)->header.h6.iif;

[GIT] Networking

2014-10-17 Thread David Miller
1) Include fixes for netrom and dsa (Fabian Frederick and Florian Fainelli) 2) Fix FIXED_PHY support in stmmac, from Giuseppe CAVALLARO. 3) Several SKB use after free fixes (vxlan, openvswitch, vxlan, ip_tunnel, fou), from Li ROngQing. 4) fec driver PTP support fixes from Luwei Zhou and

[GIT] Networking

2014-10-11 Thread David Miller
This set fixes a bunch of fallout from the changes that went in during this merge window, particularly: 1) Fix fsl_pq_mdio (Claudiu Manoil) and fm10k (Pranith Kumar) build failures. 2) Several networking drivers do atomic_set() on page counts where that's not exactly legal. From Eric Duma

[GIT] Networking

2014-10-01 Thread David Miller
1) Don't halt the firmware in r8152 driver, from Hayes Wang. 2) Handle full sized 802.1ad frames in bnx2 and tg3 drivers properly, from Vlad Yasevich. 3) Don't sleep while holding tx_clean_lock in netxen driver, fix from Manish Chopra. 4) Certain kinds of ipv6 routes can end up endlessly

[GIT] Networking

2014-09-24 Thread David Miller
Here is a quick pull request primarily meant to address the deconfig fallout from changing SCSI_NETLINK from being used via 'select' to being used via 'depends'. I applied a set of 5 patches written by Michal Marek, and then I carefully audited all of the remaining config files, basically: 1) I

[GIT] Networking

2014-09-22 Thread David Miller
1) If the user gives us a msg_namelen of 0, don't try to interpret anything pointed to by msg_name. From Ani Sinha. 2) Fix some bnx2i/bnx2fc randconfig compilation errors. The gist of the issue is that we firstly have drivers that span both SCSI and networking. And at the top of that

Re: Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-11 Thread Andres Freund
On 2014-09-10 13:32:00 +0400, Alexander Y. Fomichev wrote: > > I've reproduced the problem on another machine where it's perfectly > > reproducible (except being about mv-bond0). > > did you mean this is a macvlan which has bond as a real device? Only on the other machine where I tried it. It's n

Re: Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-10 Thread Alexander Y. Fomichev
On Wed, Sep 10, 2014 at 3:55 AM, Andres Freund wrote: > On 2014-09-10 01:48:06 +0200, Andres Freund wrote: >> On 2014-09-09 15:43:55 -0700, Cong Wang wrote: >> > On Mon, Sep 8, 2014 at 2:25 PM, Andres Freund wrote: >> > > Hi, >> > > >> > > (don't have netdev archived, thus answering here, sorry)

Re: Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-09 Thread Alexander Y. Fomichev
On Wed, Sep 10, 2014 at 3:55 AM, Andres Freund wrote: > On 2014-09-10 01:48:06 +0200, Andres Freund wrote: >> On 2014-09-09 15:43:55 -0700, Cong Wang wrote: >> > On Mon, Sep 8, 2014 at 2:25 PM, Andres Freund wrote: >> > > Hi, >> > > >> > > (don't have netdev archived, thus answering here, sorry)

Re: Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-09 Thread Andres Freund
On 2014-09-10 01:48:06 +0200, Andres Freund wrote: > On 2014-09-09 15:43:55 -0700, Cong Wang wrote: > > On Mon, Sep 8, 2014 at 2:25 PM, Andres Freund wrote: > > > Hi, > > > > > > (don't have netdev archived, thus answering here, sorry) > > > > > > On 2014-09-07 16:41:09 -0700, David Miller wrote:

Re: Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-09 Thread Andres Freund
On 2014-09-09 15:43:55 -0700, Cong Wang wrote: > On Mon, Sep 8, 2014 at 2:25 PM, Andres Freund wrote: > > Hi, > > > > (don't have netdev archived, thus answering here, sorry) > > > > On 2014-09-07 16:41:09 -0700, David Miller wrote: > >> Alexander Y. Fomichev (1): > >> net: prevent of emergi

Re: Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-09 Thread Cong Wang
On Mon, Sep 8, 2014 at 2:25 PM, Andres Freund wrote: > Hi, > > (don't have netdev archived, thus answering here, sorry) > > On 2014-09-07 16:41:09 -0700, David Miller wrote: >> Alexander Y. Fomichev (1): >> net: prevent of emerging cross-namespace symlinks > Since you are quoting this chang

Macvlan WARNiNGS about duplicate sysfs filenames (Was [GIT] Networking)

2014-09-09 Thread Andres Freund
Hi, (don't have netdev archived, thus answering here, sorry) On 2014-09-07 16:41:09 -0700, David Miller wrote: > Alexander Y. Fomichev (1): > net: prevent of emerging cross-namespace symlinks I'm seeing WARNINGs like: [ 1005.269134] [ cut here ] [ 1005.269148] WARNI

[GIT] Networking

2014-09-07 Thread David Miller
1) Fix skb leak in mac802154, from Martin Townsend. 2) Use select not depends on NF_NAT for NFT_NAT, from Pablo Neira Ayuso. 3) Fix union initializer bogosity in vxlan, from Gerhard Stenzel. 4) Fix RX checksum configuration in stmmac driver, from Giuseppe CAVALLARO. 5) Fix TSO with non-acce

[GIT] Networking

2014-08-14 Thread David Miller
I'm sending this out, in particular, to get the iwlwifi fix propagated: 1) Fix build due to missing include in i40e driver, from Lucas Tanure. 2) Memory leak in openvswitch port allocation, from Chirstoph Jaeger. 3) Check DMA mapping errors in myri10ge, from Stanislaw Gruszka. 4) Fix various d

[GIT] Networking

2014-08-11 Thread David Miller
Several networking final fixes and tidies for the merge window: 1) Changes during the merge window unintentionally took away the ability to build bluetooth modular, fix from Geert Uytterhoeven. 2) Several phy_node reference count bug fixes from Uwe Kleine-König. 3) Fix ucc_geth build failure

[GIT] Networking

2014-08-06 Thread David Miller
This fixes the most immediate fallout from yesterday's networking merge. 1) sock_tx_timestamp() must not clear the passed in tx_flags, but rather add to them. Fix from Eric Dumazet. 2) The hyperv driver sendbuf region increase needs to be decreased slightly to handle older backends. From

Re: [GIT] Networking

2014-07-29 Thread David Miller
From: Stephen Rothwell Date: Wed, 30 Jul 2014 10:36:28 +1000 > On Tue, 29 Jul 2014 16:55:32 -0700 (PDT) David Miller > wrote: >> >> Oliver Neukum (2): >> cdc_subset: deal with a device that needs reset for timeout > > This commit causes a build failure on arm (at least). See my > linux-

Re: [GIT] Networking

2014-07-29 Thread Stephen Rothwell
Hi Dave, On Tue, 29 Jul 2014 16:55:32 -0700 (PDT) David Miller wrote: > > Oliver Neukum (2): > cdc_subset: deal with a device that needs reset for timeout This commit causes a build failure on arm (at least). See my linux-next email about this. -- Cheers, Stephen Rothwell

[GIT] Networking

2014-07-29 Thread David Miller
1) Make fragmentation IDs less predictable, from Eric Dumazet. 2) TSO tunneling can crash in bnx2x driver, fix from Dmitry Kravkov. 3) Don't allow NULL msg->msg_name just because msg->msg_namelen is non-zero, from Andrey Ryabinin. 4) ndm->ndm_type set using wrong macros, from Jun Zhao. 5) c

[GIT] Networking

2014-07-21 Thread David Miller
1) Null termination fix in dns_resolver got the pointer dereferncing wrong, fix from Ben Hutchings. 2) ip_options_compile() has a benign but real buffer overflow when parsing options. From Eric Dumazet. 3) Table updates can crash in netfilter's nftables if none of the state flags indic

Re: [GIT] Networking

2014-07-16 Thread Linus Torvalds
On Wed, Jul 16, 2014 at 4:18 PM, Kalle Valo wrote: > > Just out of curiosity, what is the best way to send a proposal how to > fix a merge conflict? For example, if I send a pull request to John > which I know will issue a conflict it would be nice to include > instructions (or some sort of patch)

Re: [GIT] Networking

2014-07-16 Thread Kalle Valo
"John W. Linville" writes: > On Tue, Jul 15, 2014 at 11:46:14AM -0700, David Miller wrote: >> From: Linus Torvalds >> Date: Tue, 15 Jul 2014 08:52:33 -0700 >> >> > And if David actually asks for these, my apologies.. >> >> I didn't ask for these :-) > > Just trying to be helpful, for those tim

Re: [GIT] Networking

2014-07-15 Thread David Miller
From: Linus Torvalds Date: Tue, 15 Jul 2014 19:24:24 -0700 > I just thought I'd point out this thing when I noticed. It's not > new, and has been going on, I just reacted to it now Ok, I'll discuss with John the best thing for us moving forward. Thanks. -- To unsubscribe from this list: send th

Re: [GIT] Networking

2014-07-15 Thread David Miller
From: Linus Torvalds Date: Tue, 15 Jul 2014 08:52:33 -0700 > Ugh, I wanted to point this out, since looking at the history it's > really ugly with silly extraneous merges for no good reason: Linus is there anything you want me to do to my tree before you'll pull this? Just wondering... -- To un

Re: [GIT] Networking

2014-07-15 Thread John W. Linville
On Tue, Jul 15, 2014 at 11:46:14AM -0700, David Miller wrote: > From: Linus Torvalds > Date: Tue, 15 Jul 2014 08:52:33 -0700 > > > And if David actually asks for these, my apologies.. > > I didn't ask for these :-) Just trying to be helpful, for those times when there are non-trivial merge conf

Re: [GIT] Networking

2014-07-15 Thread David Miller
From: Linus Torvalds Date: Tue, 15 Jul 2014 08:52:33 -0700 > And if David actually asks for these, my apologies.. I didn't ask for these :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [GIT] Networking

2014-07-15 Thread Linus Torvalds
Ugh, I wanted to point this out, since looking at the history it's really ugly with silly extraneous merges for no good reason: John, take a look at this: On Tue, Jul 15, 2014 at 12:28 AM, David Miller wrote: > > John W. Linville (7): > Merge git://git.kernel.org/.../jberg/mac80211 >

[GIT] Networking

2014-07-15 Thread David Miller
The latest pile of networking cures: 1) Bluetooth pairing fixes from Johan Hedberg. 2) ieee80211_send_auth() doesn't allocate enough tail room for the SKB, from Max Stepanov. 3) New iwlwifi chip IDs, from Oren Givon. 4) bnx2x driver reads wrong PCI config space MSI register, from Yijing Wan

[GIT] Networking

2014-06-25 Thread David Miller
1) Fix crash in ipvs tot_stats estimator, from Julian Anastasov. 2) Fix OOPS in nf_nat on netns removal, from Florian Westphal. 3) Really really really fix locking issues in slip and slcan tty write wakeups, from Tyler Hall. 4) Fix checksum offloading in fec driver, from Fugang Duan. 5) Off

Re: [GIT] Networking

2014-06-24 Thread Tom Herbert
I believe in the no scatter-gather case of skb_segment is not set correctly. Will post a patch momentarily. On Tue, Jun 24, 2014 at 8:05 PM, Tom Herbert wrote: >> tcp_gso_segment() makes sure that the headers are reachable in the linear >> area with the pskb_may_pull(skb, sizeof(*th)) call, and

Re: [GIT] Networking

2014-06-24 Thread Tom Herbert
> tcp_gso_segment() makes sure that the headers are reachable in the linear > area with the pskb_may_pull(skb, sizeof(*th)) call, and gso_make_checksum() > is only working with the area up to SKB_GSO_CB()->csum_start which should > be within this area for sure. > Seems likely that csum_start is not

Re: [GIT] Networking

2014-06-24 Thread David Miller
From: Linus Torvalds Date: Tue, 24 Jun 2014 17:04:41 -0700 > Ping? Tom please help look at this. > This is all related to the new checksumming code by Tom Herbert. > > The oops seems to be "gso_make_checksum()" taking a checksum of > something that isn't mapped. Either the math for 'plen' is s

Re: [GIT] Networking

2014-06-24 Thread Linus Torvalds
Ping? This is all related to the new checksumming code by Tom Herbert. The oops seems to be "gso_make_checksum()" taking a checksum of something that isn't mapped. Either the math for 'plen' is simply wrong (maybe "csum_start" is not properly initialized), or maybe there is a missing skb_pull() o

Re: [GIT] Networking

2014-06-23 Thread Dave Jones
On Mon, Jun 16, 2014 at 07:42:54PM -0400, Dave Jones wrote: > On Mon, Jun 16, 2014 at 07:04:50PM -0400, Dave Jones wrote: > > On Sun, Jun 15, 2014 at 07:33:12PM -0700, David Miller wrote: > > > > > 1) Fix checksumming regressions, from Tom Herbert. > > > > Something still not right fo

Re: [GIT] Networking

2014-06-16 Thread Dave Jones
On Mon, Jun 16, 2014 at 07:04:50PM -0400, Dave Jones wrote: > On Sun, Jun 15, 2014 at 07:33:12PM -0700, David Miller wrote: > > > 1) Fix checksumming regressions, from Tom Herbert. > > Something still not right for me here. > After about 5 minutes, I get an oops and then instant reboot/loc

<    1   2   3   4   5   6   7   >