Re: [GIT] kbuild changes for v3.11-rc1

2013-07-12 Thread Robert Richter
On 11.07.13 10:16:18, Linus Torvalds wrote: > On Thu, Jul 11, 2013 at 6:54 AM, Michal Marek wrote: > > > > Yeah. It also reveals another bug that we rewrite the kernel.release > > file each time. The odd thing I have in a specific configuration is that depmod is missing the kernelrelease when I

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-12 Thread Robert Richter
On 11.07.13 10:16:18, Linus Torvalds wrote: On Thu, Jul 11, 2013 at 6:54 AM, Michal Marek mma...@suse.cz wrote: Yeah. It also reveals another bug that we rewrite the kernel.release file each time. The odd thing I have in a specific configuration is that depmod is missing the kernelrelease

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-11 Thread Linus Torvalds
On Thu, Jul 11, 2013 at 6:54 AM, Michal Marek wrote: > > Yeah. It also reveals another bug that we rewrite the kernel.release > file each time. This patch should fix it, but please do not apply it > yet: So I think not rewriting the file is a good thing, but in this case it would actually have

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-11 Thread Michal Marek
On Wed, Jul 10, 2013 at 07:11:53PM -0700, Linus Torvalds wrote: > You need to start being more careful. And I would seriously suggest > you start doing some explicit testing for this. You can do things like > "find . -user root", and if that shows a single file in the kernel > tree after a "make

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-11 Thread Michal Marek
On Wed, Jul 10, 2013 at 07:11:53PM -0700, Linus Torvalds wrote: You need to start being more careful. And I would seriously suggest you start doing some explicit testing for this. You can do things like find . -user root, and if that shows a single file in the kernel tree after a make

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-11 Thread Linus Torvalds
On Thu, Jul 11, 2013 at 6:54 AM, Michal Marek mma...@suse.cz wrote: Yeah. It also reveals another bug that we rewrite the kernel.release file each time. This patch should fix it, but please do not apply it yet: So I think not rewriting the file is a good thing, but in this case it would

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-10 Thread Greg KH
On Wed, Jul 10, 2013 at 07:11:53PM -0700, Linus Torvalds wrote: > Commit d2aae8477cd00325bb7c7c7e95be488088900c48 is broken. It causes > root to re-write "include/config/kernel.release". > > There is no excuse for this. That commit is shit. There's no way in > hell that "make modules_install"

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-10 Thread Linus Torvalds
On Wed, Jul 10, 2013 at 6:37 AM, Michal Marek wrote: > > please pull the kbuild bits for v3.11-rc1: THIS IS SOME HORRIBLY BROKEN CRAP. "make install" and "make modules_install" ABSOLUTELY MUST NOT MODIFY THE SOURCE TREE. Dammit, this has happened before, and it was broken then, and it is

[GIT] kbuild changes for v3.11-rc1

2013-07-10 Thread Michal Marek
Hi Linus, please pull the kbuild bits for v3.11-rc1: - fix for make headers_install argv explosion with too long path - scripts/setlocalversion does not call git update-index needlessly - fix for the src.rpm produced by make rpm-pkg. The new make image_name can be useful also for other

[GIT] kbuild changes for v3.11-rc1

2013-07-10 Thread Michal Marek
Hi Linus, please pull the kbuild bits for v3.11-rc1: - fix for make headers_install argv explosion with too long path - scripts/setlocalversion does not call git update-index needlessly - fix for the src.rpm produced by make rpm-pkg. The new make image_name can be useful also for other

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-10 Thread Linus Torvalds
On Wed, Jul 10, 2013 at 6:37 AM, Michal Marek mma...@suse.cz wrote: please pull the kbuild bits for v3.11-rc1: THIS IS SOME HORRIBLY BROKEN CRAP. make install and make modules_install ABSOLUTELY MUST NOT MODIFY THE SOURCE TREE. Dammit, this has happened before, and it was broken then, and it

Re: [GIT] kbuild changes for v3.11-rc1

2013-07-10 Thread Greg KH
On Wed, Jul 10, 2013 at 07:11:53PM -0700, Linus Torvalds wrote: Commit d2aae8477cd00325bb7c7c7e95be488088900c48 is broken. It causes root to re-write include/config/kernel.release. There is no excuse for this. That commit is shit. There's no way in hell that make modules_install should ever