Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-05-03 Thread Mark Brown
On Thu, May 02, 2013 at 01:53:03PM -0700, David Brown wrote: > Mark Brown writes: > > Well, this device should have a bunch of function drivers hanging off it > > shouldn't it? That's pretty much the definition of a MFD. > Perhaps it's better to think of it as the library that other mfd devices

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-05-02 Thread David Brown
Mark Brown writes: > On Mon, Apr 29, 2013 at 11:16:28PM +0200, Arnd Bergmann wrote: > >> Well, the only reason I see against putting it into drivers/mfd is that >> this place is becoming a dumping ground for stuff that doesn't have a >> real home anywhere else. On the other hand, this one would f

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-05-01 Thread Mark Brown
On Mon, Apr 29, 2013 at 11:16:28PM +0200, Arnd Bergmann wrote: > Well, the only reason I see against putting it into drivers/mfd is that > this place is becoming a dumping ground for stuff that doesn't have a > real home anywhere else. On the other hand, this one would fit better > than a lot of d

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-05-01 Thread Mark Brown
On Mon, Apr 29, 2013 at 10:50:47PM +0200, Arnd Bergmann wrote: > On Monday 29 April 2013, Linus Torvalds wrote: > > - I'm not seeing what commonalities this thing can have with anything > > else. Did anybody look at the code? There's nothing generic there. > It's a simple bus that has addressabl

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Arnd Bergmann
On Monday 29 April 2013, Linus Torvalds wrote: > Or maybe "drivers/platform/something-or-other" if there are possible > other things that get shared together with this thing? I don't care > that deeply, as long as it's just off in a little corner of the > universe, rather than smack-dab in the midd

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Arnd Bergmann
On Monday 29 April 2013, Linus Torvalds wrote: > On Mon, Apr 29, 2013 at 1:50 PM, Arnd Bergmann wrote: > > > > Fair enough. Of course the distinction here is not based on what it > > does, but how it gets used. > > Even technically, a "bus" generally has a topology. It has addresses, > and it has

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 2:08 PM, David Brown wrote: > > So, what is this saner place? The hardware is theoretically shared > between ARM and Hexagon, but I don't know the hexagon plans to support > it, I've added them to the CC. So I actually wouldn't have complained about it in drivers/misc/ssb

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Arnd Bergmann
On Monday 29 April 2013, David Brown wrote: > I'm not sure why this shouldn't be in the drivers/mfd directory > alongside the various pm*.c drivers that use it. It isn't going to be > used for anything else. > > Given the bikeshedding that happened when Ken pushed the driver out last > time, thou

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 1:50 PM, Arnd Bergmann wrote: > > Fair enough. Of course the distinction here is not based on what it > does, but how it gets used. Even technically, a "bus" generally has a topology. It has addresses, and it has a protocol. i2c is a bus. PCI is a bus. And something like

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread David Brown
Linus Torvalds writes: > There are other things wrong with that whole SSBI driver crap that you > seem to be ignoring: > > - it's not a bus, it's just a driver. Just because some people call > it "serial bus" doesn't make it magically about a "bus". I can call an > ethernet driver an "ethernet b

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Arnd Bergmann
On Monday 29 April 2013, Linus Torvalds wrote: > On Mon, Apr 29, 2013 at 12:54 PM, Arnd Bergmann wrote: > There are other things wrong with that whole SSBI driver crap that you > seem to be ignoring: > > - it's not a bus, it's just a driver. Just because some people call > it "serial bus" doesn

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Nicolas Pitre
On Mon, 29 Apr 2013, Linus Torvalds wrote: > The "explanations" for why it should be in drivers/ is this mindless drivel: > > On Tue, Feb 22 2011, Daniel Walker wrote: > > On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote: > > > >> What is the problem leaving it under arch/arm/mach-msm? > > > >

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 12:54 PM, Arnd Bergmann wrote: > > I think there are good reasons for most of the drivers we have moved out > of arch/arm to stay out of there: we have added subdirectories for a lot > of drivers that are alike: Maybe. But this one is NOT such a case, and I saw Nico making

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Arnd Bergmann
On Monday 29 April 2013, Linus Torvalds wrote: > And I'm calling the ARM people out on this idiocy. Arnd and Nico - > stop encouraging this kind of crap. Move things to drivers only once > there is actual reason for it. If it's some proprierary single-SoC > thing, it can damn well stay away from ot

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 11:55 AM, Linus Torvalds wrote: > > But right now it smells like somethign that should not be at > the top level. Btw, I pulled and pushed out, because I don't think this is the end of the world, but it's part of my constant fight against people who think that *their* subs

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 11:55 AM, Linus Torvalds wrote: > On Mon, Apr 29, 2013 at 11:38 AM, Greg KH wrote: >> >> It's a "bus" type, that has individual drivers connecting to it. > > No it isn't, and no it doesn't. Ok, searching more, I find this discussion on lkml: Dima Zavin reasonably wrote

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 11:38 AM, Greg KH wrote: > > It's a "bus" type, that has individual drivers connecting to it. No it isn't, and no it doesn't. It's a "bus" exactly the same way the PS2 driver is a "bus", and it has individual devices connecting to it exactly the same way we have keyboards

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Greg KH
On Mon, Apr 29, 2013 at 11:28:40AM -0700, Linus Torvalds wrote: > On Mon, Apr 29, 2013 at 9:21 AM, Greg KH wrote: > > > > Here's the big char / misc driver update for 3.10-rc1 > > Ugh. What the f*ck is up with stuff like this: > > > drivers/ssbi/Kconfig | 16 + > >

Re: [GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 9:21 AM, Greg KH wrote: > > Here's the big char / misc driver update for 3.10-rc1 Ugh. What the f*ck is up with stuff like this: > drivers/ssbi/Kconfig | 16 + > drivers/ssbi/Makefile | 1 + > drivers/ssbi/ssb

[GIT PATCH] char/misc patches for 3.10-rc1

2013-04-29 Thread Greg KH
The following changes since commit 41ef2d5678d83af030125550329b6ae8b74618fa: Linux 3.9-rc7 (2013-04-14 17:45:16 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/ tags/char-misc-3.10-rc1 for you to fetch changes up to 0e272639