Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-28 Thread Herbert Xu
On Thu, Sep 28, 2017 at 12:08:36PM +1000, James Morris wrote: > On Wed, 27 Sep 2017, Eric Biggers wrote: > > > On Thu, Sep 28, 2017 at 09:14:58AM +1000, James Morris wrote: > > > On Wed, 27 Sep 2017, David Howells wrote: > > > > > > > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
On Wed, 27 Sep 2017, Eric Biggers wrote: > On Thu, Sep 28, 2017 at 09:14:58AM +1000, James Morris wrote: > > On Wed, 27 Sep 2017, David Howells wrote: > > > > > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. > > > > > > > I'm concerned about the lack of crypto review mentioned

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread Eric Biggers
On Thu, Sep 28, 2017 at 09:14:58AM +1000, James Morris wrote: > On Wed, 27 Sep 2017, David Howells wrote: > > > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. > > > > I'm concerned about the lack of crypto review mentioned by Jason -- I > wonder if we can get this rewrite any m

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
On Wed, 27 Sep 2017, David Howells wrote: > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. > I'm concerned about the lack of crypto review mentioned by Jason -- I wonder if we can get this rewrite any more review from crypto folk. Also, are there any tests for this code? If n

[GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread David Howells
Hi James, Can you pull these and pass them on to Linus. There are two sets of patches here: (1) A bunch of core keyrings bug fixes from Eric Biggers. (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. There are more patches to come from Eric, but I haven't reviewed at them yet, s