Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-09 Thread Greg KH
On Wed, Nov 08, 2017 at 05:07:46PM -0600, Rob Herring wrote: > On Thu, Nov 2, 2017 at 10:16 AM, Greg KH wrote: > > [resend without the full diffstat as lkml and some email systems didn't > > like to see emails with 12k lines...] > > > > Hi, > > > > As discussed at the Maintainers Summit last week

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-08 Thread Rob Herring
On Thu, Nov 2, 2017 at 10:16 AM, Greg KH wrote: > [resend without the full diffstat as lkml and some email systems didn't > like to see emails with 12k lines...] > > Hi, > > As discussed at the Maintainers Summit last week, here is a pull request > that adds some SPDX license identifiers to three

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Linus Torvalds
On Thu, Nov 2, 2017 at 11:21 AM, Thomas Gleixner wrote: > > The wreckage is with the *.lds.S ones which are used to generate .lds with > some gcc preprocessor magic. And then ld falls flat on its nose with the // > comment. The cpp phase should just get rid of them. But we actually explicitly us

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Thomas Gleixner
On Thu, 2 Nov 2017, Linus Torvalds wrote: > On Thu, Nov 2, 2017 at 11:02 AM, Greg KH wrote: > > > > Oh I wish that were the case :( > > > > Thomas and I fought with the vdso build logic[1], and some other > > arch-specific stuff for a good day trying to track down all of the > > individual .h fil

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Linus Torvalds
On Thu, Nov 2, 2017 at 11:02 AM, Greg KH wrote: > > Oh I wish that were the case :( > > Thomas and I fought with the vdso build logic[1], and some other > arch-specific stuff for a good day trying to track down all of the > individual .h files that were getting pulled in by gcc to spit out a .S >

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Greg KH
On Thu, Nov 02, 2017 at 10:52:23AM -0700, Linus Torvalds wrote: > On Thu, Nov 2, 2017 at 10:45 AM, Greg KH wrote: > > > > For .h files, we had to use /* */ > > That should only be true for the uapi files (because they may > encounter old compilers), not for *.h files in general, I feel. Oh I wis

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Linus Torvalds
On Thu, Nov 2, 2017 at 10:45 AM, Greg KH wrote: > > For .h files, we had to use /* */ That should only be true for the uapi files (because they may encounter old compilers), not for *.h files in general, I feel. Linus

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Greg KH
On Thu, Nov 02, 2017 at 10:32:17AM -0700, Linus Torvalds wrote: > On Thu, Nov 2, 2017 at 10:25 AM, Linus Torvalds > wrote: > > > > So to me, the "just put it as the first syntactically possible line, > > and just always use the same comment format" is simply to avoid > > unnecessary arguments/conf

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Linus Torvalds
On Thu, Nov 2, 2017 at 10:25 AM, Linus Torvalds wrote: > > So to me, the "just put it as the first syntactically possible line, > and just always use the same comment format" is simply to avoid > unnecessary arguments/conflicts about which of any number of ways you > *could* do it. Side note: I'm

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Linus Torvalds
On Thu, Nov 2, 2017 at 10:09 AM, Masahiro Yamada wrote: > > I am happy to follow the preferred style if any > for my future patches. I just want to be sure. So in general, the _hope_ is that we can just end up replacing existing boilerplate comments with that single line SPDX comment (using "//"

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Greg KH
On Fri, Nov 03, 2017 at 02:09:02AM +0900, Masahiro Yamada wrote: > Hi. > > > 2017-11-03 0:16 GMT+09:00 Greg KH : > > [resend without the full diffstat as lkml and some email systems didn't > > like to see emails with 12k lines...] > > > > Hi, > > > > As discussed at the Maintainers Summit last w

Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Masahiro Yamada
Hi. 2017-11-03 0:16 GMT+09:00 Greg KH : > [resend without the full diffstat as lkml and some email systems didn't > like to see emails with 12k lines...] > > Hi, > > As discussed at the Maintainers Summit last week, here is a pull request > that adds some SPDX license identifiers to three differ

[GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

2017-11-02 Thread Greg KH
[resend without the full diffstat as lkml and some email systems didn't like to see emails with 12k lines...] Hi, As discussed at the Maintainers Summit last week, here is a pull request that adds some SPDX license identifiers to three different classes of files: - files with no license