Re: [GIT PULL] NTB bug fixes for v5.11

2021-01-04 Thread Jon Mason
On Mon, Jan 4, 2021 at 3:31 AM Dan Carpenter wrote: > > On Sun, Dec 27, 2020 at 09:38:23AM -0800, Linus Torvalds wrote: > > On Sun, Dec 27, 2020 at 6:16 AM Jon Mason wrote: > > > > > > Wang Qing (1): > > > ntb: idt: fix error check in ntb_hw_idt.c > > > > So this patch seems to be at least

Re: [GIT PULL] NTB bug fixes for v5.11

2021-01-04 Thread Dan Carpenter
On Sun, Dec 27, 2020 at 09:38:23AM -0800, Linus Torvalds wrote: > On Sun, Dec 27, 2020 at 6:16 AM Jon Mason wrote: > > > > Wang Qing (1): > > ntb: idt: fix error check in ntb_hw_idt.c > > So this patch seems to be at least partially triggered by a smatch > warning that is a bit

Re: [GIT PULL] NTB bug fixes for v5.11

2020-12-27 Thread Linus Torvalds
On Sun, Dec 27, 2020 at 9:38 AM Linus Torvalds wrote: > > The thing is, "PTR_ERR()" works just fine on a IS_ERR_OR_NULL pointer. > It doesn't work on a _regular_ non-NULL and non-ERR pointer, and will > return random garbage for those. But if you've tested for > IS_ERR_OR_NULL(), then a regular

Re: [GIT PULL] NTB bug fixes for v5.11

2020-12-27 Thread Linus Torvalds
On Sun, Dec 27, 2020 at 6:16 AM Jon Mason wrote: > > Wang Qing (1): > ntb: idt: fix error check in ntb_hw_idt.c So this patch seems to be at least partially triggered by a smatch warning that is a bit questionable. This part: if (IS_ERR_OR_NULL(dbgfs_topdir)) {

Re: [GIT PULL] NTB bug fixes for v5.11

2020-12-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Dec 2020 09:16:38 -0500: > git://github.com/jonmason/ntb tags/ntb-5.11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a Thank you! -- Deet-doot-dot, I am a bot.

[GIT PULL] NTB bug fixes for v5.11

2020-12-27 Thread Jon Mason
Hello Linus, Here are a few NTB bug fixes for v5.11. Please consider pulling them. Thanks, Jon The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://github.com/jonmason/ntb