Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-06-01 Thread Greg KH
On Thu, Jun 01, 2017 at 02:06:08PM +0200, Dmitry Vyukov wrote: > On Wed, May 31, 2017 at 5:04 PM, Alan Cox wrote: > > On Wed, 31 May 2017 20:16:12 +0900 > > Greg KH wrote: > > > >> On Wed, May 31, 2017 at 10:39:23AM +0200, Dmitry Vyukov wrote: > >> > On Tue, May 30, 2017 at 2:09 PM, Alan Cox >

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-06-01 Thread Dmitry Vyukov
On Wed, May 31, 2017 at 5:04 PM, Alan Cox wrote: > On Wed, 31 May 2017 20:16:12 +0900 > Greg KH wrote: > >> On Wed, May 31, 2017 at 10:39:23AM +0200, Dmitry Vyukov wrote: >> > On Tue, May 30, 2017 at 2:09 PM, Alan Cox >> > wrote: >> > >> >> I'll think about possible solutions, but I have no pri

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-31 Thread Alan Cox
On Wed, 31 May 2017 20:16:12 +0900 Greg KH wrote: > On Wed, May 31, 2017 at 10:39:23AM +0200, Dmitry Vyukov wrote: > > On Tue, May 30, 2017 at 2:09 PM, Alan Cox > > wrote: > > >> >> I'll think about possible solutions, but I have no prior experience > > >> >> with the tty code. In the meantim

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-31 Thread Greg KH
On Wed, May 31, 2017 at 10:39:23AM +0200, Dmitry Vyukov wrote: > On Tue, May 30, 2017 at 2:09 PM, Alan Cox wrote: > >> >> I'll think about possible solutions, but I have no prior experience > >> >> with the tty code. In the meantime syzkaller also hit a couple of > >> >> other fun tty/pty bugs inc

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-31 Thread Dmitry Vyukov
On Tue, May 30, 2017 at 2:09 PM, Alan Cox wrote: >> >> I'll think about possible solutions, but I have no prior experience >> >> with the tty code. In the meantime syzkaller also hit a couple of >> >> other fun tty/pty bugs including a write/ioctl race that results in >> >> buffer overflow :-/ > >

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-30 Thread Alan Cox
> >> I'll think about possible solutions, but I have no prior experience > >> with the tty code. In the meantime syzkaller also hit a couple of > >> other fun tty/pty bugs including a write/ioctl race that results in > >> buffer overflow :-/ There are several of those, including some of that hav

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-30 Thread Dmitry Vyukov
On Wed, May 3, 2017 at 2:01 PM, Greg KH wrote: >> >>> So the original problem is that the vmalloc() in n_tty_open() can >> >>> fail, and that will panic in tty_set_ldisc()/tty_ldisc_restore() >> >>> because of its unwillingness to proceed if the tty doesn't have an >> >>> ldisc. >> >>> >> >>> Dmit

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-03 Thread Greg KH
On Tue, May 02, 2017 at 11:52:40PM +0200, Vegard Nossum wrote: > On 2 May 2017 at 18:35, Dmitry Vyukov wrote: > > On Fri, Apr 14, 2017 at 2:30 PM, Greg KH wrote: > >> On Fri, Apr 14, 2017 at 11:41:26AM +0200, Vegard Nossum wrote: > >>> On 13 April 2017 at 20:34, Greg KH wrote: > >>> > On Thu, Ap

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-03 Thread Dmitry Vyukov
On Tue, May 2, 2017 at 11:52 PM, Vegard Nossum wrote: So the original problem is that the vmalloc() in n_tty_open() can fail, and that will panic in tty_set_ldisc()/tty_ldisc_restore() because of its unwillingness to proceed if the tty doesn't have an ldisc. Dmitry fi

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-02 Thread Vegard Nossum
On 2 May 2017 at 18:35, Dmitry Vyukov wrote: > On Fri, Apr 14, 2017 at 2:30 PM, Greg KH wrote: >> On Fri, Apr 14, 2017 at 11:41:26AM +0200, Vegard Nossum wrote: >>> On 13 April 2017 at 20:34, Greg KH wrote: >>> > On Thu, Apr 13, 2017 at 09:07:40AM -0700, Linus Torvalds wrote: >>> >> On Thu, Apr

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-05-02 Thread Dmitry Vyukov
On Fri, Apr 14, 2017 at 2:30 PM, Greg KH wrote: > On Fri, Apr 14, 2017 at 11:41:26AM +0200, Vegard Nossum wrote: >> On 13 April 2017 at 20:34, Greg KH wrote: >> > On Thu, Apr 13, 2017 at 09:07:40AM -0700, Linus Torvalds wrote: >> >> On Thu, Apr 13, 2017 at 3:50 AM, Vegard Nossum >> >> wrote: >>

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-04-14 Thread Greg KH
On Fri, Apr 14, 2017 at 11:41:26AM +0200, Vegard Nossum wrote: > On 13 April 2017 at 20:34, Greg KH wrote: > > On Thu, Apr 13, 2017 at 09:07:40AM -0700, Linus Torvalds wrote: > >> On Thu, Apr 13, 2017 at 3:50 AM, Vegard Nossum > >> wrote: > >> > > >> > I've bisected a syzkaller crash down to thi

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-04-14 Thread Vegard Nossum
On 13 April 2017 at 20:34, Greg KH wrote: > On Thu, Apr 13, 2017 at 09:07:40AM -0700, Linus Torvalds wrote: >> On Thu, Apr 13, 2017 at 3:50 AM, Vegard Nossum >> wrote: >> > >> > I've bisected a syzkaller crash down to this commit >> > (5362544bebe85071188dd9e479b5a5040841c895). The crash is: >>

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-04-13 Thread Greg KH
On Thu, Apr 13, 2017 at 09:07:40AM -0700, Linus Torvalds wrote: > On Thu, Apr 13, 2017 at 3:50 AM, Vegard Nossum > wrote: > > > > I've bisected a syzkaller crash down to this commit > > (5362544bebe85071188dd9e479b5a5040841c895). The crash is: > > > > [ 25.137552] BUG: unable to handle kernel p

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-04-13 Thread Linus Torvalds
On Thu, Apr 13, 2017 at 3:50 AM, Vegard Nossum wrote: > > I've bisected a syzkaller crash down to this commit > (5362544bebe85071188dd9e479b5a5040841c895). The crash is: > > [ 25.137552] BUG: unable to handle kernel paging request at 2280 > [ 25.137579] IP: mutex_lock_interruptible

Re: [GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-04-13 Thread Vegard Nossum
On 26 March 2017 at 13:04, Greg KH wrote: > The following changes since commit 4495c08e84729385774601b5146d51d9e5849f81: > > Linux 4.11-rc2 (2017-03-12 14:47:08 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ > tags/tty-4.11

[GIT PULL] TTY/Serial driver fixes for 4.11-rc4

2017-03-26 Thread Greg KH
The following changes since commit 4495c08e84729385774601b5146d51d9e5849f81: Linux 4.11-rc2 (2017-03-12 14:47:08 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.11-rc4 for you to fetch changes up to a4a3e061149f09c075f