Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-15 Thread Eduardo Valentin
On Fri, Apr 13, 2018 at 12:27:17PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 03:08:03 AM Eduardo Valentin wrote: > > On Fri, Apr 13, 2018 at 01:39:05PM +0800, Zhang Rui wrote: > > > Hi, Eduardo, > > > > > > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > > > >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 01:12:39 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:41:18 PM Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > > > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > > > > > [ ... ] > > > > >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 12:41:18 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > > > [ ... ] > > > > >>> It is okay to return 0 because this code-path (the default one) will be > > >>

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Daniel Lezcano
On 13/04/2018 12:41, Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: >> On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: >> >> [ ... ] >> > It is okay to return 0 because this code-path (the default one) will be > never hit by the driver (

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > [ ... ] > > >>> It is okay to return 0 because this code-path (the default one) will be > >>> never hit by the driver (probe makes sure of it) - the default case is > >>> here i

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Daniel Lezcano
On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: [ ... ] >>> It is okay to return 0 because this code-path (the default one) will be >>> never hit by the driver (probe makes sure of it) - the default case is >>> here is just to silence compilation errors.. >> >> The init function is making s

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 03:08:03 AM Eduardo Valentin wrote: > On Fri, Apr 13, 2018 at 01:39:05PM +0800, Zhang Rui wrote: > > Hi, Eduardo, > > > > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > > > Hello, > > > > > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Eduardo Valentin
On Fri, Apr 13, 2018 at 03:08:03AM -0700, Eduardo Valentin wrote: > On Fri, Apr 13, 2018 at 01:39:05PM +0800, Zhang Rui wrote: > > Hi, Eduardo, > > > > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > > > Hello, > > > > > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote:

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Eduardo Valentin
On Fri, Apr 13, 2018 at 01:39:05PM +0800, Zhang Rui wrote: > Hi, Eduardo, > > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > > Hello, > > > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > > > > > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui > > > wrote: > > > >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 11:19:40 AM Daniel Lezcano wrote: > On 13/04/2018 11:08, Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: > >> On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > >>> On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote:

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Daniel Lezcano
On 13/04/2018 11:08, Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: >> On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: >>> On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote: Hi, Eduardo, On 四, 2018-04-12 at 21:08 -0700, Eduard

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: > On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote: > >> Hi, Eduardo, > >> > >> On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > >>> Hello, > >>> > >>> On Thu, Apr 12

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Daniel Lezcano
On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote: >> Hi, Eduardo, >> >> On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: >>> Hello, >>> >>> On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: On Wed, Apr 11,

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote: > Hi, Eduardo, > > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > > Hello, > > > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > > > > > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui > > > wrote: > > > > > >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 12, 2018 09:08:57 PM Eduardo Valentin wrote: > Hello, Hi, > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui wrote: > > > > > > could you please illustrate me what the kconfig & warning is? > > > > Just "make all

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-12 Thread Zhang Rui
Hi, Eduardo, On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > Hello, > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > > > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui > > wrote: > > > > > > > > > could you please illustrate me what the kconfig & warning is? > >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-12 Thread Zhang Rui
On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote: > Hello, > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > > > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui > > wrote: > > > > > > > > > could you please illustrate me what the kconfig & warning is? > > Just "make al

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-12 Thread Eduardo Valentin
Hello, On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote: > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui wrote: > > > > could you please illustrate me what the kconfig & warning is? > > Just "make allmodconfig" and the warning is about a uninitialized variable. > > Line 304 in drive

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-12 Thread Daniel Lezcano
On 12/04/2018 18:55, Linus Torvalds wrote: > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui wrote: >> >> could you please illustrate me what the kconfig & warning is? > > Just "make allmodconfig" and the warning is about a uninitialized variable. > > Line 304 in drivers/thermal/samsung/exynos_tmu.c

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-12 Thread Linus Torvalds
On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui wrote: > > could you please illustrate me what the kconfig & warning is? Just "make allmodconfig" and the warning is about a uninitialized variable. Line 304 in drivers/thermal/samsung/exynos_tmu.c if my shell history is to be believed.

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-11 Thread Zhang Rui
Hi, Linus, On 三, 2018-04-11 at 17:01 -0700, Linus Torvalds wrote: > On Wed, Apr 11, 2018 at 1:41 AM, Zhang Rui > wrote: > > > > > > Please pull from > >   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git > > next > Pulled, and then immediately unpulled again. > > The code causes

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-11 Thread Linus Torvalds
On Wed, Apr 11, 2018 at 1:41 AM, Zhang Rui wrote: > > Please pull from > git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git next Pulled, and then immediately unpulled again. The code causes new compiler warnings, and the warnings are valid. If people don't care enough about their

[GIT PULL] Thermal management updates for v4.17-rc1

2018-04-11 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git next to receive the latest Thermal Management updates for v4.17-rc1 with top-most commit f8837aac36cdc7430422cd65f4466071b42654bb:   Merge branches 'thermal-core' and 'thermal-soc' into next (2018-04-02