Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Alex Williamson
On Fri, 2015-05-01 at 13:23 -0700, Linus Torvalds wrote: > On Fri, May 1, 2015 at 11:48 AM, Alex Williamson > wrote: > > > > Ok. It seemed like useful behavior to be able to provide some response > > to the user in the event that a ->remove handler is blocked by a device > > in-use and the user a

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Richard Weinberger
...of course I meant t-> and not current-> On 5/1/15, Richard Weinberger wrote: > On Fri, May 1, 2015 at 8:37 PM, Linus Torvalds > wrote: >> "flush_signals()" is only for kernel threads, where it's a hacky >> alternative to actually handling them (since kernel threads never >> rreturn to user

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Linus Torvalds
On Fri, May 1, 2015 at 11:48 AM, Alex Williamson wrote: > > Ok. It seemed like useful behavior to be able to provide some response > to the user in the event that a ->remove handler is blocked by a device > in-use and the user attempts to abort the action. Well, that kind of notification *might*

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Richard Weinberger
On Fri, May 1, 2015 at 8:37 PM, Linus Torvalds wrote: > "flush_signals()" is only for kernel threads, where it's a hacky > alternative to actually handling them (since kernel threads never > rreturn to user space and cannot really "handle" a signal). But you're > doing it in the ->remove handler f

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Alex Williamson
On Fri, 2015-05-01 at 11:37 -0700, Linus Torvalds wrote: > On Fri, May 1, 2015 at 10:40 AM, Alex Williamson > wrote: > > > > - Flush signals on interrupted wait to retain polling interval (Alex > > Williamson) > > This cannot *possibly* be right. If I read this patch right, you're > randomly jus

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Linus Torvalds
On Fri, May 1, 2015 at 10:40 AM, Alex Williamson wrote: > > - Flush signals on interrupted wait to retain polling interval (Alex > Williamson) This cannot *possibly* be right. If I read this patch right, you're randomly just getting rid of signals. No way in hell is that correct. "flush_signals

[GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Alex Williamson
Hi Linus, The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031: Linux 4.1-rc1 (2015-04-26 17:59:10 -0700) are available in the git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v4.1-rc2 for you to fetch changes up to 82a0eaab980a3af92d46e93eaf299d