Re: [GIT PULL] afs fixes

2020-10-29 Thread pr-tracker-bot
The pull request you sent on Thu, 29 Oct 2020 14:07:26 +: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20201029 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/598a597636f8618a0520fd3ccefedaed9e4709b0 Thank you! -- Deet-

[GIT PULL] afs fixes

2020-10-29 Thread David Howells
Hi Linus, Could you pull these afs fixes, please? They include the following: (1) Fix copy_file_range() to an afs file now returning EINVAL if the splice_write file op isn't supplied. (2) Fix a deref-before-check in afs_unuse_cell(). (3) Fix a use-after-free in afs_xattr_get_acl(). (

Re: [GIT PULL] afs: Fixes for bugs found by xfstests

2020-06-16 Thread pr-tracker-bot
The pull request you sent on Tue, 16 Jun 2020 22:51:46 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20200616 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/26c20ffcb5c86eb6a052e0d528396de5600c9710 Thank you! -- Deet-

[GIT PULL] afs: Fixes for bugs found by xfstests

2020-06-16 Thread David Howells
Hi Linus, I've managed to get xfstests kind of working with afs. Here are a set of patches that fix most of the bugs found. There are a number of primary issues: (1) Incorrect handling of mtime and non-handling of ctime. It might be argued, that the latter isn't a bug since the AFS proto

Re: [GIT PULL] afs: Fixes

2019-08-22 Thread pr-tracker-bot
The pull request you sent on Thu, 22 Aug 2019 14:10:39 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20190822 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e8c3fa9f4d3b9c56ee9436c310318a8165d695c1 Thank you! -- Deet-

[GIT PULL] afs: Fixes

2019-08-22 Thread David Howells
Hi Linus, Here are three fixes for afs: (1) Fix a cell record leak due to the default error not being cleared. (2) Fix an oops in tracepoint due to a pointer that may contain an error. (3) Fix the ACL storage op for YFS where the wrong op definition is being used. By luck, this only ac

Re: [GIT PULL] afs: Fixes

2019-08-14 Thread pr-tracker-bot
The pull request you sent on Wed, 14 Aug 2019 15:18:40 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20190814 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e22a97a2a85d2a0bdfb134cbbc7ff856ae67edba Thank you! -- Deet-

[GIT PULL] afs: Fixes

2019-08-14 Thread David Howells
Hi Linus, Can you pull these afs fixes please? (1) Fix the CB.ProbeUuid handler to generate its reply correctly. (2) Fix a mix up in indices when parsing a Volume Location entry record. (3) Fix a potential NULL-pointer deref when cleaning up a read request. (4) Fix the expected data versio

[GIT PULL] afs: Fixes

2019-08-14 Thread David Howells
Hi Linus, Can you pull these afs fixes please? (1) Fix the CB.ProbeUuid handler to generate its reply correctly. (2) Fix a mix up in indices when parsing a Volume Location entry record. (3) Fix a potential NULL-pointer deref when cleaning up a read request. (4) Fix the expected data versio

Re: [GIT PULL] AFS fixes

2019-06-27 Thread pr-tracker-bot
The pull request you sent on Wed, 26 Jun 2019 14:39:53 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20190620 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cd0f3aaebc5b17e0ccb1b9ef9ae43042d075d767 Thank you! -- Deet-

[GIT PULL] AFS fixes

2019-06-26 Thread David Howells
Hi Linus, Could you pull this please? There are four patches: (1) Fix the printing of the "vnode modified" warning to exclude checks on files for which we don't have a callback promise from the server (and so don't expect the server to tell us when it changes). Without this, for

Re: [GIT PULL] AFS fixes

2019-06-26 Thread David Howells
Oops... I forgot to include the pull request bit. Will resend. David

[GIT PULL] AFS fixes

2019-06-26 Thread David Howells
Hi Linus, Could you pull this please? There are four patches: (1) Fix the printing of the "vnode modified" warning to exclude checks on files for which we don't have a callback promise from the server (and so don't expect the server to tell us when it changes). Without this, for

Re: [GIT PULL] AFS fixes and development

2019-05-07 Thread pr-tracker-bot
The pull request you sent on Tue, 07 May 2019 21:11:17 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-next-20190507 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e5fef2a9732580c5bd30c0097f5e9091a3d58ce5 Thank you! -- Deet-d

[GIT PULL] AFS fixes and development

2019-05-07 Thread David Howells
Hi Linus, The following are a set of fix and development patches for AFS for 5.2. To summarise: (1) Fix the AFS file locking so that sqlite can run on an AFS mount and also so that firefox and gnome can use a homedir that's mounted through AFS. This required emulation of fine-gr

Re: [GIT PULL] afs: Fixes

2019-04-18 Thread pr-tracker-bot
The pull request you sent on Thu, 18 Apr 2019 10:17:32 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20190413 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2a852fd1ac893d75879923025306f146b7e0747e Thank you! -- Deet-

[GIT PULL] afs: Fixes

2019-04-18 Thread David Howells
Hi Linus, Could you pull these afs fixes please? There are five: (1) Stop using the deprecated get_seconds(). (2) Don't make tracepoint strings const as the section they go in isn't read-only. (3) Differentiate failure due to unmarshalling from other failure cases - we shouldn't a

Re: [GIT PULL] AFS fixes and other bits

2019-03-16 Thread David Howells
Linus Torvalds wrote: > The thing hasn't even seen a compiler, and when you *do* show the code > to a compiler, said compiler correctly warns about No, it doesn't - at least not gcc-8.3.1 on Fedora 29. What compiler are you using? > afs_do_silly_unlink() potentially returning an uninitialized

Re: [GIT PULL] AFS fixes and other bits

2019-03-15 Thread Linus Torvalds
On Fri, Mar 15, 2019 at 4:41 PM David Howells wrote: > > Here's a set of fixes and other bits for AFS to improve the life of desktop > applications such as firefox. I pulled, and immediately unpulled. The thing hasn't even seen a compiler, and when you *do* show the code to a compiler, said comp

[GIT PULL] AFS fixes and other bits

2019-03-15 Thread David Howells
Hi Linus, Here's a set of fixes and other bits for AFS to improve the life of desktop applications such as firefox. It makes the following improvements/fixes: (1) Fix file locking to allow fine-grained locking, as required by firefox and sqlite, with the caveat that you can't get a partial

[GIT PULL] AFS fixes and other bits

2019-03-15 Thread David Howells
Hi Linus, Here's a set of fixes and other bits for AFS to improve the life of desktop applications such as firefox. It makes the following improvements/fixes: (1) Fix file locking to allow fine-grained locking, as required by firefox and sqlite, with the caveat that you can't get a partial

[GIT PULL] afs: Fixes

2018-05-14 Thread David Howells
Hi Linus, Here's a set of patches that fix a number of bugs in the in-kernel AFS client, including: (1) Fix directory locking to not use individual page locks for directory reading/scanning but rather to use a semaphore on the afs_vnode struct as the directory contents must be read in

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread David Howells
Linus Torvalds wrote: > However, even when you do that, the page can be writable in other > mappings. At least fork(), for example, only clears the dirty bit, > doesn't mark it write-protected. I assumed the rmap walk done by page_mkclean() would take care of that but I'm not really clear on wha

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 12:35 PM, David Howells wrote: > > Doesn't clear_page_dirty_for_io() write-protect the PTE for the page to be > written out, in which case ->page_mkwrite() will get called again before the > page is redirtied? No, it literally just sets the dirty bit (and does accounting).

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread Dave Chinner
On Sat, Nov 25, 2017 at 10:35:43PM +, David Howells wrote: > Linus Torvalds wrote: > > > So I see in the commit message why afs needs to do this, but it's > > worth pointing out that it's > > > > (a) impossible to avoid the "inconsistent data" case for writable mmap'ed > > pages > > Doesn

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread David Howells
Linus Torvalds wrote: > So I see in the commit message why afs needs to do this, but it's > worth pointing out that it's > > (a) impossible to avoid the "inconsistent data" case for writable mmap'ed > pages Doesn't clear_page_dirty_for_io() write-protect the PTE for the page to be written out

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread Linus Torvalds
On Fri, Nov 24, 2017 at 4:22 AM, David Howells wrote: > > (2) Don't write to a page that's being written out, but wait for it to > complete. So I see in the commit message why afs needs to do this, but it's worth pointing out that it's (a) impossible to avoid the "inconsistent data" case

[GIT PULL] afs: Fixes

2017-11-24 Thread David Howells
Hi Linus, Can you pull these fixes for the AFS filesystem? They include: (1) Make AFS file locking work again. (2) Don't write to a page that's being written out, but wait for it to complete. (3) Do d_drop() and d_add() in the right places. (4) Put keys on error paths. (5) Remove s

Re: [GIT PULL] AFS fixes

2017-03-17 Thread Linus Torvalds
On Fri, Mar 17, 2017 at 8:29 AM, David Howells wrote: > > Could you pull these fixes to the AFS filesystem in the kernel please? I took this, but honestly, most of the patches look like "merge window" patches rather than -rc patches. Exactly _one_ of the patches was marked for stable. The rest l

[GIT PULL] AFS fixes

2017-03-17 Thread David Howells
Hi Linus, Could you pull these fixes to the AFS filesystem in the kernel please? They fix a variety of bugs. These include some issues fixed for consistency with other AFS implementations: (*) Handle AFS mode bits better. (*) Use the client mtime rather than the server mtime in the protocol.