On Sun, 14 Dec 2014 17:39:36 -0500 Benjamin LaHaise wrote:
> How about the documentation/comment updates below?
lgtm.
> ...
>
> +/* aio_ring_remap()
> + * Called when th aio event ring is being relocated within the process'
"the"
> + * address space. The primary purpose is to update the
On Sun, Dec 14, 2014 at 3:02 PM, Kirill A. Shutemov
wrote:
>
> How can we know that it's okay to move vma around for random driver which
> provide .mmap? Or I miss something obvious?
I do think that it would likely be a good idea to require an explicit
flag somewhere before we do "move_vma()". I
On Mon, Dec 15, 2014 at 01:02:08AM +0200, Kirill A. Shutemov wrote:
> But it seems the problem is bigger than what the patch fixes. To me we are
> too permisive on what vma can be remapped.
>
> How can we know that it's okay to move vma around for random driver which
> provide .mmap? Or I miss
On Sun, Dec 14, 2014 at 02:13:36PM -0800, Andrew Morton wrote:
> On Sun, 14 Dec 2014 16:52:21 -0500 Benjamin LaHaise wrote:
>
> > On Sun, Dec 14, 2014 at 01:47:32PM -0800, Linus Torvalds wrote:
> > > On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise wrote:
> > > >
> > > > Pavel Emelyanov (1):
On Sun, Dec 14, 2014 at 02:13:36PM -0800, Andrew Morton wrote:
> The patch appears to be a bugfix which coincidentally helps CRIU?
Yes.
> If it weren't for the bugfix part, I'd be asking "why not pass the
> desired virtual address into io_setup()?".
It's entirely possible someone might have a
On Sun, 14 Dec 2014 16:52:21 -0500 Benjamin LaHaise wrote:
> On Sun, Dec 14, 2014 at 01:47:32PM -0800, Linus Torvalds wrote:
> > On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise wrote:
> > >
> > > Pavel Emelyanov (1):
> > > aio: Make it possible to remap aio ring
> >
> > So quite
On Sun, Dec 14, 2014 at 1:52 PM, Benjamin LaHaise wrote:
>
> Sadly, nobody responded.
Well, I did pull, because I found the patch ok, but in general I
really want to get a heads up for changes like this, and not be taken
by surprise by them.
Linus
--
To unsubscribe
On Sun, Dec 14, 2014 at 01:47:32PM -0800, Linus Torvalds wrote:
> On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise wrote:
> >
> > Pavel Emelyanov (1):
> > aio: Make it possible to remap aio ring
>
> So quite frankly, I think this should have had more acks from VM
> people. The patch
On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise wrote:
>
> Pavel Emelyanov (1):
> aio: Make it possible to remap aio ring
So quite frankly, I think this should have had more acks from VM
people. The patch looks ok to me, but it took me by surprise, and I
don't see much any discussion
Hello Linus & everyone,
The following changes since commit b2776bf7149bddd1f4161f14f79520f17fc1d71d:
Linux 3.18 (2014-12-07 14:21:05 -0800)
are available in the git repository at:
git://git.kvack.org/~bcrl/aio-next.git master
for you to fetch changes up to
Hello Linus everyone,
The following changes since commit b2776bf7149bddd1f4161f14f79520f17fc1d71d:
Linux 3.18 (2014-12-07 14:21:05 -0800)
are available in the git repository at:
git://git.kvack.org/~bcrl/aio-next.git master
for you to fetch changes up to
On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise b...@kvack.org wrote:
Pavel Emelyanov (1):
aio: Make it possible to remap aio ring
So quite frankly, I think this should have had more acks from VM
people. The patch looks ok to me, but it took me by surprise, and I
don't see much any
On Sun, Dec 14, 2014 at 01:47:32PM -0800, Linus Torvalds wrote:
On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise b...@kvack.org wrote:
Pavel Emelyanov (1):
aio: Make it possible to remap aio ring
So quite frankly, I think this should have had more acks from VM
people. The patch
On Sun, Dec 14, 2014 at 1:52 PM, Benjamin LaHaise b...@kvack.org wrote:
Sadly, nobody responded.
Well, I did pull, because I found the patch ok, but in general I
really want to get a heads up for changes like this, and not be taken
by surprise by them.
Linus
--
To
On Sun, 14 Dec 2014 16:52:21 -0500 Benjamin LaHaise b...@kvack.org wrote:
On Sun, Dec 14, 2014 at 01:47:32PM -0800, Linus Torvalds wrote:
On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise b...@kvack.org wrote:
Pavel Emelyanov (1):
aio: Make it possible to remap aio ring
So
On Sun, Dec 14, 2014 at 02:13:36PM -0800, Andrew Morton wrote:
The patch appears to be a bugfix which coincidentally helps CRIU?
Yes.
If it weren't for the bugfix part, I'd be asking why not pass the
desired virtual address into io_setup()?.
It's entirely possible someone might have a need
On Sun, Dec 14, 2014 at 02:13:36PM -0800, Andrew Morton wrote:
On Sun, 14 Dec 2014 16:52:21 -0500 Benjamin LaHaise b...@kvack.org wrote:
On Sun, Dec 14, 2014 at 01:47:32PM -0800, Linus Torvalds wrote:
On Sun, Dec 14, 2014 at 12:22 PM, Benjamin LaHaise b...@kvack.org wrote:
Pavel
On Mon, Dec 15, 2014 at 01:02:08AM +0200, Kirill A. Shutemov wrote:
But it seems the problem is bigger than what the patch fixes. To me we are
too permisive on what vma can be remapped.
How can we know that it's okay to move vma around for random driver which
provide .mmap? Or I miss
On Sun, Dec 14, 2014 at 3:02 PM, Kirill A. Shutemov
kir...@shutemov.name wrote:
How can we know that it's okay to move vma around for random driver which
provide .mmap? Or I miss something obvious?
I do think that it would likely be a good idea to require an explicit
flag somewhere before we
On Sun, 14 Dec 2014 17:39:36 -0500 Benjamin LaHaise b...@kvack.org wrote:
How about the documentation/comment updates below?
lgtm.
...
+/* aio_ring_remap()
+ * Called when th aio event ring is being relocated within the process'
the
+ * address space. The primary purpose is to
20 matches
Mail list logo
