Re: [GIT PULL] cgroup fixes for v3.17-rc4

2014-09-07 Thread Tejun Heo
Hello, Linus. On Sun, Sep 07, 2014 at 08:17:11PM -0700, Linus Torvalds wrote: > In other words, I'll happily pull this, but your excuses for it are > wrong-headed. There is no "crazyness justifies this". That's crap. But > the argument of "nobody does this, so let's fix it before anybody > _starts

Re: [GIT PULL] cgroup fixes for v3.17-rc4

2014-09-07 Thread Linus Torvalds
On Sun, Sep 7, 2014 at 6:20 PM, Tejun Heo wrote: > > While this is a userland visible > behavior change, given the craziness of allowing '\n' and its > implications, I believe the change is justified. Tejun, absolutely nothing "justifies" things if they break. Not "bad design",

[GIT PULL] cgroup fixes for v3.17-rc4

2014-09-07 Thread Tejun Heo
Hello, Linus. Up until now, cgroup has allowed any character including '\n' in cgroup names; unfortunately, as '\n' is used as the row delimiter in /proc/$PID/cgroup, '\n' in a cgroup name makes the content of the file ambiguous to parse. This pull request includes Alban's patch to disallow '\n'