Re: [GIT PULL] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2014-02-13 Thread Ingo Molnar
* Linus Torvalds wrote: > On Wed, Feb 12, 2014 at 7:09 PM, Steven Noonan wrote: > > > > If I change the GCC_VERSION check for the asm_volatile_goto quirk to > > include 4.8.2, then KVM guests are properly cleaned up. > > Ok, I guess that means we should just make the quirk unconditional. > >

Re: [GIT PULL] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2014-02-12 Thread Jakub Jelinek
On Wed, Feb 12, 2014 at 08:11:49PM -0800, Linus Torvalds wrote: > Jakub, any suggestions to how Steven might be able to pinpoint where > the code generation problem lies? For a suspected wrong-code where you have no idea where the problem is from debugging or oops etc., usually the best way is to

Re: [GIT PULL] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2014-02-12 Thread Linus Torvalds
On Wed, Feb 12, 2014 at 7:09 PM, Steven Noonan wrote: > > If I change the GCC_VERSION check for the asm_volatile_goto quirk to > include 4.8.2, then KVM guests are properly cleaned up. Ok, I guess that means we should just make the quirk unconditional. Ingo, do you want to do that or should I?

Re: [GIT PULL] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2014-02-12 Thread Steven Noonan
Resurrecting this thread, as I'm running with GCC 4.8.2 and am encountering miscompiles without this quirk being enabled for my compiler version. I'm having trouble pinning down the miscompilation itself, but I have a problem that seems reliably reproducible in my environment. I noticed that when

[GIT PULL] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-12 Thread Ingo Molnar
Linus, Please pull the latest core-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus HEAD: 3f0116c3238a96bc18ad4b4acefe4e7be32fa861 compiler/gcc4: Add quirk for 'asm goto' miscompilation bug This is the fix for the GCC miscom