Re: [GIT PULL] ext4 bug fixes for 4.6

Linus, Thanks for reverting the broken commit. I'll work on a proper fix for the readdir() issue for the next merge cycle, and make sure it gets proper testing. I'll also take care of packaging up Greg's test program and getting it submitted to xfstests so we have a proper regression test case.

Re: [GIT PULL] ext4 bug fixes for 4.6

Linus, Thanks for reverting the broken commit. I'll work on a proper fix for the readdir() issue for the next merge cycle, and make sure it gets proper testing. I'll also take care of packaging up Greg's test program and getting it submitted to xfstests so we have a proper regression test case.

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:48 PM, Linus Torvalds wrote: > > The attached patch is actually tested and seems to fix the issue. Christ. Now really attached. I'll just go back to bed, because today is just not working out. Maybe things will be better tomorrow. Or

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:29 PM, Linus Torvalds wrote: > > I think the right choice might be to > > (a) revert that patch (or just change the signal_pending() into > fatal_signal_pending()) > > (b) to get the latency advantage, do something like this: The

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:48 PM, Linus Torvalds wrote: > > The attached patch is actually tested and seems to fix the issue. Christ. Now really attached. I'll just go back to bed, because today is just not working out. Maybe things will be better tomorrow. Or maybe I should start drinking, and

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:29 PM, Linus Torvalds wrote: > > I think the right choice might be to > > (a) revert that patch (or just change the signal_pending() into > fatal_signal_pending()) > > (b) to get the latency advantage, do something like this: The attached patch is actually tested and

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:32 PM, Linus Torvalds wrote: > > if (signal_pending()) > return -EINTR; "signal_pending(current)", dammit. I give up. I'm sure you understood what I meant. I need to go make myself more coffee. Or something.

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:32 PM, Linus Torvalds wrote: > > if (signal_pending()) > return -EINTR; "signal_pending(current)", dammit. I give up. I'm sure you understood what I meant. I need to go make myself more coffee. Or something. Linus

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:29 PM, Linus Torvalds wrote: > > (b) to get the latency advantage, do something like this: > > + if (signal_pending) > + return -EINTR; That should be if (signal_pending())

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sun, Apr 10, 2016 at 1:29 PM, Linus Torvalds wrote: > > (b) to get the latency advantage, do something like this: > > + if (signal_pending) > + return -EINTR; That should be if (signal_pending()) return -EINTR; of course. Missing

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sat, Apr 9, 2016 at 7:23 PM, Greg Thelen wrote: > > > I've been testing 5b5b7fd185e9 (linus/master) and seeing that > interrupted readdir() now returns duplicate dirents. Yes, your test-program recreates this beautifully here. Sadly not while stracing. Worth adding as a

Re: [GIT PULL] ext4 bug fixes for 4.6

On Sat, Apr 9, 2016 at 7:23 PM, Greg Thelen wrote: > > > I've been testing 5b5b7fd185e9 (linus/master) and seeing that > interrupted readdir() now returns duplicate dirents. Yes, your test-program recreates this beautifully here. Sadly not while stracing. Worth adding as a filesystem test to

Re: [GIT PULL] ext4 bug fixes for 4.6

Theodore Ts'o wrote: > The following changes since commit 243d50678583100855862bc084b8b307eea67f68: > > Merge branch 'overlayfs-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs (2016-03-22 > 13:11:15 -0700) > n> are available in the git repository at: > >

Re: [GIT PULL] ext4 bug fixes for 4.6

Theodore Ts'o wrote: > The following changes since commit 243d50678583100855862bc084b8b307eea67f68: > > Merge branch 'overlayfs-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs (2016-03-22 > 13:11:15 -0700) > n> are available in the git repository at: > >

[GIT PULL] ext4 bug fixes for 4.6

The following changes since commit 243d50678583100855862bc084b8b307eea67f68: Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs (2016-03-22 13:11:15 -0700) are available in the git repository at:

[GIT PULL] ext4 bug fixes for 4.6

The following changes since commit 243d50678583100855862bc084b8b307eea67f68: Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs (2016-03-22 13:11:15 -0700) are available in the git repository at: