Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 01:22:41PM -0700, Linus Torvalds wrote: > > You have the tag *message* for fscrypt, but then the commit it points > to has nothing to do with fscrypt. > > I think you tagged the wrong branch. Yeah, sorry. I used git shortlog when I was examining the branch to compose

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 01:22:41PM -0700, Linus Torvalds wrote: > > You have the tag *message* for fscrypt, but then the commit it points > to has nothing to do with fscrypt. > > I think you tagged the wrong branch. Yeah, sorry. I used git shortlog when I was examining the branch to compose

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 07:05:52PM +0200, Richard Weinberger wrote: > > An attack scenario where someone manages to downgrade the crypto of > > your phone would require replacing your kernel and your /system > > partition --- at which point, you've got other problems. :-) > > This means Speck is

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 07:05:52PM +0200, Richard Weinberger wrote: > > An attack scenario where someone manages to downgrade the crypto of > > your phone would require replacing your kernel and your /system > > partition --- at which point, you've got other problems. :-) > > This means Speck is

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Linus Torvalds
On Tue, Jun 5, 2018 at 8:07 AM Theodore Y. Ts'o wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/fscrypt.git > tags/fscrypt_for_linus That tag actually points to the same commit as the 'ext4_for_linus' tag pointed to. You have the tag *message* for fscrypt, but then the commit

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Linus Torvalds
On Tue, Jun 5, 2018 at 8:07 AM Theodore Y. Ts'o wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/fscrypt.git > tags/fscrypt_for_linus That tag actually points to the same commit as the 'ext4_for_linus' tag pointed to. You have the tag *message* for fscrypt, but then the commit

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Richard Weinberger
Am Dienstag, 5. Juni 2018, 19:02:08 CEST schrieb Theodore Y. Ts'o: > On Tue, Jun 05, 2018 at 06:10:24PM +0200, Richard Weinberger wrote: > > That's the question. I understand the use case, but I fear attack scenarios > > where someone manages to downgrade the crypto of my phone. > > This is why I

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Richard Weinberger
Am Dienstag, 5. Juni 2018, 19:02:08 CEST schrieb Theodore Y. Ts'o: > On Tue, Jun 05, 2018 at 06:10:24PM +0200, Richard Weinberger wrote: > > That's the question. I understand the use case, but I fear attack scenarios > > where someone manages to downgrade the crypto of my phone. > > This is why I

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 06:10:24PM +0200, Richard Weinberger wrote: > That's the question. I understand the use case, but I fear attack scenarios > where someone manages to downgrade the crypto of my phone. > This is why I was asking whether Android tells me whether Speck is used or > not. > "it

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 06:10:24PM +0200, Richard Weinberger wrote: > That's the question. I understand the use case, but I fear attack scenarios > where someone manages to downgrade the crypto of my phone. > This is why I was asking whether Android tells me whether Speck is used or > not. > "it

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Richard Weinberger
Am Dienstag, 5. Juni 2018, 17:35:01 CEST schrieb Theodore Y. Ts'o: > On Tue, Jun 05, 2018 at 05:13:35PM +0200, Richard Weinberger wrote: > > > Add bunch of cleanups, and add support for the Speck128/256 > > > algorithms. Yes, Speck is contrversial, but the intention is to use > > > them only for

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Richard Weinberger
Am Dienstag, 5. Juni 2018, 17:35:01 CEST schrieb Theodore Y. Ts'o: > On Tue, Jun 05, 2018 at 05:13:35PM +0200, Richard Weinberger wrote: > > > Add bunch of cleanups, and add support for the Speck128/256 > > > algorithms. Yes, Speck is contrversial, but the intention is to use > > > them only for

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 05:13:35PM +0200, Richard Weinberger wrote: > > Add bunch of cleanups, and add support for the Speck128/256 > > algorithms. Yes, Speck is contrversial, but the intention is to use > > them only for the lowest end Android devices, where the alternative > > *really* is no

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 05:13:35PM +0200, Richard Weinberger wrote: > > Add bunch of cleanups, and add support for the Speck128/256 > > algorithms. Yes, Speck is contrversial, but the intention is to use > > them only for the lowest end Android devices, where the alternative > > *really* is no

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Richard Weinberger
Ted, On Tue, Jun 5, 2018 at 5:07 PM, Theodore Y. Ts'o wrote: > The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb: > > Linux 4.17-rc4 (2018-05-06 16:57:38 -1000) > > are available in the Git repository at: > >

Re: [GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Richard Weinberger
Ted, On Tue, Jun 5, 2018 at 5:07 PM, Theodore Y. Ts'o wrote: > The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb: > > Linux 4.17-rc4 (2018-05-06 16:57:38 -1000) > > are available in the Git repository at: > >

[GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb: Linux 4.17-rc4 (2018-05-06 16:57:38 -1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/fscrypt.git tags/fscrypt_for_linus for you to fetch changes up to

[GIT PULL] fscrypt updates for 4.18

2018-06-05 Thread Theodore Y. Ts'o
The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb: Linux 4.17-rc4 (2018-05-06 16:57:38 -1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/fscrypt.git tags/fscrypt_for_linus for you to fetch changes up to