Re: [GIT PULL] microcode loader updates

2015-03-03 Thread Ingo Molnar
* Borislav Petkov wrote: > Hi guys, > > here's the first pile of microcode loader cleanups for 4.1. > > Please pull, > thanks. > > --- > The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: > > Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) > > are available in the git

Re: [GIT PULL] microcode loader updates

2015-03-03 Thread Ingo Molnar
* Borislav Petkov b...@alien8.de wrote: Hi guys, here's the first pile of microcode loader cleanups for 4.1. Please pull, thanks. --- The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) are available in the

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 01:34:41PM +0100, Borislav Petkov wrote: > Hi guys, > > here's the first pile of microcode loader cleanups for 4.1. > > Please pull, > thanks. > > --- > The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: > > Linux 4.0-rc1 (2015-02-22 18:21:14

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Quentin Casasnovas
On Mon, Mar 02, 2015 at 04:04:28PM +0100, Borislav Petkov wrote: > > Ok, ok, you got me persuaded. Oh. that's unexpected :) > > Better? > > :-) > I prefer it, thanks! Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 02:42:12PM +0100, Quentin Casasnovas wrote: > It's just that this potential-but-very-very-likely-impossible kfree() on > garbage wasn't present in the original code - so I thought changing the > kmalloc() => kcalloc() was small enough to add in your serie. I'd also be >

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Quentin Casasnovas
On Mon, Mar 02, 2015 at 02:29:50PM +0100, Borislav Petkov wrote: > On Mon, Mar 02, 2015 at 02:03:36PM +0100, Quentin Casasnovas wrote: > > So at the last loop iteration for j == i, we'll do kfree(saved_ptr[j]) > > which AFAICT hasn't been initialized yet. Using a kcalloc() your first > >

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 02:03:36PM +0100, Quentin Casasnovas wrote: > So at the last loop iteration for j == i, we'll do kfree(saved_ptr[j]) > which AFAICT hasn't been initialized yet. Using a kcalloc() your first > allocation for saved_ptr should just work since the memory will be cleared > and

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Quentin Casasnovas
Hi Boris! On Mon, Mar 02, 2015 at 01:34:41PM +0100, Borislav Petkov wrote: > Hi guys, > > here's the first pile of microcode loader cleanups for 4.1. > > Please pull, > thanks. > > --- > The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: > > Linux 4.0-rc1

[GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
Hi guys, here's the first pile of microcode loader cleanups for 4.1. Please pull, thanks. --- The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) are available in the git repository at:

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 02:42:12PM +0100, Quentin Casasnovas wrote: It's just that this potential-but-very-very-likely-impossible kfree() on garbage wasn't present in the original code - so I thought changing the kmalloc() = kcalloc() was small enough to add in your serie. I'd also be fine

[GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
Hi guys, here's the first pile of microcode loader cleanups for 4.1. Please pull, thanks. --- The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) are available in the git repository at:

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Quentin Casasnovas
On Mon, Mar 02, 2015 at 02:29:50PM +0100, Borislav Petkov wrote: On Mon, Mar 02, 2015 at 02:03:36PM +0100, Quentin Casasnovas wrote: So at the last loop iteration for j == i, we'll do kfree(saved_ptr[j]) which AFAICT hasn't been initialized yet. Using a kcalloc() your first allocation for

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 02:03:36PM +0100, Quentin Casasnovas wrote: So at the last loop iteration for j == i, we'll do kfree(saved_ptr[j]) which AFAICT hasn't been initialized yet. Using a kcalloc() your first allocation for saved_ptr should just work since the memory will be cleared and

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Quentin Casasnovas
Hi Boris! On Mon, Mar 02, 2015 at 01:34:41PM +0100, Borislav Petkov wrote: Hi guys, here's the first pile of microcode loader cleanups for 4.1. Please pull, thanks. --- The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Quentin Casasnovas
On Mon, Mar 02, 2015 at 04:04:28PM +0100, Borislav Petkov wrote: Ok, ok, you got me persuaded. Oh. that's unexpected :) Better? :-) I prefer it, thanks! Quentin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [GIT PULL] microcode loader updates

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 01:34:41PM +0100, Borislav Petkov wrote: Hi guys, here's the first pile of microcode loader cleanups for 4.1. Please pull, thanks. --- The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)