Re: [GIT PULL] namespace updates for v3.17-rc1

2014-11-29 Thread Richard Weinberger
Am 26.11.2014 um 00:15 schrieb Richard Weinberger: > Eric, > > On Thu, Aug 21, 2014 at 4:09 PM, Eric W. Biederman > wrote: >> Richard Weinberger writes: >> >>> Am 21.08.2014 15:12, schrieb Christoph Hellwig: On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: > Richard We

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-11-25 Thread Richard Weinberger
Eric, On Thu, Aug 21, 2014 at 4:09 PM, Eric W. Biederman wrote: > Richard Weinberger writes: > >> Am 21.08.2014 15:12, schrieb Christoph Hellwig: >>> On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: Richard Weinberger writes: > On Wed, Aug 6, 2014 at 2:57 AM, Eri

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-09-03 Thread Richard Weinberger
On Thu, Aug 21, 2014 at 4:09 PM, Eric W. Biederman wrote: >> It looks like commit 87b47932f40a11280584bce260cbdb3b5f9e8b7d in >> git.kernel.org/cgit/linux/kernel/git/ebiederm/user-namespace.git for-next >> unbreaks libvirt-lxc. >> I hope it hits Linus tree and -stable before the offending commit h

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-21 Thread Eric W. Biederman
Richard Weinberger writes: > Am 21.08.2014 15:12, schrieb Christoph Hellwig: >> On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: >>> Richard Weinberger writes: >>> On Wed, Aug 6, 2014 at 2:57 AM, Eric W. Biederman wrote: This commit breaks libvirt-lxc. >>>

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-21 Thread Eric W. Biederman
Richard Weinberger writes: > Am 21.08.2014 08:29, schrieb Richard Weinberger: >> Am 21.08.2014 06:53, schrieb Eric W. Biederman: >>> The bugs fixed are security issues, so if we have to break a small >>> number of userspace applications we will. Anything that we can >>> reasonably do to avoid re

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-21 Thread Eric W. Biederman
Christoph Hellwig writes: > On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: >> Richard Weinberger writes: >> >> > On Wed, Aug 6, 2014 at 2:57 AM, Eric W. Biederman >> > wrote: >> > >> > This commit breaks libvirt-lxc. >> > libvirt does in lxcContainerMountBasicFS(): >> >>

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-21 Thread Richard Weinberger
Am 21.08.2014 15:12, schrieb Christoph Hellwig: > On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: >> Richard Weinberger writes: >> >>> On Wed, Aug 6, 2014 at 2:57 AM, Eric W. Biederman >>> wrote: >>> >>> This commit breaks libvirt-lxc. >>> libvirt does in lxcContainerMountBasi

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-21 Thread Christoph Hellwig
On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: > Richard Weinberger writes: > > > On Wed, Aug 6, 2014 at 2:57 AM, Eric W. Biederman > > wrote: > > > > This commit breaks libvirt-lxc. > > libvirt does in lxcContainerMountBasicFS(): > > The bugs fixed are security issues, so

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-21 Thread Richard Weinberger
Am 21.08.2014 08:29, schrieb Richard Weinberger: > Am 21.08.2014 06:53, schrieb Eric W. Biederman: >> The bugs fixed are security issues, so if we have to break a small >> number of userspace applications we will. Anything that we can >> reasonably do to avoid regressions will be done. >> >> Could

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-20 Thread Richard Weinberger
Am 21.08.2014 06:53, schrieb Eric W. Biederman: > The bugs fixed are security issues, so if we have to break a small > number of userspace applications we will. Anything that we can > reasonably do to avoid regressions will be done. > > Could you please look at my user-namespace.git#for-next bran

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-20 Thread Eric W. Biederman
Richard Weinberger writes: > On Wed, Aug 6, 2014 at 2:57 AM, Eric W. Biederman > wrote: > > This commit breaks libvirt-lxc. > libvirt does in lxcContainerMountBasicFS(): The bugs fixed are security issues, so if we have to break a small number of userspace applications we will. Anything that

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-20 Thread Richard Weinberger
On Wed, Aug 6, 2014 at 2:57 AM, Eric W. Biederman wrote: > > Linus, > > Please pull the for-linus branch from the git tree: > >git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > for-linus > >HEAD: 344470cac42e887e68cfb5bdfa6171baf27f1eb5 proc: Point /proc/mounts a

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-15 Thread Andy Lutomirski
On Wed, Aug 13, 2014 at 3:24 AM, Eric W. Biederman wrote: > Kenton Varda writes: > >> On Tue, Aug 12, 2014 at 9:17 PM, Eric W. Biederman >> wrote: > From: "Eric W. Biederman" > Date: Wed, 13 Aug 2014 01:33:38 -0700 > Subject: [PATCH] mnt: Implicitly add MNT_NODEV on remount as we do on mount >

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-13 Thread Andy Lutomirski
On Wed, Aug 13, 2014 at 3:24 AM, Eric W. Biederman wrote: > Kenton Varda writes: > >> On Tue, Aug 12, 2014 at 9:17 PM, Eric W. Biederman > I have a proposed fix as the end of this email. Could you please > test it? > > If I can get a Tested-by and possibly a Reviewed-by responses I would > appre

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-13 Thread Eric W. Biederman
Kenton Varda writes: > On Tue, Aug 12, 2014 at 9:17 PM, Eric W. Biederman > wrote: > > If you can find a userspace application that matters I might care > > that a security fix breaks it. > > FWIW, it broke Sandstorm.io, but we already pushed a fix, and I'm not > sure if you'd say t

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-12 Thread Andy Lutomirski
On Tue, Aug 12, 2014 at 9:17 PM, Eric W. Biederman wrote: > Andy Lutomirski writes: > >> On 08/05/2014 05:57 PM, Eric W. Biederman wrote: >> >> Sorry for catching this late. I think this fix is likely to >> unnecessarily break valid userspace due to an odd interaction. > > The code is correct an

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-12 Thread Eric W. Biederman
Andy Lutomirski writes: > On 08/05/2014 05:57 PM, Eric W. Biederman wrote: > > Sorry for catching this late. I think this fix is likely to > unnecessarily break valid userspace due to an odd interaction. The code is correct and safe (no security issues), but yes a blind remount might hit a snag

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-12 Thread Andy Lutomirski
On 08/05/2014 05:57 PM, Eric W. Biederman wrote: > > Linus, > > Please pull the for-linus branch from the git tree: > >git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > for-linus > >HEAD: 344470cac42e887e68cfb5bdfa6171baf27f1eb5 proc: Point /proc/mounts at >

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-07 Thread Theodore Ts'o
On Wed, Aug 06, 2014 at 04:06:08PM +1000, Stephen Rothwell wrote: > > Yes, that is what confused my, sorry, since that commit and the ones > following are new commits but unchanged patches. As a suggestion, in addition to trying to count the number of commits that are new, or with the same patch

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-05 Thread Eric W. Biederman
Stephen Rothwell writes: > Hi Eric, > >> As for missing cool tags shrug. The people looking at my code didn't >> feel like saying the magic words so I didn't include cool tags. > > Maybe you should push them ... these tags are not just "cool", they > give less involved people some indications of

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-05 Thread Stephen Rothwell
Hi Eric, On Tue, 05 Aug 2014 22:16:06 -0700 ebied...@xmission.com (Eric W. Biederman) wrote: > > I am not certain what your point is. I am just trying to give Linus a heads up for branches that have not had much exposure before he is asked to pull them. > There have been no commits added since

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-05 Thread Eric W. Biederman
Stephen Rothwell writes: > Hi Eric, > > On Tue, 05 Aug 2014 17:57:31 -0700 ebied...@xmission.com (Eric W. Biederman) > wrote: >> >> Please pull the for-linus branch from the git tree: >> >>git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git >> for-linus >> >>HEAD

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-08-05 Thread Stephen Rothwell
Hi Eric, On Tue, 05 Aug 2014 17:57:31 -0700 ebied...@xmission.com (Eric W. Biederman) wrote: > > Please pull the for-linus branch from the git tree: > >git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > for-linus > >HEAD: 344470cac42e887e68cfb5bdfa6171baf27f1eb

[GIT PULL] namespace updates for v3.17-rc1

2014-08-05 Thread Eric W. Biederman
Linus, Please pull the for-linus branch from the git tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus HEAD: 344470cac42e887e68cfb5bdfa6171baf27f1eb5 proc: Point /proc/mounts at /proc/thread-self/mounts instead of /proc/self/mounts This is a bunc