Re: [GIT PULL] overlayfs update for 4.18

2018-06-11 Thread Christoph Hellwig
On Mon, Jun 11, 2018 at 10:41:29AM +0200, Miklos Szeredi wrote: > Linus, would you still pull if Al's satisfied with that resolution? > I can post the fixes (just few liners) after the merge window. Please repost all changes outside overlayfs itself to -fsdevel so that we can improve them for merg

Re: [GIT PULL] overlayfs update for 4.18

2018-06-11 Thread Miklos Szeredi
On Sun, Jun 10, 2018 at 7:54 AM, Al Viro wrote: > On Fri, Jun 08, 2018 at 11:52:08PM -0700, Christoph Hellwig wrote: >> On Fri, Jun 08, 2018 at 02:13:30PM +0200, Miklos Szeredi wrote: >> > Hi Linus, >> > >> > Please pull from: >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.

Re: [GIT PULL] overlayfs update for 4.18

2018-06-10 Thread Christoph Hellwig
On Sun, Jun 10, 2018 at 06:54:38AM +0100, Al Viro wrote: > Umm... The worst of yours had been ->pre_mmap(), right? He *did* drop > that... Oh, hadn't notied that. Still odd to change a huge pull request after the end merge window.

Re: [GIT PULL] overlayfs update for 4.18

2018-06-10 Thread Christoph Hellwig
On Sat, Jun 09, 2018 at 02:42:20PM -0700, Linus Torvalds wrote: > And Christoph's copmmentary isn't really helping the situation. > Christoph, I haven't seen the NAK history, can you elaborate? Most of the bits just need a bit of refinement I think, instead of being forced through the overlayfs tr

Re: [GIT PULL] overlayfs update for 4.18

2018-06-09 Thread Al Viro
On Fri, Jun 08, 2018 at 11:52:08PM -0700, Christoph Hellwig wrote: > On Fri, Jun 08, 2018 at 02:13:30PM +0200, Miklos Szeredi wrote: > > Hi Linus, > > > > Please pull from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git > > tags/ovl-update-4.18 > > > > This contains tw

Re: [GIT PULL] overlayfs update for 4.18

2018-06-09 Thread Al Viro
On Sat, Jun 09, 2018 at 02:42:20PM -0700, Linus Torvalds wrote: > Hmm. > > So I had held off on pulling this in the hope that it would get more comments. > > I like most of the vfs-level stuff - it gets rid of some of the > hackery we had for overlayfs. > > It does add some new hackery to replac

Re: [GIT PULL] overlayfs update for 4.18

2018-06-09 Thread Linus Torvalds
Hmm. So I had held off on pulling this in the hope that it would get more comments. I like most of the vfs-level stuff - it gets rid of some of the hackery we had for overlayfs. It does add some new hackery to replace it (like the file accounting), though. And Christoph's copmmentary isn't real

Re: [GIT PULL] overlayfs update for 4.18

2018-06-08 Thread Christoph Hellwig
On Fri, Jun 08, 2018 at 02:13:30PM +0200, Miklos Szeredi wrote: > Hi Linus, > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git > tags/ovl-update-4.18 > > This contains two new features: > > 1) Stack file operations: this allows removal of several hacks

[GIT PULL] overlayfs update for 4.18

2018-06-08 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git tags/ovl-update-4.18 This contains two new features: 1) Stack file operations: this allows removal of several hacks from the VFS, proper interaction of read-only open files with copy-up, possi

Re: [GIT PULL] overlayfs update for 4.18

2018-06-01 Thread Miklos Szeredi
On Fri, Jun 1, 2018 at 6:18 PM, Randy Dunlap wrote: > On 06/01/2018 08:26 AM, Miklos Szeredi wrote: >> On Tue, May 29, 2018 at 03:21:48PM +0200, Miklos Szeredi wrote: >>> Hi Al, >>> >>> I'm sending this pull request to you instead of Linus, because a bigger than >>> usual chunk involves the VFS. >

Re: [GIT PULL] overlayfs update for 4.18

2018-06-01 Thread Randy Dunlap
On 06/01/2018 08:26 AM, Miklos Szeredi wrote: > On Tue, May 29, 2018 at 03:21:48PM +0200, Miklos Szeredi wrote: >> Hi Al, >> >> I'm sending this pull request to you instead of Linus, because a bigger than >> usual chunk involves the VFS. >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/

Re: [GIT PULL] overlayfs update for 4.18

2018-06-01 Thread Miklos Szeredi
On Tue, May 29, 2018 at 03:21:48PM +0200, Miklos Szeredi wrote: > Hi Al, > > I'm sending this pull request to you instead of Linus, because a bigger than > usual chunk involves the VFS. > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-viro > > This

Re: [GIT PULL] overlayfs update for 4.18

2018-05-30 Thread Dave Chinner
On Wed, May 30, 2018 at 10:36:46AM +0200, Miklos Szeredi wrote: > On Tue, May 29, 2018 at 4:12 PM, Miklos Szeredi wrote: > > On Tue, May 29, 2018 at 3:59 PM, Christoph Hellwig > > wrote: > > >>> vfs: export vfs_dedupe_file_range_one() to modules > >> > >> Please use EXPORT_SYMBOL_GPL for

Re: [GIT PULL] overlayfs update for 4.18

2018-05-30 Thread Miklos Szeredi
On Tue, May 29, 2018 at 4:12 PM, Miklos Szeredi wrote: > On Tue, May 29, 2018 at 3:59 PM, Christoph Hellwig wrote: >>> vfs: export vfs_dedupe_file_range_one() to modules >> >> Please use EXPORT_SYMBOL_GPL for all these crazy low-level exports. I'd argue with the "crazy" part. This should

Re: [GIT PULL] overlayfs update for 4.18

2018-05-29 Thread Miklos Szeredi
On Tue, May 29, 2018 at 3:59 PM, Christoph Hellwig wrote: >> vfs: add f_op->pre_mmap() > > We've been through these pre-mmap games a few times, and always rejected > them, why is this any different? Don't know what the other cases were. Overlayfs case is completely state free. It just doe

Re: [GIT PULL] overlayfs update for 4.18

2018-05-29 Thread Christoph Hellwig
> vfs: add f_op->pre_mmap() We've been through these pre-mmap games a few times, and always rejected them, why is this any different? > vfs: export vfs_dedupe_file_range_one() to modules Please use EXPORT_SYMBOL_GPL for all these crazy low-level exports. To be homest I'd really like

[GIT PULL] overlayfs update for 4.18

2018-05-29 Thread Miklos Szeredi
Hi Al, I'm sending this pull request to you instead of Linus, because a bigger than usual chunk involves the VFS. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-viro This update contains the following: - Deal with vfs_mkdir() not instantiating dentry.