Re: [GIT PULL] sound updates for 4.21

2019-01-04 Thread Pierre-Louis Bossart
On 1/4/19 6:34 PM, Azat Khuzhin wrote: This is unfortunately a known issue with this driver, Takashi and I had a couple of email threads on this. Even without errors removing the module doesn't seem to release all resources. I don't like this at all, and for the Sound Open Firmware (SOF) driver

Re: [GIT PULL] sound updates for 4.21

2019-01-04 Thread Azat Khuzhin
> This is unfortunately a known issue with this driver, Takashi and I had > a couple of email threads on this. Even without errors removing the > module doesn't seem to release all resources. I don't like this at all, > and for the Sound Open Firmware (SOF) driver I mandated module > load-unload as

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Hans de Goede
Hi, On 12/31/18 9:10 PM, Pierre-Louis Bossart wrote: On 12/31/18 12:15 PM, Takashi Iwai wrote: On Mon, 31 Dec 2018 11:24:41 +0100, Pierre-Louis Bossart wrote: On 12/31/18 2:11 AM, Takashi Iwai wrote: On Mon, 31 Dec 2018 00:17:58 +0100, Pierre-Louis Bossart wrote: BTW, one thing I'd really

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Pierre-Louis Bossart
On 12/31/18 12:15 PM, Takashi Iwai wrote: On Mon, 31 Dec 2018 11:24:41 +0100, Pierre-Louis Bossart wrote: On 12/31/18 2:11 AM, Takashi Iwai wrote: On Mon, 31 Dec 2018 00:17:58 +0100, Pierre-Louis Bossart wrote: BTW, one thing I'd really like to avoid is to rearrange the probe procedure of t

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Takashi Iwai
On Mon, 31 Dec 2018 11:24:41 +0100, Pierre-Louis Bossart wrote: > > > On 12/31/18 2:11 AM, Takashi Iwai wrote: > > On Mon, 31 Dec 2018 00:17:58 +0100, > > Pierre-Louis Bossart wrote: > >>> BTW, one thing I'd really like to avoid is to rearrange the probe > >>> procedure of the legacy HDA driver (

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Pierre-Louis Bossart
On 12/31/18 7:43 AM, Azat Khuzhin wrote: +/* CFL and later models, preferring ASoC when DSP is available */ +#define IS_CFL_PLUS(pci)\ + ((pci)->vendor == 0x8086 && \ +((pci)->device == 0xa348 || \ + (pci)->device == 0x9dc8 || \ + (pci)->device == 0x34

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Azat Khuzhin
> +/* CFL and later models, preferring ASoC when DSP is available */ > +#define IS_CFL_PLUS(pci)\ > + ((pci)->vendor == 0x8086 && \ > +((pci)->device == 0xa348 || \ > + (pci)->device == 0x9dc8 || \ > + (pci)->device == 0x34c8)) > + > static char *driver_s

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Pierre-Louis Bossart
On 12/31/18 2:11 AM, Takashi Iwai wrote: On Mon, 31 Dec 2018 00:17:58 +0100, Pierre-Louis Bossart wrote: BTW, one thing I'd really like to avoid is to rearrange the probe procedure of the legacy HDA driver (so that we can get codec_mask during pci probe() call). The async probe is the result

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Takashi Iwai
On Mon, 31 Dec 2018 00:17:58 +0100, Pierre-Louis Bossart wrote: > > > BTW, one thing I'd really like to avoid is to rearrange the probe > > procedure of the legacy HDA driver (so that we can get codec_mask > > during pci probe() call). The async probe is the result of the many > > struggles with

Re: [GIT PULL] sound updates for 4.21

2018-12-30 Thread Pierre-Louis Bossart
On 12/30/18 6:19 PM, Linus Torvalds wrote: On Sun, Dec 30, 2018 at 3:18 PM Pierre-Louis Bossart wrote: The KabyLake Dell XPS13 was initially used for the ASoC driver for HDaudio, so there is no known hardware-related reason why this problem happens. Mine isn't the Kabylake one, it's the olde

Re: [GIT PULL] sound updates for 4.21

2018-12-30 Thread Linus Torvalds
On Sun, Dec 30, 2018 at 3:18 PM Pierre-Louis Bossart wrote: > > The KabyLake Dell XPS13 was initially used for the ASoC driver for > HDaudio, so there is no known hardware-related reason why this problem > happens. Mine isn't the Kabylake one, it's the older XPS13 9350 (2015 - Skylake) one. > Th

Re: [GIT PULL] sound updates for 4.21

2018-12-30 Thread Takashi Iwai
On Fri, 28 Dec 2018 20:04:48 +0100, Linus Torvalds wrote: > > On Fri, Dec 28, 2018 at 9:07 AM Takashi Iwai wrote: > > > > 1) Whether ASoC driver cannot work with these Dell machines at all > > I'm willing to test patches. > > Right now, the reason it fails to even load is that "codec_mask" is 0

Re: [GIT PULL] sound updates for 4.21

2018-12-28 Thread Linus Torvalds
On Fri, Dec 28, 2018 at 9:07 AM Takashi Iwai wrote: > > 1) Whether ASoC driver cannot work with these Dell machines at all I'm willing to test patches. Right now, the reason it fails to even load is that "codec_mask" is 0x0001. And the skl_hda_dsp_generic.c code requires // This will b

Re: [GIT PULL] sound updates for 4.21

2018-12-28 Thread Takashi Iwai
On Fri, 28 Dec 2018 13:43:03 +0100, Ingo Molnar wrote: > > > * Linus Torvalds wrote: > > > On Thu, Dec 20, 2018 at 7:38 AM Takashi Iwai wrote: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > > tags/sound-4.21-rc1 > > > > Hmm. > > > > It turns out that commit

Re: [GIT PULL] sound updates for 4.21

2018-12-28 Thread Ingo Molnar
* Linus Torvalds wrote: > On Thu, Dec 20, 2018 at 7:38 AM Takashi Iwai wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > tags/sound-4.21-rc1 > > Hmm. > > It turns out that commit c337104b1a16 ("ALSA: HD-Audio: SKL+: abort > probe if DSP is present and Skylak

Re: [GIT PULL] sound updates for 4.21

2018-12-26 Thread Linus Torvalds
On Thu, Dec 20, 2018 at 7:38 AM Takashi Iwai wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > tags/sound-4.21-rc1 Hmm. It turns out that commit c337104b1a16 ("ALSA: HD-Audio: SKL+: abort probe if DSP is present and Skylake driver selected") causes my laptop (XPS13 93

Re: [GIT PULL] sound updates for 4.21

2018-12-25 Thread pr-tracker-bot
The pull request you sent on Thu, 20 Dec 2018 16:38:30 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > tags/sound-4.21-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8e61e7b5c4de2bea534438bd7a008accd85492b0 Thank you! -- Deet-doot-dot,

[GIT PULL] sound updates for 4.21

2018-12-20 Thread Takashi Iwai
Linus, please pull sound updates for v4.21 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-4.21-rc1 The topmost commit is d82b51c855a20eb456ac09f2f40ea98312373263 sound updates for 4.21 There ar