Re: [GIT PULL] uprobes: pre-filtering

2013-01-28 Thread Oleg Nesterov
On 01/28, Srikar Dronamraju wrote: > > * Oleg Nesterov [2013-01-25 17:17:28]: > > > This is what I am going to (try to) do, but I am not sure if this makes > > sense... > > > > For the start, can't we teach 'uprobe_events' file to accept, say, > > > > 'p file:0x1234 pid=1 other-opts' > > > I

Re: [GIT PULL] uprobes: pre-filtering

2013-01-28 Thread Srikar Dronamraju
* Oleg Nesterov [2013-01-25 17:17:28]: > On 01/25, Ingo Molnar wrote: > > > > * Srikar Dronamraju wrote: > > > > > The other alternative is to extend the current abi and pass > > > the prefilter option. Should we extend the abi for userspace > > > tracing is obviously debatable. > > > > That's

Re: [GIT PULL] uprobes: pre-filtering

2013-01-28 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-01-25 17:17:28]: On 01/25, Ingo Molnar wrote: * Srikar Dronamraju sri...@linux.vnet.ibm.com wrote: The other alternative is to extend the current abi and pass the prefilter option. Should we extend the abi for userspace tracing is obviously

Re: [GIT PULL] uprobes: pre-filtering

2013-01-28 Thread Oleg Nesterov
On 01/28, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2013-01-25 17:17:28]: This is what I am going to (try to) do, but I am not sure if this makes sense... For the start, can't we teach 'uprobe_events' file to accept, say, 'p file:0x1234 pid=1 other-opts' I

Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Oleg Nesterov
On 01/25, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > On 01/25, Ingo Molnar wrote: > > > > > > * Srikar Dronamraju wrote: > > > > > > > The other alternative is to extend the current abi and pass > > > > the prefilter option. Should we extend the abi for userspace > > > > tracing is

Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Ingo Molnar
* Oleg Nesterov wrote: > On 01/25, Ingo Molnar wrote: > > > > * Srikar Dronamraju wrote: > > > > > The other alternative is to extend the current abi and pass > > > the prefilter option. Should we extend the abi for userspace > > > tracing is obviously debatable. > > > > That's the obvious

Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Oleg Nesterov
On 01/25, Ingo Molnar wrote: > > * Srikar Dronamraju wrote: > > > The other alternative is to extend the current abi and pass > > the prefilter option. Should we extend the abi for userspace > > tracing is obviously debatable. > > That's the obvious path to go - why add something to the kernel >

Re: Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Masami Hiramatsu
(2013/01/25 15:46), Srikar Dronamraju wrote: > The other alternative is to extend the current abi and pass the > prefilter option. Should we extend the abi for userspace tracing is > obviously debatable. Hmm, afaik, ftrace has set_ftrace_pid and perf record also has --pid option. I think you can

Re: Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Masami Hiramatsu
(2013/01/25 15:46), Srikar Dronamraju wrote: The other alternative is to extend the current abi and pass the prefilter option. Should we extend the abi for userspace tracing is obviously debatable. Hmm, afaik, ftrace has set_ftrace_pid and perf record also has --pid option. I think you can

Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Oleg Nesterov
On 01/25, Ingo Molnar wrote: * Srikar Dronamraju sri...@linux.vnet.ibm.com wrote: The other alternative is to extend the current abi and pass the prefilter option. Should we extend the abi for userspace tracing is obviously debatable. That's the obvious path to go - why add something to

Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Ingo Molnar
* Oleg Nesterov o...@redhat.com wrote: On 01/25, Ingo Molnar wrote: * Srikar Dronamraju sri...@linux.vnet.ibm.com wrote: The other alternative is to extend the current abi and pass the prefilter option. Should we extend the abi for userspace tracing is obviously debatable.

Re: [GIT PULL] uprobes: pre-filtering

2013-01-25 Thread Oleg Nesterov
On 01/25, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: On 01/25, Ingo Molnar wrote: * Srikar Dronamraju sri...@linux.vnet.ibm.com wrote: The other alternative is to extend the current abi and pass the prefilter option. Should we extend the abi for userspace

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Srikar Dronamraju wrote: > The other alternative is to extend the current abi and pass > the prefilter option. Should we extend the abi for userspace > tracing is obviously debatable. That's the obvious path to go - why add something to the kernel if user-space cannot make use of it?

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Srikar Dronamraju
* Oleg Nesterov [2013-01-24 18:06:12]: > On 01/24, Ingo Molnar wrote: > > > > * Oleg Nesterov wrote: > > > > > Unfortunately, currently there is no in-kernel user of > > > pre-filtering. > > > > > > I'll try to implement the pid-base filtering at least for > > > tracing/uprobe_events, but this

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Oleg Nesterov
On 01/24, Josh Stone wrote: > > On 01/24/2013 07:40 AM, Oleg Nesterov wrote: > > I'll try to implement the pid-base filtering at least for > > tracing/uprobe_events, but this needs a time. Not only I am not familiar > > with this code, I am not sure how this interface should actually look. > > And

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Oleg Nesterov
On 01/24, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > Unfortunately, currently there is no in-kernel user of > > pre-filtering. > > > > I'll try to implement the pid-base filtering at least for > > tracing/uprobe_events, but this needs a time. Not only I am > > not familiar with this

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Josh Stone
On 01/24/2013 07:40 AM, Oleg Nesterov wrote: > I'll try to implement the pid-base filtering at least for > tracing/uprobe_events, but this needs a time. Not only I am not familiar > with this code, I am not sure how this interface should actually look. > And I agree, perf should be able to use it

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Oleg Nesterov wrote: > On 01/24, Ingo Molnar wrote: > > > > * Oleg Nesterov wrote: > > > > > Ingo, please pull from > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core > > > > > > Mostly pre-filtering. This needs more work and perhaps more functionality. > > >

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Oleg Nesterov
On 01/24, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > Ingo, please pull from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core > > > > Mostly pre-filtering. This needs more work and perhaps more functionality. > > In particular, perhaps dup_mmap() should

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Anton Arapov
Hello Ingo, On Thu, Jan 24, 2013 at 11:17 PM, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > >> Ingo, please pull from >> >> git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core >> >> Mostly pre-filtering. This needs more work and perhaps more functionality. >> In particular,

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Anton Arapov wrote: > Hello Ingo, > > On Thu, Jan 24, 2013 at 11:17 PM, Ingo Molnar wrote: > > > > * Oleg Nesterov wrote: > > > >> Ingo, please pull from > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core > >> > >> Mostly pre-filtering. This needs more work

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Oleg Nesterov wrote: > Ingo, please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core > > Mostly pre-filtering. This needs more work and perhaps more functionality. > In particular, perhaps dup_mmap() should remove the unwanted breakpoints. > And we can

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Oleg Nesterov o...@redhat.com wrote: Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering. This needs more work and perhaps more functionality. In particular, perhaps dup_mmap() should remove the unwanted breakpoints. And

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Anton Arapov an...@redhat.com wrote: Hello Ingo, On Thu, Jan 24, 2013 at 11:17 PM, Ingo Molnar mi...@kernel.org wrote: * Oleg Nesterov o...@redhat.com wrote: Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering.

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Anton Arapov
Hello Ingo, On Thu, Jan 24, 2013 at 11:17 PM, Ingo Molnar mi...@kernel.org wrote: * Oleg Nesterov o...@redhat.com wrote: Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering. This needs more work and perhaps more functionality.

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Oleg Nesterov
On 01/24, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering. This needs more work and perhaps more functionality. In particular, perhaps dup_mmap() should

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Oleg Nesterov o...@redhat.com wrote: On 01/24, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering. This needs more work and perhaps more

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Josh Stone
On 01/24/2013 07:40 AM, Oleg Nesterov wrote: I'll try to implement the pid-base filtering at least for tracing/uprobe_events, but this needs a time. Not only I am not familiar with this code, I am not sure how this interface should actually look. And I agree, perf should be able to use it

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Oleg Nesterov
On 01/24, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: Unfortunately, currently there is no in-kernel user of pre-filtering. I'll try to implement the pid-base filtering at least for tracing/uprobe_events, but this needs a time. Not only I am not familiar with this

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Oleg Nesterov
On 01/24, Josh Stone wrote: On 01/24/2013 07:40 AM, Oleg Nesterov wrote: I'll try to implement the pid-base filtering at least for tracing/uprobe_events, but this needs a time. Not only I am not familiar with this code, I am not sure how this interface should actually look. And I agree,

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-01-24 18:06:12]: On 01/24, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: Unfortunately, currently there is no in-kernel user of pre-filtering. I'll try to implement the pid-base filtering at least for tracing/uprobe_events,

Re: [GIT PULL] uprobes: pre-filtering

2013-01-24 Thread Ingo Molnar
* Srikar Dronamraju sri...@linux.vnet.ibm.com wrote: The other alternative is to extend the current abi and pass the prefilter option. Should we extend the abi for userspace tracing is obviously debatable. That's the obvious path to go - why add something to the kernel if user-space

[GIT PULL] uprobes: pre-filtering

2013-01-13 Thread Oleg Nesterov
Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering. This needs more work and perhaps more functionality. In particular, perhaps dup_mmap() should remove the unwanted breakpoints. And we can add more ->filter() hooks to, say, speedup

[GIT PULL] uprobes: pre-filtering

2013-01-13 Thread Oleg Nesterov
Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core Mostly pre-filtering. This needs more work and perhaps more functionality. In particular, perhaps dup_mmap() should remove the unwanted breakpoints. And we can add more -filter() hooks to, say, speedup