Re: [GIT PULL] uprobes: preparations for arm port

2013-11-07 Thread Oleg Nesterov
On 11/07, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > and we need to cleanup copy_insn() > > first. Heh. I never read it carefully, I always knew it should be cleanuped. But when I looked at it now I realized that it is very wrong, and it is very easy to crash the kernel (fortunately onl

Re: [GIT PULL] uprobes: preparations for arm port

2013-11-07 Thread Ingo Molnar
* Oleg Nesterov wrote: > On 11/07, Ingo Molnar wrote: > > > > * Oleg Nesterov wrote: > > > > > --- a/arch/powerpc/include/asm/uprobes.h > > > +++ b/arch/powerpc/include/asm/uprobes.h > > > @@ -37,6 +37,7 @@ typedef ppc_opcode_t uprobe_opcode_t; > > > struct arch_uprobe { > > > union { > > >

Re: [GIT PULL] uprobes: preparations for arm port

2013-11-07 Thread Oleg Nesterov
On 11/07, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > --- a/arch/powerpc/include/asm/uprobes.h > > +++ b/arch/powerpc/include/asm/uprobes.h > > @@ -37,6 +37,7 @@ typedef ppc_opcode_t uprobe_opcode_t; > > struct arch_uprobe { > > union { > > u8 insn[MAX_UINSN_BYTES]; >

Re: [GIT PULL] uprobes: preparations for arm port

2013-11-06 Thread Ingo Molnar
* Oleg Nesterov wrote: > --- a/arch/powerpc/include/asm/uprobes.h > +++ b/arch/powerpc/include/asm/uprobes.h > @@ -37,6 +37,7 @@ typedef ppc_opcode_t uprobe_opcode_t; > struct arch_uprobe { > union { > u8 insn[MAX_UINSN_BYTES]; > + u8 ixol[MAX_UINSN_BYT

Re: [GIT PULL] uprobes: preparations for arm port

2013-11-06 Thread Ingo Molnar
* Oleg Nesterov wrote: > Ingo, please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core > > > I have also attached the cumulative diff below. As you can see, > the changes are really simple and there are no functional changes. > > However I think it makes s

Re: [GIT PULL] uprobes: preparations for arm port

2013-11-06 Thread Srikar Dronamraju
* Oleg Nesterov [2013-11-06 20:19:13]: > Ingo, please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core > > > I have also attached the cumulative diff below. As you can see, > the changes are really simple and there are no functional changes. > > However I t

[GIT PULL] uprobes: preparations for arm port

2013-11-06 Thread Oleg Nesterov
Ingo, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core I have also attached the cumulative diff below. As you can see, the changes are really simple and there are no functional changes. However I think it makes sense to merge this now, this way the upcomin