Re: [GIT PULL] x86/asm updates for v5.10

2020-10-13 Thread pr-tracker-bot
The pull request you sent on Mon, 12 Oct 2020 13:05:57 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > tags/x86_asm_for_v5.10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/029f56db6ac248769f2c260bfaf3c3c0e23e904c Thank you! -- Deet-doot-dot,

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-13 Thread Uros Bizjak
On Mon, Oct 12, 2020 at 10:57 PM Linus Torvalds wrote: > > On Mon, Oct 12, 2020 at 1:22 PM Uros Bizjak wrote: > > > > No, this fact is not documented, although there are close to zero > > chances it will ever change. High registers are independent from their > > 8bit lowparts, but they still

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 1:22 PM Uros Bizjak wrote: > > No, this fact is not documented, although there are close to zero > chances it will ever change. High registers are independent from their > 8bit lowparts, but they still clobber corresponding 16bit, 32bit and > 64bit representations. I guess

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Arvind Sankar
On Mon, Oct 12, 2020 at 08:55:47PM +0200, Borislav Petkov wrote: > On Mon, Oct 12, 2020 at 08:41:32PM +0200, Uros Bizjak wrote: > > On Mon, Oct 12, 2020 at 8:11 PM Linus Torvalds < > > torva...@linux-foundation.org> wrote: > > > > > On Mon, Oct 12, 2020 at 4:06 AM Borislav Petkov wrote: > > > >

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Arvind Sankar
On Mon, Oct 12, 2020 at 11:11:35AM -0700, Linus Torvalds wrote: > On Mon, Oct 12, 2020 at 4:06 AM Borislav Petkov wrote: > > > > * Use XORL instead of XORQ to avoid a REX prefix and save some bytes in > > the .fixup section, by Uros Bizjak. > > I think this one is actually buggy. > > For the

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 12:24 PM Uros Bizjak wrote: > > I don't think it is even possible to write to a part of a register in the > asm. An example: But this example is the *reverse* of what I worry about. I worry about the asm writing not to a "part" of a register, but to *more* than we told

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 11:56 AM Linus Torvalds wrote: > > I also find that clang generates code that uses the high byte > registers, although again, that's not from any knowledge of clang > internals, and just by looking at my kernel image disassembly. > > So yes, it _may_ all be just peepholes,

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Borislav Petkov
+ linux-toolcha...@vger.kernel.org for clang folks... On Mon, Oct 12, 2020 at 11:56:45AM -0700, Linus Torvalds wrote: > On Mon, Oct 12, 2020 at 11:41 AM Uros Bizjak wrote: > > > > GCC does not distinguish between %ah and %al and it is not possible to pass > > "%ah" to the assembly. To access

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 11:41 AM Uros Bizjak wrote: > > GCC does not distinguish between %ah and %al and it is not possible to pass > "%ah" to the assembly. To access the high part of the %ax register, %h > modifier has to be used in the assembly template. Do you know whether that's true for

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 08:41:32PM +0200, Uros Bizjak wrote: > On Mon, Oct 12, 2020 at 8:11 PM Linus Torvalds < > torva...@linux-foundation.org> wrote: > > > On Mon, Oct 12, 2020 at 4:06 AM Borislav Petkov wrote: > > > > > > * Use XORL instead of XORQ to avoid a REX prefix and save some bytes in

Re: [GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 4:06 AM Borislav Petkov wrote: > > * Use XORL instead of XORQ to avoid a REX prefix and save some bytes in > the .fixup section, by Uros Bizjak. I think this one is actually buggy. For the 1-byte case, it does this: __get_user_asm(x_u8__, ptr, retval, "b", "=q");

[GIT PULL] x86/asm updates for v5.10

2020-10-12 Thread Borislav Petkov
Hi Linus, please pull two asm wrapper fixes. Thx. --- The following changes since commit f75aef392f869018f78cfedf3c320a6b3fcfda6b: Linux 5.9-rc3 (2020-08-30 16:01:54 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git