Re: [GIT PULL] x86/platform updates for v5.10

2020-10-13 Thread Mike Travis
On 10/13/2020 6:37 AM, Mike Travis wrote: On 10/13/2020 6:29 AM, Borislav Petkov wrote: On Tue, Oct 13, 2020 at 05:33:37AM -0700, Mike Travis wrote: I'm working on the correct code now, and I have UV4 & UV4A machine time starting at 7am (PDT) to test it.  The UV5 simulator does not yet em

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-13 Thread Mike Travis
On 10/13/2020 6:29 AM, Borislav Petkov wrote: On Tue, Oct 13, 2020 at 05:33:37AM -0700, Mike Travis wrote: I'm working on the correct code now, and I have UV4 & UV4A machine time starting at 7am (PDT) to test it. The UV5 simulator does not yet emulate console initiated NMI from the BMC. Ok

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-13 Thread Borislav Petkov
On Tue, Oct 13, 2020 at 05:33:37AM -0700, Mike Travis wrote: > I'm working on the correct code now, and I have UV4 & UV4A machine time > starting at 7am (PDT) to test it. The UV5 simulator does not yet emulate > console initiated NMI from the BMC. Ok, let me put it another way: is this simple fix

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-13 Thread Mike Travis
On 10/13/2020 4:11 AM, Borislav Petkov wrote: On Mon, Oct 12, 2020 at 02:58:07PM -0700, Mike Travis wrote: I was in the process of tracing it through and perhaps it does need a bit more analysis to be correct. What does it mean to send a patch to fix the compile error, just remove it? Yes,

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-13 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 02:58:07PM -0700, Mike Travis wrote: > I was in the process of tracing it through and perhaps it does need a bit > more analysis to be correct. What does it mean to send a patch to fix the > compile error, just remove it? Yes, to remove it for now as it is unused currently

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Mike Travis
On 10/12/2020 2:56 PM, Borislav Petkov wrote: On Mon, Oct 12, 2020 at 02:46:10PM -0700, Linus Torvalds wrote: At least "git grep" only shows two assignments to it. Of course, that would miss any cases that play games with preprocessor token pasting etc, so it's not entirely meaningful, but i

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Mike Travis
On 10/12/2020 2:42 PM, Mike Travis wrote: On 10/12/2020 2:27 PM, Borislav Petkov wrote: On Mon, Oct 12, 2020 at 02:15:55PM -0700, Mike Travis wrote: Of course, it also looks like that 'uvh_nmi_mmrx_mask' thing is a write-only variable so it doesn't matter, but can we _please_ get this code

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 02:46:10PM -0700, Linus Torvalds wrote: > At least "git grep" only shows two assignments to it. > > Of course, that would miss any cases that play games with preprocessor > token pasting etc, so it's not entirely meaningful, but it's certainly > a hint.. >From a quick star

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 2:42 PM Mike Travis wrote: > > It should have been an unsigned long instead of an int as Linus > suggested. I'm not sure it's a write only variable as I think the mask > is used to check if the interrupt occurred (I'll have to look closer). At least "git grep" only shows

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Mike Travis
On 10/12/2020 2:27 PM, Borislav Petkov wrote: On Mon, Oct 12, 2020 at 02:15:55PM -0700, Mike Travis wrote: Of course, it also looks like that 'uvh_nmi_mmrx_mask' thing is a write-only variable so it doesn't matter, but can we _please_ get this code fixed ASAP? Yes, I'll look at it right now

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 02:15:55PM -0700, Mike Travis wrote: > > Of course, it also looks like that 'uvh_nmi_mmrx_mask' thing is a > > write-only variable so it doesn't matter, but can we _please_ get this > > code fixed ASAP? > > Yes, I'll look at it right now. Thanks. As this variable is write

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Mike Travis
On 10/12/2020 2:10 PM, Linus Torvalds wrote: On Mon, Oct 12, 2020 at 3:10 AM Borislav Petkov wrote: please pull the x86/platform queue. Hmm. I didn't immediately notice this new warning, because it only happens with the clang build that I don't do in between every pull. But this pull cau

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Linus Torvalds
On Mon, Oct 12, 2020 at 3:10 AM Borislav Petkov wrote: > > please pull the x86/platform queue. Hmm. I didn't immediately notice this new warning, because it only happens with the clang build that I don't do in between every pull. But this pull causes new warnings from clang: arch/x86/platform/u

Re: [GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread pr-tracker-bot
The pull request you sent on Mon, 12 Oct 2020 12:10:12 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > tags/x86_platform_for_v5.10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8b6591fd0ac8b7e8b2873703bc24b71a6f3d2d3e Thank you! -- Deet-doot-d

[GIT PULL] x86/platform updates for v5.10

2020-10-12 Thread Borislav Petkov
Hi Linus, please pull the x86/platform queue. Thx. --- The following changes since commit a1b8638ba1320e6684aa98233c15255eb803fac7: Linux 5.9-rc7 (2020-09-27 14:38:10 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tags/x86_platfo