Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread Linus Torvalds
On Thu, Sep 19, 2019 at 2:49 AM David Howells wrote: > > Actually, waiting for all outstanding fixes to get merged and then rebasing > might not be the right thing here. The problem is that there are fixes in > both trees: afs fixes go directly into yours whereas rxrpc fixes go via > networking a

Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread Jeffrey E Altman
On 9/19/2019 9:15 AM, Matthew Wilcox wrote: > Why is it organised this way? I mean, yes, technically, rxrpc is a > generic layer-6 protocol that any blah blah blah, but in practice no > other user has come up in the last 37 years, so why bother pretending > one is going to? Just git mv net/rxrpc

Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread David Howells
Matthew Wilcox wrote: > Why is it organised this way? I mean, yes, technically, rxrpc is a > generic layer-6 protocol that any blah blah blah, but in practice no > other user has come up in the last 37 years, so why bother pretending > one is going to? Just git mv net/rxrpc fs/afs/ and merge ev

Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread Ilya Dryomov
On Thu, Sep 19, 2019 at 3:55 PM Matthew Wilcox wrote: > > On Thu, Sep 19, 2019 at 10:49:22AM +0100, David Howells wrote: > > David Howells wrote: > > > > > > However, I was close to unpulling it again. It has a merge commit with > > > > this merge message: > > > > > > > > Merge remote-trackin

Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread Matthew Wilcox
On Thu, Sep 19, 2019 at 10:49:22AM +0100, David Howells wrote: > David Howells wrote: > > > > However, I was close to unpulling it again. It has a merge commit with > > > this merge message: > > > > > > Merge remote-tracking branch 'net/master' into afs-next > > > > > > and that simply is n

Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread David Howells
David Howells wrote: > > However, I was close to unpulling it again. It has a merge commit with > > this merge message: > > > > Merge remote-tracking branch 'net/master' into afs-next > > > > and that simply is not acceptable. > > Apologies - I meant to rebase that away. There was a bug f

Re: [GIT PULL afs: Development for 5.4

2019-09-18 Thread David Howells
Linus Torvalds wrote: > However, I was close to unpulling it again. It has a merge commit with > this merge message: > > Merge remote-tracking branch 'net/master' into afs-next > > and that simply is not acceptable. Apologies - I meant to rebase that away. There was a bug fix to rxrpc in

Re: [GIT PULL afs: Development for 5.4

2019-09-18 Thread pr-tracker-bot
The pull request you sent on Mon, 16 Sep 2019 12:09:27 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-next-20190915 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0bb73e42f027db64054fff4c3b3203c1626b9dc1 Thank you! -- Deet-d

Re: [GIT PULL afs: Development for 5.4

2019-09-18 Thread Linus Torvalds
On Wed, Sep 18, 2019 at 5:22 PM Linus Torvalds wrote: > > Commit messages need to explain the commit. The same is even more true > of merges! Side note: that wasn't actually the only problem with that merge. The other problem was that neither of the merge bases made any sense what-so-ever. Neith

Re: [GIT PULL afs: Development for 5.4

2019-09-18 Thread Linus Torvalds
On Mon, Sep 16, 2019 at 4:09 AM David Howells wrote: > > Here's a set of patches for AFS. The first three are trivial, deleting > unused symbols and rolling out a wrapper function. Pulled. However, I was close to unpulling it again. It has a merge commit with this merge message: Merge remo

[GIT PULL afs: Development for 5.4

2019-09-16 Thread David Howells
Hi Linus, Here's a set of patches for AFS. The first three are trivial, deleting unused symbols and rolling out a wrapper function. The fourth and fifth patches make use of the previously added RCU-safe request_key facility to allow afs_permission() and afs_d_revalidate() to attempt to operate w