Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Arjan van de Ven
On Tue, 2007-02-13 at 07:27 +, Jan Beulich wrote: > >>> Christoph Hellwig <[EMAIL PROTECTED]> 12.02.07 18:12 >>> > >On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote: > >> > >> As the topic says - the goal is to support Xen. But yes, I was afraid > >> someone would > >> claim this

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Jan Beulich
>>> Christoph Hellwig <[EMAIL PROTECTED]> 12.02.07 18:12 >>> >On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote: >> >> As the topic says - the goal is to support Xen. But yes, I was afraid >> someone would >> claim this make the code look ugly. And no, I currently don't have ideas to

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Christoph Hellwig
On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote: > > As the topic says - the goal is to support Xen. But yes, I was afraid someone > would > claim this make the code look ugly. And no, I currently don't have ideas to > address > any of your comments without breaking functionality on

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Muli Ben-Yehuda
On Mon, Feb 12, 2007 at 09:14:25AM +0100, Arjan van de Ven wrote: > Xen the linux guest > or > Xen the hypervisor? > > if it's the later, why on earth would we want to uglyfy linux for it? > (arguably it holds in the former case as well) Xen the hypervisor (i.e., dom0). Cheers, Muli - To

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Jan Beulich
>> > If Jan actually had a goal with that except making the code utterly >> > unreadable he should try again with small patches that are well >> > explained and do one thing at a at time. (And cane be reviewed an >> > improved on if needed. >> >> As the topic says - the goal is to support Xen.

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Arjan van de Ven
On Mon, 2007-02-12 at 07:30 +, Jan Beulich wrote: > On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: > > On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: > > > [IA64] swiotlb abstraction (e.g. for Xen) > > > &

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Arjan van de Ven
On Mon, 2007-02-12 at 07:30 +, Jan Beulich wrote: On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: [IA64] swiotlb abstraction (e.g. for Xen) Add abstraction so that the file

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Muli Ben-Yehuda
On Mon, Feb 12, 2007 at 09:14:25AM +0100, Arjan van de Ven wrote: Xen the linux guest or Xen the hypervisor? if it's the later, why on earth would we want to uglyfy linux for it? (arguably it holds in the former case as well) Xen the hypervisor (i.e., dom0). Cheers, Muli - To unsubscribe

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Jan Beulich
If Jan actually had a goal with that except making the code utterly unreadable he should try again with small patches that are well explained and do one thing at a at time. (And cane be reviewed an improved on if needed. As the topic says - the goal is to support Xen. Xen the linux

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Christoph Hellwig
On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote: As the topic says - the goal is to support Xen. But yes, I was afraid someone would claim this make the code look ugly. And no, I currently don't have ideas to address any of your comments without breaking functionality on

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Jan Beulich
Christoph Hellwig [EMAIL PROTECTED] 12.02.07 18:12 On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote: As the topic says - the goal is to support Xen. But yes, I was afraid someone would claim this make the code look ugly. And no, I currently don't have ideas to address any of

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-12 Thread Arjan van de Ven
On Tue, 2007-02-13 at 07:27 +, Jan Beulich wrote: Christoph Hellwig [EMAIL PROTECTED] 12.02.07 18:12 On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote: As the topic says - the goal is to support Xen. But yes, I was afraid someone would claim this make the code look

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-11 Thread Jan Beulich
On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: > On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: > > [IA64] swiotlb abstraction (e.g. for Xen) > > > > Add abstraction so that the file can be used by environments

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-11 Thread Jan Beulich
On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: [IA64] swiotlb abstraction (e.g. for Xen) Add abstraction so that the file can be used by environments other than IA64

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-10 Thread Christoph Hellwig
sorry, this should of course go to the people to blame aswell :) On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: > On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: > > [IA64] swiotlb abstraction (e.g. for Xen) > > > >

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-10 Thread Christoph Hellwig
sorry, this should of course go to the people to blame aswell :) On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: [IA64] swiotlb abstraction (e.g. for Xen) Add abstraction so

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-07 Thread Christoph Hellwig
On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: > [IA64] swiotlb abstraction (e.g. for Xen) > > Add abstraction so that the file can be used by environments other than > IA64 > and EM64T, namely for Xen. Tony, this code is more than

Re: [IA64] swiotlb abstraction (e.g. for Xen)

2007-02-07 Thread Christoph Hellwig
On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote: [IA64] swiotlb abstraction (e.g. for Xen) Add abstraction so that the file can be used by environments other than IA64 and EM64T, namely for Xen. Tony, this code is more than ugly, and even further