On Tue, 20 Feb 2001, Vojtech Pavlik wrote:
> On Tue, Feb 20, 2001 at 05:45:52PM +, Hugh Dickins wrote:
> > > > byte eighty_ninty_three (ide_drive_t *drive)
> > > > {
> > > > return ((byte) ((HWIF(drive)->udma_four) &&
> > > > #ifndef CONFIG_IDEDMA_IVB
> > > >
On Tue, Feb 20, 2001 at 05:45:52PM +, Hugh Dickins wrote:
> >
> > > from drivers/ide/ide-features.c:
> > >
> > > /*
> > > * All hosts that use the 80c ribbon mus use!
> > > */
> > > byte eighty_ninty_three (ide_drive_t *drive)
> > > {
> > > return ((byte)
On Mon, 19 Feb 2001, Andre Hedrick wrote:
> On Mon, 19 Feb 2001, Pozsar Balazs wrote:
>
> > from drivers/ide/ide-features.c:
> >
> > /*
> > * All hosts that use the 80c ribbon mus use!
> > */
> > byte eighty_ninty_three (ide_drive_t *drive)
> > {
> > return ((byte)
"Pozsar Balazs wrote:"
> from drivers/ide/ide-features.c:
>
> /*
> * All hosts that use the 80c ribbon mus use!
> */
> byte eighty_ninty_three (ide_drive_t *drive)
> {
> return ((byte) ((HWIF(drive)->udma_four) &&
> #ifndef CONFIG_IDEDMA_IVB
>
"Pozsar Balazs wrote:"
from drivers/ide/ide-features.c:
/*
* All hosts that use the 80c ribbon mus use!
*/
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)-udma_four)
#ifndef CONFIG_IDEDMA_IVB
(drive-id-hw_config 0x4000)
On Mon, 19 Feb 2001, Andre Hedrick wrote:
On Mon, 19 Feb 2001, Pozsar Balazs wrote:
from drivers/ide/ide-features.c:
/*
* All hosts that use the 80c ribbon mus use!
*/
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)-udma_four)
#ifndef
On Tue, Feb 20, 2001 at 05:45:52PM +, Hugh Dickins wrote:
from drivers/ide/ide-features.c:
/*
* All hosts that use the 80c ribbon mus use!
*/
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)-udma_four)
#ifndef
On Tue, 20 Feb 2001, Vojtech Pavlik wrote:
On Tue, Feb 20, 2001 at 05:45:52PM +, Hugh Dickins wrote:
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)-udma_four)
#ifndef CONFIG_IDEDMA_IVB
(drive-id-hw_config
Bill Wendling wrote:
>
> The use of the ternary operator is superfluous, though...and makes the
> code look ugly IMNSHO :).
>
You are correct. Please ignore my thinko.
Tom
--
The Daemons lurk and are dumb. -- Emerson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Bill Wendling wrote:
>
> Also sprach Andre Hedrick:
> } On Mon, 19 Feb 2001, Pozsar Balazs wrote:
> }
> } > from drivers/ide/ide-features.c:
> } >
> } > /*
> } > * All hosts that use the 80c ribbon mus use!
> } > */
> } > byte eighty_ninty_three (ide_drive_t *drive)
> } > {
> } >
On Mon, 19 Feb 2001, Bill Wendling wrote:
> The use of the ternary operator is superfluous, though...and makes the
> code look ugly IMNSHO :).
What is ugly is that the commitee can not decide if there is going to be
host-side only, device-side only or both-side.
Cheers,
Andre Hedrick
Linux
Also sprach Andre Hedrick:
} On Mon, 19 Feb 2001, Pozsar Balazs wrote:
}
} > from drivers/ide/ide-features.c:
} >
} > /*
} > * All hosts that use the 80c ribbon mus use!
} > */
} > byte eighty_ninty_three (ide_drive_t *drive)
} > {
} > return ((byte) ((HWIF(drive)->udma_four) &&
} >
On Mon, 19 Feb 2001, Pozsar Balazs wrote:
> from drivers/ide/ide-features.c:
>
> /*
> * All hosts that use the 80c ribbon mus use!
> */
> byte eighty_ninty_three (ide_drive_t *drive)
> {
> return ((byte) ((HWIF(drive)->udma_four) &&
> #ifndef CONFIG_IDEDMA_IVB
>
from drivers/ide/ide-features.c:
/*
* All hosts that use the 80c ribbon mus use!
*/
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)->udma_four) &&
#ifndef CONFIG_IDEDMA_IVB
(drive->id->hw_config & 0x4000) &&
#endif /*
from drivers/ide/ide-features.c:
/*
* All hosts that use the 80c ribbon mus use!
*/
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)-udma_four)
#ifndef CONFIG_IDEDMA_IVB
(drive-id-hw_config 0x4000)
#endif /* CONFIG_IDEDMA_IVB */
On Mon, 19 Feb 2001, Pozsar Balazs wrote:
from drivers/ide/ide-features.c:
/*
* All hosts that use the 80c ribbon mus use!
*/
byte eighty_ninty_three (ide_drive_t *drive)
{
return ((byte) ((HWIF(drive)-udma_four)
#ifndef CONFIG_IDEDMA_IVB
Also sprach Andre Hedrick:
} On Mon, 19 Feb 2001, Pozsar Balazs wrote:
}
} from drivers/ide/ide-features.c:
}
} /*
} * All hosts that use the 80c ribbon mus use!
} */
} byte eighty_ninty_three (ide_drive_t *drive)
} {
} return ((byte) ((HWIF(drive)-udma_four)
} #ifndef
On Mon, 19 Feb 2001, Bill Wendling wrote:
The use of the ternary operator is superfluous, though...and makes the
code look ugly IMNSHO :).
What is ugly is that the commitee can not decide if there is going to be
host-side only, device-side only or both-side.
Cheers,
Andre Hedrick
Linux ATA
Bill Wendling wrote:
Also sprach Andre Hedrick:
} On Mon, 19 Feb 2001, Pozsar Balazs wrote:
}
} from drivers/ide/ide-features.c:
}
} /*
} * All hosts that use the 80c ribbon mus use!
} */
} byte eighty_ninty_three (ide_drive_t *drive)
} {
} return ((byte)
Bill Wendling wrote:
The use of the ternary operator is superfluous, though...and makes the
code look ugly IMNSHO :).
You are correct. Please ignore my thinko.
Tom
--
The Daemons lurk and are dumb. -- Emerson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
20 matches
Mail list logo
