Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Ville Syrjälä
On Mon, Sep 28, 2020 at 08:20:59PM +0300, Jani Nikula wrote: > On Mon, 28 Sep 2020, Ville Syrjälä wrote: > > On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: > >> On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > >> > On Mon, 28 Sep 2020, Tejas Upadhyay > >> > wrote: >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Jani Nikula
On Mon, 28 Sep 2020, Matt Roper wrote: > On Mon, Sep 28, 2020 at 04:07:39PM -0700, Lucas De Marchi wrote: >> On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: >> > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" >> > wrote: >> > > This is a good example of a potential trap

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Lucas De Marchi
On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: This is a good example of a potential trap that having IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder might change the if ladder to have

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Matt Roper
On Mon, Sep 28, 2020 at 04:07:39PM -0700, Lucas De Marchi wrote: > On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: > > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" > > wrote: > > > This is a good example of a potential trap that having > > > IS_ELKHARTLAKE() cover

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Ville Syrjälä wrote: > On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: >> On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: >> > On Mon, 28 Sep 2020, Tejas Upadhyay >> > wrote: >> > > JSL has update in vswing table for eDP >> > >> > I've thought

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: > This is a good example of a potential trap that having > IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder > might change the if ladder to have IS_ELKHARTLAKE() first, and the > subsequent

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Ville Syrjälä
On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: > On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > > On Mon, 28 Sep 2020, Tejas Upadhyay > > wrote: > > > JSL has update in vswing table for eDP > > > > I've thought the TLA for Jasper Lake is JSP, not JSL. At least we

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread James Ausmus
On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > On Mon, 28 Sep 2020, Tejas Upadhyay > wrote: > > JSL has update in vswing table for eDP > > I've thought the TLA for Jasper Lake is JSP, not JSL. At least we have > PCH_JSP for Jasper Lake PCH. JSP == Point (the PCH), JSL == Lake

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Tejas Upadhyay wrote: > JSL has update in vswing table for eDP I've thought the TLA for Jasper Lake is JSP, not JSL. At least we have PCH_JSP for Jasper Lake PCH. > > BSpec: 21257 > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 67