Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-14 Thread Matthias Kaehlcke
El Fri, Jul 14, 2017 at 03:43:35PM -0700 Grant Grundler ha dit: > On Fri, Jul 14, 2017 at 2:35 PM, Daniel Vetter wrote: > > On Fri, Jul 14, 2017 at 7:32 PM, Grant Grundler > > wrote: > >> On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula > >> wrote: > >>> On Thu, 13 Jul 2017, Stéphane Marchesin >

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-14 Thread Grant Grundler
On Fri, Jul 14, 2017 at 2:35 PM, Daniel Vetter wrote: > On Fri, Jul 14, 2017 at 7:32 PM, Grant Grundler wrote: >> On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula >> wrote: >>> On Thu, 13 Jul 2017, Stéphane Marchesin >>> wrote: So, if you think this is wrong, can you fix this warning in a way

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-14 Thread Daniel Vetter
On Fri, Jul 14, 2017 at 7:32 PM, Grant Grundler wrote: > On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula > wrote: >> On Thu, 13 Jul 2017, Stéphane Marchesin wrote: >>> So, if you think this is wrong, can you fix this warning in a way that >>> you'd like? >> >> As I replied previously [1], with more

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-14 Thread Grant Grundler
On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula wrote: > On Thu, 13 Jul 2017, Stéphane Marchesin wrote: >> So, if you think this is wrong, can you fix this warning in a way that >> you'd like? > > As I replied previously [1], with more background, fixing the warnings > properly, in a way that actual

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-14 Thread Jani Nikula
On Thu, 13 Jul 2017, Stéphane Marchesin wrote: > So, if you think this is wrong, can you fix this warning in a way that > you'd like? As I replied previously [1], with more background, fixing the warnings properly, in a way that actually improves the code instead of making it worse, would mean a

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-13 Thread Stéphane Marchesin
On Thu, Jul 13, 2017 at 10:42 AM, Ville Syrjälä wrote: > On Thu, Jul 13, 2017 at 09:23:11AM -0700, Stéphane Marchesin wrote: >> On Thu, Jul 13, 2017 at 3:13 AM, Ville Syrjälä >> wrote: >> > On Wed, Jul 12, 2017 at 07:28:14PM -0700, Stéphane Marchesin wrote: >> >> On Fri, May 5, 2017 at 10:40 AM,

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-13 Thread Ville Syrjälä
On Thu, Jul 13, 2017 at 09:23:11AM -0700, Stéphane Marchesin wrote: > On Thu, Jul 13, 2017 at 3:13 AM, Ville Syrjälä > wrote: > > On Wed, Jul 12, 2017 at 07:28:14PM -0700, Stéphane Marchesin wrote: > >> On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä > >> wrote: > >> > > >> > On Fri, May 05, 2017

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-13 Thread Stéphane Marchesin
On Thu, Jul 13, 2017 at 3:13 AM, Ville Syrjälä wrote: > On Wed, Jul 12, 2017 at 07:28:14PM -0700, Stéphane Marchesin wrote: >> On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä >> wrote: >> > >> > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: >> > > El Thu, Apr 20, 2017 at 02:56

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-13 Thread Daniel Vetter
On Thu, Jul 13, 2017 at 01:13:51PM +0300, Ville Syrjälä wrote: > On Wed, Jul 12, 2017 at 07:28:14PM -0700, Stéphane Marchesin wrote: > > On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä > > wrote: > > > > > > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > > > > El Thu, Apr 20,

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-13 Thread Ville Syrjälä
On Wed, Jul 12, 2017 at 07:28:14PM -0700, Stéphane Marchesin wrote: > On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä > wrote: > > > > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > > > El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > > > > > > > In several

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-07-12 Thread Stéphane Marchesin
On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä wrote: > > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > > El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > > > > > In several instances the driver passes an 'enum pipe' value to a > > > function expecting an

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-08 Thread Jani Nikula
On Mon, 08 May 2017, Daniel Vetter wrote: > On Fri, May 05, 2017 at 08:40:43PM +0300, Ville Syrjälä wrote: >> On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: >> > El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: >> > >> > > In several instances the driver pass

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-08 Thread Daniel Vetter
On Fri, May 05, 2017 at 08:40:43PM +0300, Ville Syrjälä wrote: > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > > El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > > > > > In several instances the driver passes an 'enum pipe' value to a > > > function expec

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-05 Thread Matthias Kaehlcke
Hi, El Fri, May 05, 2017 at 01:29:32PM -0700 Grant Grundler ha dit: > On Fri, May 5, 2017 at 1:08 PM, Ville Syrjälä > wrote: > ... > >> > I'm not convinced the patch is making things any better really. To > >> > fix this really properly, I think we'd need to introduce a new enum > >> > pch_trans

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-05 Thread Grant Grundler
On Fri, May 5, 2017 at 1:08 PM, Ville Syrjälä wrote: ... >> > I'm not convinced the patch is making things any better really. To >> > fix this really properly, I think we'd need to introduce a new enum >> > pch_transcoder and thus avoid the confusion of which type of >> > transcoder we're talking

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-05 Thread Ville Syrjälä
On Fri, May 05, 2017 at 12:12:49PM -0700, Grant Grundler wrote: > On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä > wrote: > > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > >> El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > >> > >> > In several instances

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-05 Thread Grant Grundler
On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä wrote: > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: >> El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: >> >> > In several instances the driver passes an 'enum pipe' value to a >> > function expecting an 'enum

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

2017-05-05 Thread Ville Syrjälä
On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > > > In several instances the driver passes an 'enum pipe' value to a > > function expecting an 'enum transcoder' and viceversa. Since PIPE_x and > > TRANSCODER_