Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-02-03 Thread Zhang Rui
On Tue, 2013-01-29 at 11:10 +0100, Daniel Vetter wrote: > On Mon, Jan 28, 2013 at 06:06:38PM +0800, Zhang Rui wrote: > > On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: > > > On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui wrote: > > > >> Given that this essentially requires users to manually

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-02-03 Thread Zhang Rui
On Tue, 2013-01-29 at 11:10 +0100, Daniel Vetter wrote: On Mon, Jan 28, 2013 at 06:06:38PM +0800, Zhang Rui wrote: On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui rui.zh...@intel.com wrote: Given that this essentially requires users to

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-29 Thread Daniel Vetter
On Mon, Jan 28, 2013 at 06:06:38PM +0800, Zhang Rui wrote: > On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: > > On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui wrote: > > >> Given that this essentially requires users to manually set this module > > >> option to make stuff work I don't like

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-29 Thread Daniel Vetter
On Mon, Jan 28, 2013 at 06:06:38PM +0800, Zhang Rui wrote: On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui rui.zh...@intel.com wrote: Given that this essentially requires users to manually set this module option to make stuff work I don't

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-28 Thread Zhang Rui
On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: > On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui wrote: > >> Given that this essentially requires users to manually set this module > >> option to make stuff work I don't like this. > >> > > sorry, I do not understand. > > this patch just

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-28 Thread Daniel Vetter
On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui wrote: >> Given that this essentially requires users to manually set this module >> option to make stuff work I don't like this. >> > sorry, I do not understand. > this patch just disables modeset_on_lid during suspend. Pardon me, the misunderstanding

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-28 Thread Daniel Vetter
On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui rui.zh...@intel.com wrote: Given that this essentially requires users to manually set this module option to make stuff work I don't like this. sorry, I do not understand. this patch just disables modeset_on_lid during suspend. Pardon me, the

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-28 Thread Zhang Rui
On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui rui.zh...@intel.com wrote: Given that this essentially requires users to manually set this module option to make stuff work I don't like this. sorry, I do not understand. this patch just

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Zhang Rui
On Sun, 2013-01-27 at 16:45 +0100, Daniel Vetter wrote: > On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > > i915 driver needs to do modeset when > > 1. system resumes from sleep > > 2. lid is opened > > > > In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, > > thus it is

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Daniel Vetter
On Sun, Jan 27, 2013 at 11:21 PM, Rafael J. Wysocki wrote: >> Given that this essentially requires users to manually set this module >> option to make stuff work I don't like this. >> >> I see a few possible options: >> - plug the races between all the different parts - I've never really >>

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Rafael J. Wysocki
On Sunday, January 27, 2013 04:45:51 PM Daniel Vetter wrote: > On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > > i915 driver needs to do modeset when > > 1. system resumes from sleep > > 2. lid is opened > > > > In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, > > thus

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Daniel Vetter
On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > i915 driver needs to do modeset when > 1. system resumes from sleep > 2. lid is opened > > In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, > thus it is the i915_resume code does the modeset rather than >

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Daniel Vetter
On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui rui.zh...@intel.com wrote: i915 driver needs to do modeset when 1. system resumes from sleep 2. lid is opened In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, thus it is the i915_resume code does the modeset rather than

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Rafael J. Wysocki
On Sunday, January 27, 2013 04:45:51 PM Daniel Vetter wrote: On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui rui.zh...@intel.com wrote: i915 driver needs to do modeset when 1. system resumes from sleep 2. lid is opened In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes,

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Daniel Vetter
On Sun, Jan 27, 2013 at 11:21 PM, Rafael J. Wysocki r...@sisk.pl wrote: Given that this essentially requires users to manually set this module option to make stuff work I don't like this. I see a few possible options: - plug the races between all the different parts - I've never really

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Zhang Rui
On Sun, 2013-01-27 at 16:45 +0100, Daniel Vetter wrote: On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui rui.zh...@intel.com wrote: i915 driver needs to do modeset when 1. system resumes from sleep 2. lid is opened In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, thus