Re: [Intel IOMMU][patch 3/8] Generic hardware support for Intel IOMMU.

2007-04-24 Thread Andi Kleen
On Wednesday 25 A > > It doesn't seem to enable sg merging? Since you have enough space > > that should work. > We actually have a patch to do sg merge. In my test, it doesn't have any > performance gain. It probably depends on the IO device and how slow or fast it is at walking sg lists. I saw

Re: [Intel IOMMU][patch 3/8] Generic hardware support for Intel IOMMU.

2007-04-24 Thread Shaohua Li
On Tue, 2007-04-24 at 21:27 +0200, Andi Kleen wrote: > On Tuesday 24 April 2007 08:03:02 Ashok Raj wrote: > > > > +#ifdef CONFIG_DMAR > > +#ifdef CONFIG_SMP > > +static void dmar_msi_set_affinity(unsigned int irq, cpumask_t mask) > > > Why does it need an own interrupt type? > > > + > > +config

Re: [Intel IOMMU][patch 3/8] Generic hardware support for Intel IOMMU.

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 09:27:08PM +0200, Andi Kleen wrote: > On Tuesday 24 April 2007 08:03:02 Ashok Raj wrote: > > > > +#ifdef CONFIG_DMAR > > +#ifdef CONFIG_SMP > > +static void dmar_msi_set_affinity(unsigned int irq, cpumask_t mask) > > > Why does it need an own interrupt type? Problem is it

Re: [Intel IOMMU][patch 3/8] Generic hardware support for Intel IOMMU.

2007-04-24 Thread Andi Kleen
On Tuesday 24 April 2007 08:03:02 Ashok Raj wrote: > > +#ifdef CONFIG_DMAR > +#ifdef CONFIG_SMP > +static void dmar_msi_set_affinity(unsigned int irq, cpumask_t mask) Why does it need an own interrupt type? > + > +config IOVA_GUARD_PAGE > + bool "Enables gaurd page when allocating IO Virtual