Re: [Intel IOMMU 02/10] PCI generic helper function

2007-06-26 Thread Keshavamurthy, Anil S
On Mon, Jun 25, 2007 at 10:49:37PM -0700, Andrew Morton wrote: > On Tue, 19 Jun 2007 14:37:03 -0700 "Keshavamurthy, Anil S" <[EMAIL > PROTECTED]> wrote: > > > +struct pci_dev * > > +pci_find_upstream_pcie_bridge(struct pci_dev *pdev) > > You didn't need a newline there, but that's what the rest

Re: [Intel IOMMU 02/10] PCI generic helper function

2007-06-25 Thread Andrew Morton
On Tue, 19 Jun 2007 14:37:03 -0700 "Keshavamurthy, Anil S" <[EMAIL PROTECTED]> wrote: > +struct pci_dev * > +pci_find_upstream_pcie_bridge(struct pci_dev *pdev) You didn't need a newline there, but that's what the rest of that file does. Hu hum. > +{ > + struct pci_dev *tmp = NULL; > + > +

[Intel IOMMU 02/10] PCI generic helper function

2007-06-19 Thread Keshavamurthy, Anil S
When devices are under a p2p bridge, upstream transactions get replaced by the device id of the bridge as it owns the PCIE transaction. Hence its necessary to setup translations on behalf of the bridge as well. Due to this limitation all devices under a p2p share the same domain in a DMAR. We just