Re: [KJ][PATCH] BIT macro cleanup

2007-03-30 Thread Milind Arun Choudhary
On 3/29/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Alexey Dobriyan wrote: > On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote: > >> +#define BIT(nr) (1UL << ((nr) % BITS_PER_LONG)) >> > > I think this would be a disaster because something like > >BIT(123) > > wo

Re: [KJ][PATCH] BIT macro cleanup

2007-03-28 Thread Richard Knutsson
Milind Arun Choudhary wrote: BIT macro cleanup,now in bitops.h Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h index 0de0c65..5aa3be5 100644 --- a/drivers/net/s2io.h +++ b/drivers/net/s2io.h @@ -14,6 +14,7 @@ #define _S2IO

Re: [KJ][PATCH] BIT macro cleanup

2007-03-28 Thread Richard Knutsson
Alexey Dobriyan wrote: On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote: --- a/include/linux/bitops.h +++ b/include/linux/bitops.h @@ -8,6 +8,9 @@ */ #include +#define BIT(nr)(1UL << ((nr) % BITS_PER_LONG)) I think this would be a disaster because some

Re: [KJ][PATCH] BIT macro cleanup

2007-03-28 Thread Alexey Dobriyan
On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote: > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -8,6 +8,9 @@ > */ > #include > > +#define BIT(nr) (1UL << ((nr) % BITS_PER_LONG)) I think this would be a disaster because something like BIT(

[KJ][PATCH] BIT macro cleanup

2007-03-27 Thread Milind Arun Choudhary
BIT macro cleanup,now in bitops.h Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- arch/ppc/platforms/chestnut.c |1 drivers/edac/edac_mc.h |2 - drivers/i2c/busses/i2c-pxa.c| 55 ++-- drivers/net