Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Richard Knutsson
Robert P. J. Day wrote: i'm not clear on what the possible problem is here: On Fri, 16 Feb 2007, Richard Knutsson wrote: Andreas Schwab wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Andreas Schwab wrote: Richard Knutsson <[EMAIL PROTECTED]> writes:

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Robert P. J. Day
i'm not clear on what the possible problem is here: On Fri, 16 Feb 2007, Richard Knutsson wrote: > Andreas Schwab wrote: > > Richard Knutsson <[EMAIL PROTECTED]> writes: > > > >> Andreas Schwab wrote: > >> > >>> Richard Knutsson <[EMAIL PROTECTED]> writes: > >>> > >>> > Vignesh Babu BM wrot

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Robert P. J. Day
On Fri, 16 Feb 2007, Richard Knutsson wrote: > Andreas Schwab wrote: > > Richard Knutsson <[EMAIL PROTECTED]> writes: > > > > > > > Vignesh Babu BM wrote: > > > > > > > @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) > > > > tr_pages = 0x15557000UL; > > > >

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Andreas Schwab
Richard Knutsson <[EMAIL PROTECTED]> writes: > Andreas Schwab wrote: >> Richard Knutsson <[EMAIL PROTECTED]> writes: >> >>> Andreas Schwab wrote: >>> Richard Knutsson <[EMAIL PROTECTED]> writes: > Vignesh Babu BM wrote: > >> @@ -175,7 +176,7 @@ stati

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Richard Knutsson
Andreas Schwab wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Andreas Schwab wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Vignesh Babu BM wrote: @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) tr_pages = 0x15557000UL;

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Andreas Schwab
Richard Knutsson <[EMAIL PROTECTED]> writes: > Andreas Schwab wrote: >> Richard Knutsson <[EMAIL PROTECTED]> writes: >> >> >>> Vignesh Babu BM wrote: >>> @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) tr_pages = 0x15557000UL; size = memparse(

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Richard Knutsson
Andreas Schwab wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Vignesh Babu BM wrote: @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) tr_pages = 0x15557000UL; size = memparse(str, &str); - if (*str || (size & (size-1)) || !(tr_pages &

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Andreas Schwab
Richard Knutsson <[EMAIL PROTECTED]> writes: > Vignesh Babu BM wrote: >> @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) >> tr_pages = 0x15557000UL; >> size = memparse(str, &str); >> -if (*str || (size & (size-1)) || !(tr_pages & size) || >> +if (*str ||

Re: [KJ] [PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Richard Knutsson
Vignesh Babu BM wrote: Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 diff --git a/arch/ia64/mm/hugetlbpage.c b/arch/ia64/mm/hugetlbpage.c index 0c7e94e..0ccc70e 100644 --- a/arch/ia64/mm/hugetlbpage.c +++ b/arch/ia64/mm/hugetlbpage.c @@ -16,6 +16,7 @@ #include

[KJ][PATCH] is_power_of_2 in ia64mm

2007-02-16 Thread Vignesh Babu BM
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 diff --git a/arch/ia64/mm/hugetlbpage.c b/arch/ia64/mm/hugetlbpage.c index 0c7e94e..0ccc70e 100644 --- a/arch/ia64/mm/hugetlbpage.c +++ b/arch/ia64/mm/hugetlbpage.c @@ -16,6 +16,7 @@ #include #include #include +#in