Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore

On 10:46 Mon 16 Apr , Roland Dreier wrote: > > - down_interruptible(&info->write_sem); > > + if(mutex_lock_interruptible(&info->write_lock)){ > > + return -ERESTARTSYS; > > + } > > 1) This is a semantic change. Of course using down_interruptible() > without checking the return

Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore

> -down_interruptible(&info->write_sem); > +if(mutex_lock_interruptible(&info->write_lock)){ > +return -ERESTARTSYS; > +} 1) This is a semantic change. Of course using down_interruptible() without checking the return value is almost certainly a bug, but have you though

[KJ][PATCH]Rocket port:use mutex instead of binary semaphore

Use mutex instead of binary semaphore for mutual exclusion. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- rocket.c | 22 -- rocket_int.h |2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/char/rocket.c b/drivers/char/rock