Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Robert P. J. Day
On Mon, 13 Aug 2007, Roland Dreier wrote: > > from my days submitting numerous patches of this type, i can recall > > that in cases like the above, it's a judgment call -- use kzalloc to > > get the zeroing, or use kcalloc to get the array-flavoured behaviour. > > what a shame you can't have

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Roland Dreier
> from my days submitting numerous patches of this type, i can recall > that in cases like the above, it's a judgment call -- use kzalloc to > get the zeroing, or use kcalloc to get the array-flavoured behaviour. > what a shame you can't have both at the same time. kcalloc() zeros memory just

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Robert P. J. Day
On Mon, 13 Aug 2007, Mariusz Kozlowski wrote: > > Hi, > >Replacing kmalloc with kzalloc and cleaning up memset in > > arch/i386/kernel/io_apic.c > > > > > > Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> > > --- > > > > diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Mariusz Kozlowski
> Hi, >Replacing kmalloc with kzalloc and cleaning up memset in > arch/i386/kernel/io_apic.c > > > Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> > --- > > diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c > index 4b8a8da..1329615 100644 > ---

[KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Surya Prabhakar N
Hi, Replacing kmalloc with kzalloc and cleaning up memset in arch/i386/kernel/io_apic.c Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> --- diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c index 4b8a8da..1329615 100644 --- a/arch/i386/kernel/io_apic.c +++

[KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Surya Prabhakar N
Hi, Replacing kmalloc with kzalloc and cleaning up memset in arch/i386/kernel/io_apic.c Signed-off-by: Surya Prabhakar [EMAIL PROTECTED] --- diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c index 4b8a8da..1329615 100644 --- a/arch/i386/kernel/io_apic.c +++

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Mariusz Kozlowski
Hi, Replacing kmalloc with kzalloc and cleaning up memset in arch/i386/kernel/io_apic.c Signed-off-by: Surya Prabhakar [EMAIL PROTECTED] --- diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c index 4b8a8da..1329615 100644 --- a/arch/i386/kernel/io_apic.c +++

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Robert P. J. Day
On Mon, 13 Aug 2007, Mariusz Kozlowski wrote: Hi, Replacing kmalloc with kzalloc and cleaning up memset in arch/i386/kernel/io_apic.c Signed-off-by: Surya Prabhakar [EMAIL PROTECTED] --- diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c index

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Roland Dreier
from my days submitting numerous patches of this type, i can recall that in cases like the above, it's a judgment call -- use kzalloc to get the zeroing, or use kcalloc to get the array-flavoured behaviour. what a shame you can't have both at the same time. kcalloc() zeros memory just

Re: [KJ] replacing kmalloc with kzalloc in io_apic.c

2007-08-13 Thread Robert P. J. Day
On Mon, 13 Aug 2007, Roland Dreier wrote: from my days submitting numerous patches of this type, i can recall that in cases like the above, it's a judgment call -- use kzalloc to get the zeroing, or use kcalloc to get the array-flavoured behaviour. what a shame you can't have both at